text
stringlengths
5
998
label
int64
0
1
> We can maybe change the informationType prop to an array, so that it can support more than one field in a step. It's just so crazy it might work, captain! \U0001f596 I'll refactor.
0
why this takes a handle as output I will never understand lol. good catch
0
Hm ok, this is probably fine for prototyping but users will expect to be able to set a port range in production. This can be a flag config passed to raylet and it can assign them sequentially to workers, or something like that.
0
swig should be a host tool
0
This is one hell of a weird check that's never true
1
This is ridiculous I am force merging. I have no idea what is going on in CI. @lberk Thanks for the fix.
1
Can this be fixed finally? The timeout is ridiculous and it is extremely annoying having to wait 10 seconds after every reset. Not to mention it makes waking up from deepsleep a bit stupid.
1
Hence below: ``` self.cpp_info.components[lib].names["pkg_config"] = avahi_lib ```
0
You two partially crazy people... you might be on to something! I think it's perhaps best to try this separately \u2014 removing the saved state indicator, and replacing it with a snackbar. But it could work!
0
Nit: `auto*`
0
We could use from the GitHub Actions `TEST_MSSQL_URI: mssql://SA:Pr1sm4_Pr1sm4@localhost:1433/master`
0
No need to have too long a discussion either, I think we should do this (and honestly it sucks that we haven't so far). Just a matter of timing. Now that we've shipped, I'll bring this up with the team and we'll try to do this soon.
1
Yep, I will give that a shot.
0
Why is it silly? Regardless, sure, I can make it a local function.
0
Unrelated Travis nonsense
1
https://github.com/elastic/kibana/pull/58292/commits/eb932978dd40ddf1b3f3a2443e997e7a59f1f3a2
0
BTW: It's not a personal attack. I don't trust/lecturing myself the same way all the time. Before I push something I review my commits and I still fuck things up in regular fashion.
1
eh, it was always like this, would rather not fuck with it.
1
![You code in my universe, normie.](http://puu.sh/v8lLo/99200d3420.png)
0
```suggestion To use a class as parameter, you have to bind its class metadata: ``$query->setParameter(0, $em->getClassMetadata(CompanyEmployee::class);``. ```
0
```suggestion // because the payloads can be huge. debuglog('< Debugger.scriptParsed: ', payloadStr.substring(100), '...'); ```
0
Please add something related to the fucking bikers that like to swerve in front of you going 20 in a 40 instead of staying in their fucking bike lane
1
Does this even log any other attack message? Or just "tried to knock you unconscious"? Because that's not very descriptive as to what the fuck is going on
1
```suggestion - name: create LV on disk ```
0
Nevermind, I see you skip the upgrade if there are more than one pools defined. That's not perfect but I guess we can tell those users how to fix their profiles if they got that far.
0
Either deindent this by 4 or move it to the end of the previous line.
0
Technically we could leave it off and it'll default to undefined right now! But I don't know, how can you know what's right in JavaScript, amiright?
0
Please ensure that at least some unit test runs multiple groups and/or versions, otherwise the concurrency isn't really tested.
0
How many of the inputs can be passed to the base-class init instead of dealing with them explicitly here?
0
This is going to be flaky. If you didn't do any sleep and did `runPendingTasks()`, that would be better, but 10ms still seems too small to be semi-reliable.
0
I looked into that, .net does not have any glob pattern support - they instead have a nuget package you can reference: https://www.nuget.org/packages/Microsoft.Extensions.FileSystemGlobbing/ I didn't want to add additional deps for this now, but I can file a task.
0
Thanks for the information @mattmacy.
0
@Bawhoppen furry shit is a fetish people forcing their fetish into video games is what ruins video games
1
Damn, did I miss that one? Yup I did. Fixed!
1
magic number 4 should be named constant
0
I would suggest adding a link a link to https://pkg.go.dev/github.com/hashicorp/packer-plugin-sdk/packer/registry/image#Image ```suggestion The [Image metadata](https://pkg.go.dev/github.com/hashicorp/packer-plugin-sdk/packer/registry/image#Image) structure is: ```
0
oh, nevermind, this looks good.
0
Or, way up the cost of ```-=``` and a ```.len```, vs a single ```.Remove()``` ``` if(loadedItems.Remove(A)) var/obj/item/I = A loadedWeightClass -= I.w_class ```
0
It also looks weird with a starting capital letter and then snake-case?
1
With validate=false, it fails with similar error ``` error: unable to decode "kustomization.yaml": Object 'Kind' is missing in `<truncated>` ```
0
Prefix private datastructures with an underscore and add a comment explaining what this map is for
0
@auturgy ^^^^
0
> needs to look like a unique ID I am not aware of any such requirement. Also, is profile something that can be changed by a user ? If so, why not just use user_id and measurement ?
0
That's not really relevant to this PR, the diff just shows it weird.
1
Why is it defined here instead of in `executor/errors.go` like other errors?
0
> remove spaces from `ref` attribute not that easy on pug, though all that online editors is a rubbish.. some of them doesn't support preprocessors, some `<script setup>` but i'll try, wait a min
1
```suggestion manager_class = cls ```
0
This is not a personal clone, it uses flag 0x10 Only Visible To Summoner, however. There seems to be a bug in current PhaseShift code where summoned creatures aren't able to inherit a non-cosmetic phase from its summoner upon switching.
0
```suggestion ty::BindByValue { .. } => { ``` (here and elsewhere)
0
this label needs to be: `app.kubernetes.io/name`
0
updated in #29995, please review
0
because I kind of hoped someone who knew how text worked better would be able to improve my shitty-looking-but-functional countdown
1
__[flake8]__ * [F405] 'build_unix_rpath_args' may be undefined, or defined from star imports: .compilers <!-- Comment by [SideCI](https://sideci.com) -->
0
The idea here, is to copy the user input, in order to change the db from something to template1. I would never change the initial value of the object, just making a local copy of it, in order to pass this specific case.
0
https://github.com/matrix-org/synapse/pull/5863
0
god damn it, feels like javascript ![http://wallpapercave.com/wp/9PDbRsp.png](http://wallpapercave.com/wp/9PDbRsp.png)
1
We don't need to use `css` here you can just return a string
0
Use one pair of double quotes around the log string. Break the line by ending with a double quote, and then continue with a new double quote on the next line.
0
This is awful, we have an organ generation framework for this shit
1
May be DIsksTool or DisksApp can more obviously describe purpose of this class
0
+1 to not removing the Dockerfile from the context by default - when I do `COPY . /data` i _do_ assume i get everything that is not in the `.dockerignore`, including `.dotfiles` (damn) and the `Dockerfile`
1
I felt like the backslashes were starting to get outnumbered ; )
0
You mean place a quote around the defence type or what? E: ok.
0
Okay. I'll prepare the PR for the implementation of MinDomains.
0
How about "excessive"? Absurd sounds a bit excessive a warning to me.
1
This is a library function. Let's keep the function signature unless necessary. Also perhaps the follwoRedirects is still useful in other use cases?
0
man this var name sucks
1
- make this a static constant and make it a precompiled pattern for efficiency (see https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html) - actually is it redundant from `ZookeeperAuthority .ZOOKEEPER_PATTERN`? We should not define two identical constants
0
Works on PC. This is almost certainly one of those wacky Adreno stencil/discard driver bugs. Which GPU does your device have again?
1
are all those white spaces necessary?
0
Run back in your mami's placenta, your nit gunna squeezeIm on the block with the centers getting grind from the chesseWhile I was on the stret hustling with real dykesYuou wa letting niggas throw the banana in your tailpipe
1
All I wanted was a quick fix dammit
1
nevermind, you need it to avoid leaking this one
0
I corrected
0
Sorry, my indentation in this file is off. Another accindent! Will fix when I rebase and merge.
0
We're changing "" to '' elsewhere, might as well nip it in the bud here.
0
I got yelled at for doing stuff like this once
0
I reworked this to have the connection pay attention to the context. With connections closing quickly we can let shutdown happen gracefully and remove the 10 second timeout. Shutdown will block which prevents the accumulator from going away while the connection needs it, so the panic should still be prevented.
0
https://github.com/jenkinsci/jenkins/pull/4086
0
Yes, this is configurable, you can set the supervision strategy stage by stage in the user API. My question is whether these stages (scan/fold) support the Resume strategy right now (maybe they do, but I don't remember)
0
(probably meant bool)
0
Holy crap this was hard
1
p.Do(first); p.Do(second);
0
don't need the and
0
Defined but lot loaded, this is why travis is screaming at you.
1
```suggestion \tcontent: '"#ABABAB"', ``` Let's use a valid hex.
0
Please improve the docstring to explain when this is called. Maybe `terminate_discovery_updates` or `stop_discovery_updates` would be a better name?
0
You can tell me when I have a brain fart :D
1
Don't know what a thing_storm is so I'd rather not touch it if that's the case
0
```suggestion @todo Scenario: Seeing applied catalog promotion only on proper variants ```
0
Bingo, I just found the remaining bastard ! sRGB-primary-blue-continuous_06
1
Ok, I agree that it makes probably more sense (at least for now) to move this into `gnrc_ndp_rtr_adv_handle()` (by the way this function is awfully long...).
1
yup sounds good
0
set `private`
0
```suggestion \t\tlogutil.BgLogger().Info("addLocks lock has been committed or rolled back", zap.Uint64("commit ts", commitTS)) ```
0
@dianakhuang also here - should we really be calling `to_deprecated_string`?
0
Finally, all expressions bound on legacy `TimeZone` have been gone.
0
Thank you. But I think we should use `assertLessEqual` because there is not `assertLe` method in unit python test. I will use it!
0
@boegel might be. I have never tried. And anyway, I find ridiculous a 64 character limit in 2015...
1
shouldn't we use typedBindingPatternNode here? ```json { "name": "typedBindingPattern", "type": "TypedBindingPatternNode" }, ```
0