text
stringlengths 5
998
| label
int64 0
1
|
|---|---|
I'm still concerned about the absurdly high armor values of the new ESAPI vests. Are we sure that those are in line with reality? They seem extraordinarily powerful, especially if compared to other armor in the game. | 1 |
Done. I've had to use `cfg(target_pointer_width)` to make sure all bits have something interesting. | 0 |
This also fails if you're using `expressionContext`. Both values will be undefined, the values under that key have a numbered index (which corresponds to the index of the associated function in the expression).  | 0 |
```suggestion + Add `--device` support for Windows. [moby/moby#37638](https://github.com/moby/moby/pull/37638) ``` | 0 |
Using an `m` prefix was confusing the hell out of me here as I was expecting it to be a member of this or another class... :rage: | 1 |
wow that's so pretty! It could even be a one-liner, if you're into that sort of thing. | 0 |
should be this. | 0 |
Yes I think you are right that this is worrisome, possibly a symptom of some latent bug in the PR. I'll try to take some time on Monday to dig into it if you don't resolve it yourself today or over the weekend. | 0 |
No, the more I look at gas mixture code, the more I realise that I have no fucking clue about any of it. | 1 |
gah. I swore I removed that. | 0 |
Could you fix the space intend? Use 2 spaces :+1: | 0 |
> i copy pasted it > don't start shit m8, it's my job to start shit. > P.S. tabs for life Wrong. Tabs for indentation, spaces for alignment. | 1 |
This piece of information does not make sense on its own, it should be a part of the same module as the one that containts `About pod security admission alerts` This should be a second level heading in that section. | 0 |
Ya, that isn't gunna fly, it just screams race condition. There has to be a more robust method to do this. | 0 |
This needs to be `<String>[...]` to make Travis happy | 0 |
Maybe we should include the purpose of the operation, i.e.: "Add: New convenience operation 'GET /v1/contextEntities' to get all existing entitites" | 0 |
https://github.com/Sylius/Sylius/pull/14508 | 0 |
You're right, I was being a bot. | 0 |
I don't know why this shit keeps happening | 1 |
The answer (o/p in current branch) is giving two points so I think that `circles are not only touching externally` so the property (`distance between the center points should be the sum or difference of the radii.) `will not work here. The reason I find it absurd because the answer seems too unsimplified and long to mee but now I think that answer can be unsimplified and long because of the ugly circles equation we have used here. | 1 |
I feel this should be: ``` julia showerror(io::IO, ex::InitError) = print(io, "InitError: during initialization of module $(ex.mod")) ``` the backtrace will already be appended | 0 |
Metrics/LineLength: Line is too long. [118/80]<br>Style/FormatString: Favor `format` over `String#%`. | 0 |
May be wrap all those settings in something like: ``` java static public final class DEFAULTS { public final static String BIN = "bin"; public final static String CONFIG = "config"; // Others } ``` I would also use `public` so we can reuse those paths elsewhere: I'm pretty sure we are using `_site` somewhere else in code and in tests. | 0 |
`\tcost = 3` Best compromise I can make, but I want to keep an eye on this to see if it get abused to hell. Sound good? | 1 |
It should be `removing` right? or log it after remove operation. | 0 |
Please remove this file from your PR, this is not necessary | 0 |
I ask because... this is a micro-optimization somebody could easily accidentally remove or not fully understand and fail to maintain. | 0 |
Agree. Should find out what is better with data | 0 |
```suggestion process dalam sebuah Pod. Ketika pembagian namespace process diaktifkan untuk sebuah Pod, ``` | 0 |
Oh god, I remember this one yeah. A mecha tool trying to make an event... forgot to remove it back when I fixed that shit \U0001f605 | 1 |
Instead of having this unique `max_multigroups++;` we should move the one in line 377 to the top of the while loop. It will be more clear to understand the logic. | 0 |
Ooops. I must have missed this lousy translation. But it's definitely "This week's best articles." (\U0001f1eb\U0001f1f7 : "Les meilleurs articles de cette semaine" ) | 0 |
@ashfurrow oh, by that I basically just mean I never find actions like copy & paste on a phone quite as fluid as on desktop, so I breathe a sigh of relief whenever something has a clear filename. :) Maybe I just have clumsy thumbs! | 1 |
> ALL CHECKS HAVE PASSED LET THE MEMES BEGIN I am ready for this shitshow. | 1 |
@Gregoor Do you mind if I merge it? I don't want to suck you into a lengthy review for something that's not nearly as important as Markdown. But it would be nice to have a sanity check and a skim-through of some of the code. The biggest risk right now is that we land something imperfect that (translators) users won't accept that it's not perfect. But I hope to "launch" it to our super-user translators and have them play with it. There's no need for a big and loud launch. | 1 |
To be in line with how other similar "action" based methods in Anomaly Explorer are done I suggest to make `action` first argument. | 0 |
guys the robot mask doesnt make you a robot wtf | 1 |
Oh cool, thanks! Will give that a shot. | 0 |
I know this will work, but I feel a bit uncomfortable defining `APEX_SOURCE_DIR` here. It's actually defined by APEX itself as well and could in principle change once you do `add_subdirectory(${APEX_SOURCE_DIR} ...)`. Maybe you can just do ``` add_subdirectory(${APEX_ROOT}/src/apex ...) include_directories(${APEX_SOURCE_DIR}) ``` ? | 0 |
note to moi et steve: clarifier ce truc | 0 |
To @pllim's first suggestion `solar_system.MERCURY`: I don't really see that as a half-way compromise in terms of ease of use, because that would require 20 characters to get mercury instead of one, and anyone needing multiple planets would need to import a bunch of extra variables to use the tools. To @mhvk, I'm also not sure what `PLANETS.get(index, index)` is meant to do. | 0 |
yeah, a ton of time | 0 |
silly thing, but this should be above the promises | 0 |
This is the kind of bullshit you expect to see when people share the worst code they've ever seen | 1 |
`sizes` is no longer supported in Prebid 3. `mediaTypes.banner.sizes` should be used instead. | 0 |
What else do we have for "FUCK YOU, YOUR INPUTS DO NOT MATTER", that isn't also available to players somehow? | 1 |
I would rather only call out the affected components to avoid feature-gate sprawl. | 0 |
We probably should do all the IPC side changes and the pure HDFS ones in a separate PR and then have this PR just with the RBF side. | 0 |
mob sizes are different on eris, and really fucked up. these numbers may need rebalanced, better yet the mob sizes themselves should be changed | 1 |
One other thing, did you test cyro still works after these topic changes? | 0 |
`## Change the keyboard language on Windows` | 0 |
I hope new version is better. | 0 |
Notable stupid shit found in blob_act() See above comment. | 1 |
yep, I think when you merge this can pretty much go crazy on params / fixtures. | 0 |
Wacky!! If there is a file that has the words config.json it errors https://github.com/yakov116/TestR | 1 |
haha holy crap what a brain fart | 1 |
Too much stock market for today? :trollface: | 0 |
Shit woops please give me about twelve hours | 1 |
Oh, got it. | 0 |
You are right, adding it in. | 0 |
I'd rather have soft-wrap enabled by default. Scrolling long lines gets pretty ridiculous IMO. | 1 |
Im not at home and i cant webedit it. Ill do it when i get home As well as some shit with altclickon so holding alt to walk works | 1 |
This will probably be truthful after the first connection. | 0 |
Since we split these into two functions is this still necessary? | 0 |
```suggestion # # Columns without a name are ignored. Add additional columns to skip: ``` | 0 |
I disagree, the spec seems to indicate that `0` is the preferred way to specify the invalid date. Which makes sense, it's Unix start minus 1. I'm not in favour of hacks to support Microsoft's abomination known as IE. It's dead anyways. | 1 |
Guessing these should have a `-` like the URL above. Otherwise they don't appear to resolve. ```suggestion doc_url: https://github.com/Open-MBEE/opl dev_url: https://github.com/Open-MBEE/opl ``` | 0 |
ah ok. it's not uncommon to see questionable reference implementation. we can keep it as is for now. | 0 |
Actually, maybe you should try your laptop on Linux to see if their Linux driver is also affected. | 0 |
Gave this another shot in 88fa67fc956. | 0 |
I don't understand what's wrong with this. This ensures compatibility with potentially missing attributes in `oldAttrs` in a straightforward and readable way. | 0 |
I was mostly thinking just because that way we wouldn't have to update the name every time we want to improve the trace format. The code itself doesn't have to change. (Maybe `updated_format`?) | 0 |
Don't, though, I've got a pull to change the red gloves sprite to be a bit more, ah, red and less pale and shitty. | 1 |
Didn't inline because the excessive nesting was irking me | 0 |
`PKG_CONFIG` is defined in hack/make.sh as well, so if `DOCKER_BUILDTAGS` isn't set, `PKG_CONFIG` wouldn't be set either \U0001f914 | 0 |
Excuse me?! What's nonsense? | 1 |
Damn sneaky editor did it again! ;-) | 1 |
`FlatList` already has some pretty jacked up scrolling behavior when history items are numerous. If we do stick with this, we should be sure to test this out with some very large chats to see if there are any drops in performance. | 0 |
@Duncankn can you confirm that one of these is supposed to be capitalized differently? | 0 |
damn. its so ugly but ok I get it | 1 |
Marking as minor instead, since I don't think resizing the window in the middle of the tutorial is a common operation. The UX in this case is kind of rubbish, though, I agree. | 1 |
@cinnamon-msft and I had an offline discussion. We'll be holding off on ctrl+f4 being bound to close tab until we can get a confirmation dialog for closing the tab, if multiple panes are open. follow-up work item: #5301 | 0 |
GitHub is bad when it comes to a lot of review comments. They get collapsed in the middle. Please PTAL. | 0 |
Should this bit be put in a separate step so it's used by all benchmarks? | 0 |
Oops! Let me fix this. | 0 |
oh, damn, it's copy-pasted... | 1 |
I was wondering about the same thing. I'm using chromium and have a symmetric 1gb, I still get a ridiculous lag when not on the same network. | 1 |
Agreed, it is crappy. | 1 |
nevermind I saw the other PR and figured out | 0 |
that's one of the more bizarre issues I encountered. i've heard way much about this API the past year for it to be unfamiliar by typescript | 1 |
Structures required to execute `usbGenerateDisconnectPulse()` are not yet initialized, hence the call to `IOGetByTag(...)` return some rubbish most likely. @mikeller suggests returning the old boilerplate code for now, without using `IOGetByTag()` if I'm correct. | 1 |
It is in Matt's PR: https://github.com/elastic/kibana/pull/60087/files#diff-c7e77073659d2b600f5e6a59fcec15b0R58-R71 | 0 |
(See above comment) | 0 |
Probably want to describe a bit more what account ID type triggers what kinds of results. It may be a good idea to provide a couple of examples above. | 0 |
We are on no rush here and have the time to wait one day to build this from source. Converting to draft until then. | 0 |
Damian go to bed and come back tomorrow and look at how daft you're being | 1 |
pify :man_facepalming: . | 0 |
I still think we get into trouble when the file is the gradle wrapper jar. Which is binary. | 0 |
Thanks for the feedback, simplified in https://github.com/rails/rails/pull/43524/commits/68164a9992a6cefcdd1b3eaa02e9e5908327542f | 0 |
Hi Jing, First of all, thanks for the review. Since internally we have tested this code, lets keep using map. We will work on changing map to concurrent map post 1.9 changes. | 0 |