text
stringlengths 5
998
| label
int64 0
1
|
|---|---|
TODO: formatting kinda wack here | 0 |
This means you can make pizza flavoured icecream, you tell me that isn't a hilarious notion. | 0 |
hmm it's only used twice, and one of them is in conjunction with another condition. So I feel wrap it as a method is an overkill. | 0 |
Done in a71ee27180 | 0 |
Oh, nice catch! | 0 |
https://github.com/FreeCAD/FreeCAD/pull/1210/commits/c6740dc89fe802861a25947fa8633ae55ee268f9 | 0 |
Here I assume that the user has passed-in a list for `name`. A scalar entry for a `MultiIndex` doesn't make any sense. | 0 |
Wow, seems like this could have ended badly without this. | 0 |
These were never used. | 0 |
This is extremely silly that you can't center a collectionview when you don't have enough items to fill the screen. Instead of saying it's designed that way... please fix it. How does anyone know ahead of time how may items the user will have. Ridiculous. | 1 |
Changed! I ended up not needing this as we used the utility function from `jest-util` | 0 |
This deleting the upload directory could be called via defer and the OnExit framework - see here for an example https://github.com/rclone/rclone/blob/9ea990d5a29fb74fbb28855577aa77e0e3c1ceb9/backend/s3/s3.go#L2262-L2274 When rclone supports resuming uploads this will have to change... | 0 |
damn. how did this ever work? :open_mouth: | 1 |
Since you worked in this class, could you please provide a short javadoc? | 0 |
Are these object pointers that are being moved, or larger items? | 0 |
Hm, probably left over testing from when the supersea was eating my singulos. I'll rip it out. | 0 |
Unnecessary breakdown | 0 |
>100-200% chance with every bite `prob(H.brainloss / 3)` maybe? I want the message to show up when braindamaged, but not *with every bite*. Hell, 20% chance is already pretty high. | 1 |
crap, the cleanup reintroduced the fires. one moment. You can resolve this i guess. | 1 |
They are completely separate unfortunately :( | 0 |
s/will be used/is used | 0 |
https://github.com/PyCQA/pylint/pull/5221/commits/cebeeac01b1245a65740006a0af650ebc23005a3 | 0 |
js names should be `isMainModule` (`mod_symbol` etc. too) | 0 |
I think it would make sense to also support `httpPort` being `null`. | 0 |
```suggestion to run with CPU limits, such as cpu shares or quota under `Cgroups`. ``` | 0 |
You could use "/user/login", but if there is a named route we usually use them. In this case it would be user_login_path. That's how you can get information about routes in a rails app: `rake routes | grep login` | 0 |
```suggestion ### Interaction with BigInt values ``` | 0 |
Hilarious! Sure it helps? ```nix # Substitute paths ``` | 0 |
is this actually happening? last I heard it was axed (but I can never keep up with that debate..) | 0 |
*irradiation | 0 |
How would it know the size before compressing the payload? | 0 |
~I will fix the output.~ What is the default unit the frontend expect, so I can make sure they are correct or converted? | 0 |
Damn, can't believe I missed that! Fixed. :) | 1 |
Assignments to the faggots of Norway: | 1 |
nice suggestion, thanks! | 0 |
seems racy | 0 |
we have getPositiveLong these days, maybe use it to shave a few lines of code? | 0 |
So, as I didn't know, I went for the status quo for this PR (already big and painful, I may say! ;-) ) | 0 |
this name sucks ass just keep it default or think of something better | 1 |
```suggestion The date and time picker components are now available in two packages: ``` | 0 |
https://github.com/theforeman/foreman/pull/8849 | 0 |
This might change the behavoir. ```suggestion echo -n $k_user ``` would keep the old behavoir. | 0 |
```suggestion \u4f60\u53ef\u4ee5\u8bf7\u6c42 API \u670d\u52a1\u5668\u901a\u8fc7\u4f7f\u7528\u9875\uff08Kubernetes \u5c06\u5176\u79f0\u4e3a\u201c\u5757\uff08Chunk\uff09\u201d\uff09\u7684\u65b9\u5f0f\u6765\u5904\u7406 **list**\uff0c \u5b8c\u6210\u5355\u4e2a\u96c6\u5408\u7684\u54cd\u5e94\u3002 ``` | 0 |
Use `@include euiScrollBar;` to get a better looking scrollbar. | 0 |
Yeah sure fuck it you've got points I mostly agree with | 1 |
https://github.com/fiatjaf/neuron.vim/commit/c62b5daa9bc9d734eca9db74e7e0895c85ceb2b8 | 0 |
It looks like it's set up in `PutComponentDefinitionOpcode` before it gets stuck back in the args register. | 0 |
It's just 8 minutes, I think that's way too fast. | 0 |
And I'm not sure yet how/if we want to do `today` as a symbolic object. | 0 |
The situation is terrible, but this is the least-bad one | 0 |
Yeah, that is much smarter. I was trying to do pattern matching in Ruby last night :( What is object-oriented? `<\\sarcasm>` | 0 |
That is true and agree that the logic in getter is not ideal but is there only for returning the correct value. I have updated the code to keep it consistent with other Retry types. | 0 |
That's my experience. If you specify this: ``` addresses { http = "1.2.3.4" } ``` it sets rcp and serf addresses to `""` | 0 |
Have fun getting scolded for needless copypasta, then. | 0 |
Nit: same capitalization question | 0 |
Just "MAD" here. | 0 |
https://github.com/home-assistant/core/pull/82718 | 0 |
@trevnorris Sure, added the other funky characters in there too. | 0 |
I think it was at some point, but it shouldn't be in this pr either way, definitely not in this commit. | 0 |
Passing comment: We must remember to mention to users some of these changes when we release 2.3. | 0 |
The `addressCount` function is now superfluous. I missed this instance of "get-endpoint-and-count-addresses" code. You can instead import `resourceutil github.com/knative/serving/pkg/resources` and use ```golang got, err := resourceutil.FetchReadyAddressCount(endpointsLister, pa.Namespace, pa.Spec.ServiceName) ``` | 0 |
Added you to the meeting, Andrew \U0001f44d\U0001f3fb Looking forward to it! (The invite is editable if someone else should be added.) | 0 |
> How about adding && !isUnauthorizedError to if len(mountCandidate.SourceRepository) > 0... below, instead of the continue? it looks like it will still continue to try next candidate which is not necessary? | 0 |
Yes, ghosts cant do shit by default, no need to add ghost checks | 1 |
yep - renamed "val" to "baValue" (BuildArgValue) and renamed "value" to be "newValue". Hopefully that helps. | 0 |
NO, do a total adjustment calculation ONCE and apply it everywhere what the fuck is this garbage, you know better | 1 |
Please add a test for all combinators. Also, note the `]` ```suggestion \t\t\t'combinator': />|\\+|~|\\|\\|/, ``` | 0 |
We should probably put the :register loop in an @schedule block | 0 |
shouldn't this be `inline`? | 0 |
:- (better to have it) | 0 |
Absolutely ridiculous. You can find it here: http://repo.saltstack.com/py3/debian/10/amd64/archive/2019.2.1/ There's an explanation here: http://repo.saltstack.com/ 2019.2.1 was working fine for me. This just broke my automation. | 1 |
Could it be an an advantage that reusing the same intrinsic could be easier test? | 0 |
One thing that might be worth trying would be to isolate the procedure for contracting dims of a tensor and have all fields except counters be `const` in here. That might enable more compiler optimizations | 0 |
Shouldn't be a problem now. I forgot legion existed wtf | 1 |
> Migrating to styled-components, we will have to remove all the hook styles. Sounds like a migration nightmare for users. | 0 |
"objects are" -> "objects is" (because of subject "schema") | 0 |
You should wrap this in if (HW_DMA11_CHCR & 0x01000000) if the hardware cancels the DMA and it fires an interrupt still, it'll get pissy. | 1 |
Other than that... I'm not sure about this listener at all. | 0 |
Really not sure how I feel about how this works. On the one hand mob code is a bitch and I understand it's a pain to do some things properly in there. On the other hand having a ticking operation to just undo changes elsewhere is disgusting. Talk to me in coderbus sometime about doing this better. This needs to be changed to prevent healing rather than undoing previous changes. | 1 |
This affects js.downcountAmount. Damn | 1 |
I know about the operator, but I didn't know whether it's more desirable, than explicit `is_null()`. The current code uses `is_null()` almost everywhere so I decided to tick to it. I'm glad to know, that shorter syntax is more preferable for ids and will replace all relevant occurrences. | 0 |
It is very cool to have this documented in the wiki by the way. Awesome :-) | 0 |
Give this loop a top-level comment, indicating that it finds those irrelevant ids that still exist, and that it identifies all types for which irrelevant ids exist. | 0 |
I think that would make sense. We don't want to fail the whole build if this process fails, but you're right that it should stand out some more. | 0 |
what, being explicit and performant? that's crazy talk. | 0 |
Use scala.util.Try instead of Either[Throwable, X] | 0 |
Why is isolate_namespace always set to `False`? You are allowing pool layout to be set, but why not pool namespace? | 0 |
Shouldn't the title be different? | 0 |
hmm it's true on playercreateinfo_spell and spell_custom even though it's shit dunno, mixed feelings | 1 |
nit: inherently, and also missing period | 0 |
Yes indeed, thanks! | 0 |
This looks suspiciously close to my PR: https://github.com/nim-lang/Nim/pull/7761 | 0 |
This stuff is covered in enhancements, and seems mostly internal anyway. Unless we want to save it for folks with workloads like "I want to inject a custom trusted CA for $OPERATOR, but not trust that CA for other operators", I'm happy to drop it. | 0 |
Comments look better with C++. | 1 |
`LoadEPDB(const edm::ESHandle<RPFlatParams>& flatparmsDB_,` | 0 |
This pinmux doesn't make much sense to me. You switch the full uart to uart light, to use &gpio0 11 to 14 as gpios. But I can't see them used in the dts. Any explanation why you are doing it? | 0 |
Why the fuck do we still have this file and it's contents. | 1 |
\U0001f914 then that variable name is also kind of shitty | 1 |
Couldn't you, like, at least make a static `init()` method to call instead? This is ugly. | 1 |
RubyMine get whiny about double quotes when singles will do... Interesting | 0 |