text
stringlengths 5
998
| label
int64 0
1
|
|---|---|
\u2705 Done. Thanks. | 0 |
I don't think `singular` is needed here. I suggest simply typing `project` instead of having some code which is pretty much like the implementation. This comment applies also to the other similar lines in this file. ```suggestion params = { comment: { body: "This project is AWESOME!" }, ``` | 0 |
It would be good to document some of the behavior. Like must the file exist when the input starts? What are the file permission requirements? | 0 |
Oh hmmm, interesting I guess those just always ran, but worked fine because `elower` was set to 0... | 0 |
space after break | 0 |
This is an empty line in yaml file. it is not valid | 0 |
It was to minimize changes elsewhere, type assertions. I'll reproduce and paste if any ideas . | 0 |
Seems like it was an oversight. | 0 |
let's add an env var to let people toggle this, will default to rancher/ but will let people set via CATTLE_REPO_PREFIX | 0 |
no need to hold this variable, can be passed directly to printf | 0 |
Damn you yass for screwing up everything. | 1 |
Doh! Yeah. Thanks. Had to look at this for a bit before I realized what I was missing. | 0 |
Ugh that sucks! 3.8 sounds lovely here :) | 1 |
Fixed, thanks. Hilariously I saw this but didn't realize my PR had caused it. | 0 |
damn, i mean the one in line 104 | 1 |
I had to rename keybase.exe just so it would stop automatically restarting itself to check for updates constantly. Ridiculous. | 1 |
The word `mental` is currently erroring in the build process, but I think it can be omitted like so: ```suggestion <!--alex ignore nuts--> **Minimal Classes** where Glimmer components won\u2019t have any element/DOM based properties, hooks, event handler functions (which are provided instead by element modifiers) in order to reduce the mental model and enable users to be productive out of the box. ``` | 0 |
really like this now. Doing the batch thing if possible, otherwise the normal thing...quite cute! | 0 |
I have added something similar by comparing `node.frame()` against `defstmt.frame()` which seems to have the desired effect (see new test). | 0 |
By indenting the comment marker by two extra spaces. | 0 |
Oh, neat. Okey doke. | 0 |
:man: :boom: :gun: | 0 |
I'm not sure which of those 15 lines are you're asking about. | 0 |
Was is singular. Were is plural. Whichever word is coming after Star Queen is refering to the scientists, and since there are multiple scientists, it should be were. | 0 |
Worth doing a second server_connection write before doing drains, and verify that there is no read from the client connection on dispatcher_->run()? | 0 |
Normally I would be bitching about putting the 50 constant in a group of constants 馃ぃ, but looking at this file, it would probably just complicate it further. | 1 |
If you're willing to maintain this, please state so. Also, please rearrange the variables similar to https://github.com/openwrt/packages/blob/master/utils/btrfs-progs/Makefile for example. | 0 |
I fixed it by changing the `EndpointAppContextService.getExceptionList()` | 0 |
the reduced string manipulation was not able to take into account having "http://1.1.1.1" or "1.1.1.1" as input. so i added comments | 0 |
damn, ya that's bad, fixing it now | 1 |
We are using this only in tests, correct? Can we modify reexports to avoid leaking this as public export?  | 0 |
It's intended, in order to make it harder to mass oroduce, to prevent people from making a crap tonne of it and putting it in a smoke machine or whatever to get a valids radar of sorts. | 1 |
NOTE: There's a few icky things here. It's temp until the _find endpoint is updated to take an array of lists. | 0 |
If we need to keep this code it will need to be perf optimized before release, we can't have this reflection running on each request. //cc @nul800sebastiaan + @clausjensen - we can add a task for this to a sprint. | 0 |
This is a good damn change, thank you for spotting it. | 1 |
Looks good! | 0 |
This is the same deal as with `cluster/gce/util.sh` - The provider utils must be re-sourced so that computed values get refreshed when the zone context is changed. | 0 |
For reference, I have made changes in SLEPc that will be included in version 3.14.2, cf. [MR](https://gitlab.com/slepc/slepc/-/merge_requests/108). | 0 |
Probably a better thing to do yeah. Honestly looking at the grinder code makes me want to just refactor/clean up the whole thing, lots of ugly crap in here but that's out of the scope of the PR. | 1 |
Go package names should not have an `_`. That will cause `go vet` to be mad! | 0 |
Wrap at 79 chars. | 0 |
```suggestion Each backend includes the [`libusbi.h`](https://github.com/libusb/libusb/blob/master/libusb/libusbi.h) header with common types and helpers, and needs to expose a `usbi_backend` variable of type [`usbi_os_backend`](https://github.com/libusb/libusb/blob/f2b218b61867f27568ba74fa38e156e5f55ed825/libusb/libusbi.h#L886). For example, this is what the Windows backend looks like: ``` | 0 |
yup makes sense. | 0 |
I am pretty sure the rest of the code will blow up, since it assumes that `systems_uri` is a string and not an array. | 0 |
Cool. At the end ES will make the final validation so I don't think it is a big problem. | 0 |
Oh oops, I must have deleted it when I expanded it out. | 0 |
Very nitty.:) I kinda wanted to separate out the config steps and the integrations, but happy to put together until this gets beefed out and maybe gets two separate mini headings or so | 0 |
Thanks, yep made that mistake everywhere. Fixed it \U0001f44d | 0 |
How is this enforced in the front end? IIUC, this condition enforces that any closure being allocated can only have a single known set of call argument types?? | 0 |
Since we register a callback for state updates, I expect that the callback is called when the state has changed on the device, (car lock). Isn't that true? If that is true, the lock method should only call the device lock method. | 0 |
If you are talking about `ownerId` specifically, I think it is a good-to-have but I am open to remove it. Let me know what you think. | 0 |
I prefer .done and .fail aligned because it makes the code easier to read but I'm indifferent to it at this point | 0 |
ok nvm its github shit view i look in unit cpp through vim and i see all is ok can be resolved | 1 |
Why is this necessary? If we're removing the view, we shouldn't need to mark that view dirty, no? | 0 |
`volatile` is a beast few people fully understand. (And I admit that I do not fully understand it either ;-).) Are you sure that it is right to be used here? If so, please add comments explaining why it is needed. Otherwise, please get rid of it :-) | 0 |
Pending structure description comment? | 0 |
Why do we need this, rather than just having the instance be a singleton? the id could always be `1` or something. | 0 |
By doing this the panel is more responsive. | 0 |
you guys are fast \U0001f604 , done. | 0 |
damn you phpstorm.... | 1 |
You hit the nail on the head here, this recently became a problem with one dependency being newer in canary than nightly. Of course it's possible to create a temporary workaround but that's an extra burden on maintainers. | 0 |
Haha wtf have I written... | 1 |
@esenapaj Thank you for being so helpful at this ridiculous hour (for me). I've burned up 3 pints of beer in this quest \u2014 the only thing keeping my bugs-damn-bugs adrenaline at bay. | 1 |
Seeing it this way, maybe we just want to call it `layerBuilder`? | 0 |
very excited to be able to automate this entire file out of existence \U0001f643 | 0 |
Yup, no race detected! Doesn't mean they aren't racy. Under what conditions do you see a race? | 0 |
The line that you referred to here would only run when the webhook is not enabled (see the first line in the file). When it is enabled, the order is enforced using [hook weights](https://github.com/helm/charts/pull/6239/files#diff-b72874954241f266b2c52983308e8dbcR11). Note the -10, -5 and 0. | 0 |
This is good to know, I didn't realize that! So, you're supposed to do one or the other, but not both. | 0 |
Why do we *need* this? Instead of using yet another config array I'm thinking about changing the config to setters. | 0 |
Not a fast path. Just having a single bool like `state.UseFastPath = !state.SupportContinuation && options.ReferenceHandler == null` | 0 |
this does not handle Grouped Symbol because you are only slicing [0] from the symbol. | 0 |
yup, thanks for catching that | 0 |
Should this instead being something like YamlValidationError or something to the effect of invalid config? | 0 |
Typo - overridden. | 0 |
Will this actually work? Shouldn't there be like an update_icon call or some shit for this? It's not setting color directly | 1 |
The above both DDL will call `refreshTable` with the same table name. Right? If the source codes remove any `refreshTable`, the test case still passes. Right? | 0 |
Yes, Snakemake [requires python >= 3.5](https://bitbucket.org/snakemake/snakemake/src/4e41054b509aa0a0913c708e859b50833aa08769/setup.py?at=v5.2.2&fileviewer=file-view-default#setup.py-12). However, it's makes sense set the python version at `top-level/all-packages.nix`. Done. | 0 |
The `array_filter` has been removed \U0001f642 | 0 |
Typo on "carefull" | 0 |
```suggestion \t// AWSCLIv2MinimumBetaVersion this is the minimum version at which aws-cli v2 uses v1beta1 as APIVersion ``` | 0 |
This seems hacky if it's what I think it is, what's it for in this specific case? Is it for the very short effect of the heart blowing, or is it just for all the other effects? | 0 |
yes if you're a slime | 0 |
Jesus fuck It's kind of disgusting that that works | 1 |
Updated, thanks | 0 |
This was after that failed to work once, font installation seems to be racy or something. I guess I could debug it more, how bad do you think this is? | 0 |
nit: I think you can lifetime-elide the lifetimes here | 0 |
Yes, I fixed it. | 0 |
The location is take from [there](https://github.com/rook/rook/blob/c1e5a46887ffb6b31597b7920a748c2c34302067/pkg/operator/ceph/cluster/osd/osd.go#L551) | 0 |
`^2.4.6` can be used as shorthand for `>=2.4.6,<3`. | 0 |
Pretty sure this is the only place in the game where it's unarguably acceptable to make references to anime | 0 |
I will remove the className. | 0 |
@mcallari `deepAccess` will return the value if it exists, so you shouldn't need to get it twice. Will replacing lines 62-66 with this code give you the functionality that you need? `` const deviceDealId = deepAccess(scores, `device.${validBids[i].params.device}.${validBids[i].adUnitCode}`); dealId = deviceDealId || scores[validBids[i].adUnitCode]; `` | 0 |
```suggestion {/* highlight-end */} ``` | 0 |
Yeah, down with bushcraft medicine. Most of them are straddling the line between being *very* optimistic and straight bullshit ~~which is of course on point for herbal medicine~~ so they could use a feasibility audit. | 1 |
Oh Shoot! Good catch. Thanks! This was from working around the "initialization bug" that turned out to be the corrupted node on caraway. I will reenable these asap. | 0 |
oh snap, the `//` should've been on the other side! | 0 |
Just did a bit of a wacky rebase. Could i get a set of \U0001f440 here? | 1 |
```suggestion \tfields["has_quorum"] = quorumErr == nil ``` | 0 |
beyond ridiculous. | 1 |
If that's your choice. You also have 'compelling', 'impressive', and 'potent'. | 0 |