url
stringlengths 79
94
| original_message
stringlengths 5
2.73k
| message
stringlengths 0
2.61k
| original_label
stringclasses 4
values | is_good
bool 2
classes | is_bad
bool 2
classes | binary_label
float64 0
1
⌀ |
|---|---|---|---|---|---|---|
https://github.com/junit-team/junit4/commit/18b23a7ed22080e7412e24060c66cef7fc3b1b93 | Fix #995 - correct link to 4.12 release notes | Why and What | false | false | null |
|
https://github.com/junit-team/junit4/commit/cf2a11a5939e8623cb4591080f423134025bbf62 | Stripped accidental formatting from an earlier commit | Stripped accidental formatting from an earlier commit | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/6d551f321d7bdcdafc2acbe0b5a3988bdc91b10f | RunNotifier.pleaseStop() is now thread-safe | RunNotifier.pleaseStop() is now thread-safe | No What | false | false | null |
https://github.com/junit-team/junit4/commit/ce0195c3d81d32bc2fd4d7a0c15aa78aaaa47605 | Fixes gh-311: Fix 4.9.1 release notes, make sure markdown errors halt build | Why and What | false | false | null |
|
https://github.com/junit-team/junit4/commit/bd6dc3aff19a3d8e8e555d16a05a42557a755e0a | Reused HasWrongExpectedException instead of own defined class
(they were the same) and relocated the changes to a better location
in the file which is more inline with the rest of the file. And,
of course, removed the superfluous brackets. | Reused HasWrongExpectedException instead of own defined class
(they were the same) and relocated the changes to a better location
in the file which is more inline with the rest of the file. And,
of course, removed the superfluous brackets. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/ab9caa3650a262ef4399cfd7f0d7fdc366d6e327 | Fix javac build
Replace both() with allOf() | Fix javac build
Replace both() with allOf() | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/cbf46b88c2937aece7018fa50ba4dbb133e03d06 | Pull request #182 && #483: Adding Parameter annotation for field parameters | Pull request #182 && #483: Adding Parameter annotation for field parameters | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/8aea9bc66441e5dd727b7d0a6478b4adb93b63f9 | Migrate release notes from wiki to repo | Migrate release notes from wiki to repo | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/5ded3d3231891402e07a208941d263aaf3379134 | Merging kcooney-issue227 to master | Merging kcooney-issue227 to master | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/80e7b0deaf4ca24659878328987b7d096a4a7070 | Disable xref reports | Disable xref reports | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/3920f3fe11dffc904e1ab41a9ff4fc9d36b1c25b | Making Super and Sub member classes as suggested.
https://github.com/KentBeck/junit/pull/293/files#r403246 | Making Super and Sub member classes as suggested.
https://github.com/KentBeck/junit/pull/293/files#r403246 | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/fe10c8a264e6585d9d8a92e5d5fa9a6e10aa298f | Fix typo in test name | Fix typo in test name | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/a538d25ae50887dc9395f2f59ad5040752c0ec4f | Apply code review. | Apply code review. | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/84c4caaeb54249eed291274914ef6391622e07e3 | Set master version to 4.10.1 in build.xml | Set master version to 4.10.1 in build.xml | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/b4f0afa639b42fa551fdcb26d9c1855ae4d778cf | @Rule fields/methods must not be static
Fixes KentBeck/junit#339 | @Rule fields/methods must not be static
Fixes KentBeck/junit#339 | No What | false | false | null |
https://github.com/junit-team/junit4/commit/cc617b399f369a0254edc714beb3551905fe799f | Updated version to 4.9b3 | Updated version to 4.9b3 | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/f15ee64ef898f26775b90e4baf19251a76e5b1e0 | Fix method names in TemporaryFolderUsageTest. | Fix method names in TemporaryFolderUsageTest. | No What | false | false | null |
https://github.com/junit-team/junit4/commit/7924760d2d64f5f7651e9e57d1ca01e1bcce74e0 | Following feedback from dsaff | Following feedback from dsaff | No What | false | false | null |
https://github.com/junit-team/junit4/commit/5eee07b3e21f196b8cb937fb88eb8cf4be694f76 | Optimize ParentRunner.filter for nested suites
Prior to this change, applying a filter to a nested suite would create redundant nested filters | Optimize ParentRunner.filter for nested suites
Prior to this change, applying a filter to a nested suite would create redundant nested filters | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/a4c19ea7000b620dbb9f54c6cb625ddad1f8f33e | Update version in pom.xml; delete obsolete SuiteBuilder.java;
remove duplication in build.xml | Update version in pom.xml; delete obsolete SuiteBuilder.java;
remove duplication in build.xml | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/bfd54d62251a67c6709be3ec4f02a31a02ac5a45 | deleted duplicate EventCollector | deleted duplicate EventCollector | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/6ee76dc22e56457cb5904eb6c5c0bf97939880cb | Update build_tests.sh to test 'ant profile' | Update build_tests.sh to test 'ant profile' | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/fd2c4fbbf74f01eecef1680fa1365052d0302d19 | Added some names to list of contributors | Added some names to list of contributors | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/38c12ee56d863068fb743b45d9c1ee2aa74b71a8 | 4.10 final in version, non-snapshot staging | 4.10 final in version, non-snapshot staging | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/5e9467c59b235ce84e7c7753c43609dea069e932 | Both hasCause() and hasMessage() describe mismatches | Both hasCause() and hasMessage() describe mismatches | No What | false | false | null |
https://github.com/junit-team/junit4/commit/cab111add67ec6ba33f93f8611a73b565fb2786c | Added logo and contributor by name | Added logo and contributor by name | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/a5acc2defe0134d179cf15424202b5403eef74d4 | Improve error message when TemporaryFolder.newFolder() fails. | Improve error message when TemporaryFolder.newFolder() fails. | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/0e64f5c9d8626c95c7da36186312a76524ff7b15 | Update CONTRIBUTING.md | Update CONTRIBUTING.md | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/510d807929bdd2dea85726b5a12542758aa61420 | Update release notes with details on pull 986 | Update release notes with details on pull 986 | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/a37fd9ac8b2afc54384fd32f470b54aa69dc620a | Rename withStacktrace() to isException()/isThrowable()
Following suggestion by @sf105 | Rename withStacktrace() to isException()/isThrowable()
Following suggestion by @sf105 | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/b310cd56f1039389aa360fbf51c6349e7a8e1f02 | Update JUnit version, improve ClassRule javadoc, update release notes | Update JUnit version, improve ClassRule javadoc, update release notes | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/9a82d0027247d7be667966766b01d4a24e4b834f | fix for #49 Master now builds on windows. | fix for #49 Master now builds on windows. | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/df00d5eced3a7737b88de0f6f9e3673f0cf88f88 | remove 'f' prefix from field names, add LEGACY_CODING_STYLE, change CODING_STYLE | remove 'f' prefix from field names, add LEGACY_CODING_STYLE, change CODING_STYLE | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/34701f7aedd60ace43171a9c56c14c8ef1f7bd15 | Add JUnitSystem.exit() back | Add JUnitSystem.exit() back | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/bcf4785a8ae0ad21ffefd80dcfbb360621d98806 | fixed issue #89 (wrong JavaDoc of Parameterized) | fixed issue #89 (wrong JavaDoc of Parameterized) | No What | false | false | null |
https://github.com/junit-team/junit4/commit/e857122bff2a9774c4f44df4a7d531b902e406df | Fix issue 30. Make TestWatcher abstract. | Fix issue 30. Make TestWatcher abstract. | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/b3789b3f879d34bbe968d5aa51d15c8856b9d102 | Create MultipleFailureException in org.junit.runners.model and deprecate the one in org.junit.internal.runners.model.
Update MultipleFailureException to have a useful message.
This allows developers who write custom runners to properly handle multiple exceptions without depending on internal classes. | Create MultipleFailureException in org.junit.runners.model and deprecate the one in org.junit.internal.runners.model.
Update MultipleFailureException to have a useful message.
This allows developers who write custom runners to properly handle multiple exceptions without depending on internal classes. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/8d26b450670647c847aa0ba1dd47a9c54865c63d | further documentation cleanup, especially around TestRule | further documentation cleanup, especially around TestRule | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/b19ff583ce5cb5527dab83a1f336c7526463dac4 | Fixed failing tests when running on Windows.
Note that File.separator is not sufficient to build an absolute path on Windows.
String.format with '%n' produces a platform dependent line separator.
Closes #1409 | Fixed failing tests when running on Windows.
Note that File.separator is not sufficient to build an absolute path on Windows.
String.format with '%n' produces a platform dependent line separator. | No What | true | false | 1 |
https://github.com/junit-team/junit4/commit/c85c6147ada5ad1afdd3be10769670d309730132 | Fix regression in TemporaryFolder.newFolder(String) for paths with slashes. (#1402)
In JUnit 4.11, newFolder(String) was changed to no longer support paths
with a file separator. This has been fixed. The overload of newFolder()
that supports passing in multiple strings still does not allow strings
containing file separators. | Fix regression in TemporaryFolder.newFolder(String) for paths with slashes.
In JUnit 4.11, newFolder(String) was changed to no longer support paths
with a file separator. This has been fixed. The overload of newFolder()
that supports passing in multiple strings still does not allow strings
containing file separators. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/89ffd7eda43f939f7dc210cfe21a196067ab08d6 | Adding additional javadoc context for deprecated FrameworkMethod#producesType. Adding acknowledgements entry for pholser. Starting 4.9.1 release notes. | Adding additional javadoc context for deprecated FrameworkMethod#producesType. Adding acknowledgements entry for pholser. Starting 4.9.1 release notes. | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/d3de6079892fa89aa46386c0369a29b4ef9e9e3c | Automatic uploading of staged maven artifacts. | Automatic uploading of staged maven artifacts. | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/32f3c6292808f793a50821dac3fec3bad3b661c9 | Replaced <br> with </p><p> in faq.html
@dsaff @kcooney, I have replaced the <br> tag with the <p> tags. It should be fine now.
Thank you @kcooney for spotting the issue :) | Replaced <br> with </p><p> in faq.html
@dsaff @kcooney, I have replaced the <br> tag with the <p> tags. It should be fine now.
Thank you @kcooney for spotting the issue :) | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/ce034f7167462706062dfc010fde052a89c4eb6d | Adding bogus markdown, but should be removed later | Adding bogus markdown, but should be removed later | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/cb0c4e9f7c9be8be7c11e4934f6bd71a312102ec | For #855, remove FrameworkMethod.getParameterSignatures()
Having this method in place made a class from the 'core' of JUnit
(org.junit.runners.model) depend on something from 'experimental' --
a dependency going in the wrong direction. | For #855, remove FrameworkMethod.getParameterSignatures()
Having this method in place made a class from the 'core' of JUnit
(org.junit.runners.model) depend on something from 'experimental' --
a dependency going in the wrong direction. | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/db8c72be9df8e7d605600cc5f370dffa35112362 | applied code review | applied code review | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/eb8da7b85251985b194911d4d3dc65acb525a5fd | Switching back from kcooney-run-leaf to kcooney-run-leaf | Switching back from kcooney-run-leaf to kcooney-run-leaf | Neither Why nor What | false | false | null |
https://github.com/junit-team/junit4/commit/62a2a56c293fd154f152da6dad498d1fc222b352 | Fix ParentRunner#withClassRules javadoc. (Thanks to lacostej for initial pull)
Closes GH-191. | Fix ParentRunner#withClassRules javadoc. (Thanks to lacostej for initial pull) | No What | false | false | null |
https://github.com/junit-team/junit4/commit/4e482e74f19f2619f940da57e2d7a0f1f70afe17 | added Javadoc for RuleFieldValidator | added Javadoc for RuleFieldValidator | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/d4a33cf2f54b5d9cb9ee9f349220bd629e6f4672 | Added release theme header | Added release theme header | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/0b3bcf3aa152ae82c0d23b56106781e3376615be | Remove author tag left in from copy&paste | Remove author tag left in from copy&paste | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/638e82435a01af83e77c23e9f8d7b658a89eb4bf | Use %n in string.format() (#1346)
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. | Use %n in string.format()
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/1360f9b696f2fb1bc32b16b070ffb3363a88864f | Update Maven GPG plugin from 1.4 to 1.5.
Just to keep up-to-date. Release notes: http://jira.codehaus.org/browse/MGPG/fixforversion/17635 | Update Maven GPG plugin from 1.4 to 1.5.
Just to keep up-to-date. Release notes: http://jira.codehaus.org/browse/MGPG/fixforversion/17635 | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/3189af007b26d74ca459f823d57ef77b9c1697b8 | Remove redundant field fCause | Remove redundant field fCause | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/f09cff79b941a525271f3f2838a9742b4c5c8d36 | alpha-ready implementation of SuiteBuilder | alpha-ready implementation of SuiteBuilder | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/4042487e40bb441ad4388373e5c91d727b74e0db | Improve error message if the thrown exception has the same class but the classes are loaded from different class loaders. | Improve error message if the thrown exception has the same class but the classes are loaded from different class loaders. | No Why | true | false | 1 |
https://github.com/junit-team/junit4/commit/56743a446c8fe01319c6588c1709bcf1a090ccde | Merging from AlistairIsrael-classrules on github to ppreserve history because of non-fast forward merge (whatever that means) | Merging from AlistairIsrael-classrules on github to ppreserve history because of non-fast forward merge (whatever that means) | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/a664c207facb1cddcd5ab130fc14edbae3f33d30 | Fix distribution management | Fix distribution management | No What | false | true | 0 |
https://github.com/junit-team/junit4/commit/46036e7146f9dd0ca44baaec490692b967edd0ce | javadoc'ed, and with better names | javadoc'ed, and with better names | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/75cce069e369c553e5d7690b601c06f08b74edca | doxia-module-markdown 1.5 supports page titles | doxia-module-markdown 1.5 supports page titles | No What | false | true | 0 |
https://github.com/junit-team/junit4/commit/3e08f69912d69189e895c279b1bece0c7c0840f4 | Create a class TestWithParameters.
This class keeps the data together that are needed for creating a runner for a single data set of a parameterized test. This makes it also clear, that the computation of the name is not the responsibility of the runner but of the Parameterized class. | Create a class TestWithParameters.
This class keeps the data together that are needed for creating a runner for a single data set of a parameterized test. This makes it also clear, that the computation of the name is not the responsibility of the runner but of the Parameterized class. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/0c114780df6a4f096493730dd004bccd44b13e15 | Throw exception with helpful message if annotated field is not public (fixes issue #260). | Throw exception with helpful message if annotated field is not public (fixes issue #260). | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/ce810b763e5021629248702993f226e3bf969db8 | Multiple categories on tests, category inheritance, production classes in production package. | Multiple categories on tests, category inheritance, production classes in production package. | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/41092ce4e01cc57d8aa1911e2f1169e0f355b1ae | Move TestClassTest to package org.junit.runners.model.
It is common to add tests to the same package as the class under test. | Move TestClassTest to package org.junit.runners.model.
It is common to add tests to the same package as the class under test. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/fb7925bf75ffe9f802f54e2d717af11b58c75725 | surefire and javadoc maven plugin updates | surefire and javadoc maven plugin updates | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/01716157f2683f5610d721929a687e7dc3aee558 | Use Field#getType() | Use Field#getType() | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/73c15ac3097078d2de1478dfecf4317a616346a3 | Fixes #254: replaced @Rule by @ClassRule | Why and What | false | false | null |
|
https://github.com/junit-team/junit4/commit/592b71c7e7cc3c10de2d6c331854a751b25879a6 | Didn't want that | Didn't want that | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/56954698ca3e707ba6992509b8b3d64caa021442 | Bump version | Bump version | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/a268686d96bfbb328e02b363c3f0f72da54f9fc6 | checkpoint | checkpoint | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/758ec7fdc2ea8db0c3cb57b83c2a1a069ee214b6 | Removed unused import | Removed unused import | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/6a89eb6dc62093d8f6d41d54152da5592808c38e | Highlight java syntax | Highlight java syntax | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/25fa1d53ff124bc82d9d449c37ff1dea186c3e42 | up version | up version | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/01ecc0d5bc9f8b49ed36881cc258573a43bef69f | I want these gone | I want these gone | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/445ea85dd748e4e83cf7be5940b41df95b3ffa8d | minor changes in test | minor changes in test | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/1d86784cd452e8d9e30d812255cadb75ef8dae15 | Fix compilation errors | Fix compilation errors | No What | false | true | 0 |
https://github.com/junit-team/junit4/commit/309edadfd8a7169e99571d36ec31cacfaabb2fe1 | Take care of the TODO to make the inner class static. | Take care of the TODO to make the inner class static. | No What | false | false | null |
https://github.com/junit-team/junit4/commit/0733bbffdadf05a6ebe0c38942904071a4060af4 | #769 Fix many warnings (Eclipse 4.2/Juno based)
- Enh: add new 'staticondemandthreshold' setting to eclipse project jdt.ui preference settings file (although this is in fact not related to kcooney's import ordering change comment) | #769 Fix many warnings (Eclipse 4.2/Juno based)
- Enh: add new 'staticondemandthreshold' setting to eclipse project jdt.ui preference settings file (although this is in fact not related to kcooney's import ordering change comment) | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/a21ce2438fd69d6656dcf5274deb031976df12c1 | Most of the plans and mark2 nonsense gone | Most of the plans and mark2 nonsense gone | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/74fe490cc074f8be3cee760aac3f8e313698db82 | Version 4.7 to 4.7.1-SNAPSHOT in build.xml | Version 4.7 to 4.7.1-SNAPSHOT in build.xml | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/c618504adee4bc91b3bd7e0ff06be6e1fa9d88cc | Cleaning up compile errors from reverting hamcrest change | Cleaning up compile errors from reverting hamcrest change | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/b560fce6b4323e1fd4d37c703d7123f1508643cb | added ReleaseNotes for 4.5 | added ReleaseNotes for 4.5 | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/496ee866a46f783d145b649a688df57cbf79490e | categories 2 | categories 2 | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/f5e7e1ff180bb17e4f9df702a038e06a974f78f6 | added the since 4.12 where appropriate | added the since 4.12 where appropriate | No Why | false | true | 0 |
https://github.com/junit-team/junit4/commit/1bbab715de4c64943948ecc3739c8d5569378672 | CategoriesMark2 reuse code properly from TestClass | CategoriesMark2 reuse code properly from TestClass | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/363755060f75d3d5cce21bd05d49110e02bc1ba2 | Fix ResultMatchers#hasFailureContaining (#1292)
ResultMatchers.hasFailureContaining() should not match when the given PrintableResult has no failures. | Fix ResultMatchers#hasFailureContaining
ResultMatchers.hasFailureContaining() should not match when the given PrintableResult has no failures. | No What | true | false | 1 |
https://github.com/junit-team/junit4/commit/bb13b318cd79a68470e93c79635090c7bb565475 | Revert changes of 128553f. Fixes #687.
Still fixes #121, but the original fix was superfluous. Added documentation
about handling assumes and asserts in conjunction with the
ExpectedException rule. | Revert changes of 128553f. Fixes #687.
Still fixes #121, but the original fix was superfluous. Added documentation
about handling assumes and asserts in conjunction with the
ExpectedException rule. | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/d2da6a55bca4582c9a469f568df472a00e90ddf4 | merged | merged | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/99a84a542f2ac532a8425fa0a77884902b1c01b0 | org.junit.Rule, org.junit.Rules | org.junit.Rule, org.junit.Rules | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/2b6fa701e84625c511b03079296774cc0904ef1a | Bug: ParentRunner lost test Class from a separate class loader (#1252)
* Bug: ParentRunner lost test Class from a separate class loader
When junit.jar located in one ClassLoader but runing tests in another ParentRunner can lost information about run class.
For example if use @ClassRule and request test class(org.junit.runner.Description#getTestClass) we can get null,
because ParentRunner instead of set Class as is to Description tranform it to class name string,
as result org.junit.runner.Description#getTestClass execute Class.forName and can't find test class.
Spring-test fail with exception if we try use SpringClassRule
```
java.lang.NullPointerException
at org.springframework.test.context.junit4.rules.SpringClassRule.validateSpringMethodRuleConfiguration(SpringClassRule.java:186)
at org.springframework.test.context.junit4.rules.SpringClassRule.apply(SpringClassRule.java:134)
at org.junit.rules.RunRules.applyAll(RunRules.java:26)
at org.junit.rules.RunRules.<init>(RunRules.java:15)
at org.junit.runners.ParentRunner.withClassRules(ParentRunner.java:245)
at org.junit.runners.ParentRunner.classBlock(ParentRunner.java:194)
at org.junit.runners.ParentRunner.run(ParentRunner.java:362)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
```
As solution, now ParentRunner create Descriptor with explicit specify Class, name and uses annotations.
* Restore backward compatibility with sub class of ParentRunner that override getName method
* Add ParentRunnerClassLoaderTest to AllClassesTests suite | Bug: ParentRunner lost test Class from a separate class loader
* Bug: ParentRunner lost test Class from a separate class loader
When junit.jar located in one ClassLoader but runing tests in another ParentRunner can lost information about run class.
For example if use @ClassRule and request test class(org.junit.runner.Description#getTestClass) we can get null,
because ParentRunner instead of set Class as is to Description tranform it to class name string,
as result org.junit.runner.Description#getTestClass execute Class.forName and can't find test class.
Spring-test fail with exception if we try use SpringClassRule
```
java.lang.NullPointerException
at org.springframework.test.context.junit4.rules.SpringClassRule.validateSpringMethodRuleConfiguration(SpringClassRule.java:186)
at org.springframework.test.context.junit4.rules.SpringClassRule.apply(SpringClassRule.java:134)
at org.junit.rules.RunRules.applyAll(RunRules.java:26)
at org.junit.rules.RunRules.<init>(RunRules.java:15)
at org.junit.runners.ParentRunner.withClassRules(ParentRunner.java:245)
at org.junit.runners.ParentRunner.classBlock(ParentRunner.java:194)
at org.junit.runners.ParentRunner.run(ParentRunner.java:362)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
```
As solution, now ParentRunner create Descriptor with explicit specify Class, name and uses annotations.
* Restore backward compatibility with sub class of ParentRunner that override getName method
* Add ParentRunnerClassLoaderTest to AllClassesTests suite | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/fd1ef3ca8069bd149ca63c9660587918aa28c7cd | minor ParentRunner refactoring | minor ParentRunner refactoring | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/734ab5187c068599352e5fdc7374c1334d484fef | StatementInterceptor takes Object target
Signed-off-by: Kent Beck <[email protected]> | StatementInterceptor takes Object target
Signed-off-by: Kent Beck <[email protected]> | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/d9ffa8ab1807c8419f8fc2b5f91fa810113a9a85 | Added better pom.xml | Added better pom.xml | Why and What | false | true | 0 |
https://github.com/junit-team/junit4/commit/fa35d6d84a0b2c59254cb479633d0e20bc6e12e9 | Delete .cvsignore files, because we're using Git now. | Delete .cvsignore files, because we're using Git now. | Why and What | true | false | 1 |
https://github.com/junit-team/junit4/commit/818974071eba9d5355918a5905403c703aeea9af | Updated gitignore | Updated gitignore | Neither Why nor What | false | true | 0 |
https://github.com/junit-team/junit4/commit/4f7ed2bdf1856b0582e9b982aa0ba594498c6b45 | simplified isIgnored check in Framework, using it in
BlockJUnit4ClassRuner | simplified isIgnored check in Framework, using it in
BlockJUnit4ClassRuner | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/409a8e06c9f2ec5aa0d9db8a3d413f394c290f6d | Fixing Interceptor->Rule name changes | Fixing Interceptor->Rule name changes | Why and What | false | false | null |
https://github.com/junit-team/junit4/commit/d8da2f699a89857292e5e5b92945b2fe3c0a039a | Getting started on Interceptors javadoc
Signed-off-by: Kent Beck <[email protected]> | Getting started on Interceptors javadoc
Signed-off-by: Kent Beck <[email protected]> | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/b33b4b090c224c14415d0ffb68a078a097aeaf71 | RunNotifier.fireTestRunStarted(Plan) to replace fireTestRunStarted(Description) | RunNotifier.fireTestRunStarted(Plan) to replace fireTestRunStarted(Description) | No Why | false | false | null |
https://github.com/junit-team/junit4/commit/8e313a1e58a56694c0441b2fa60974fa8e1bfe31 | StatementInterceptor takes Object target | StatementInterceptor takes Object target | No Why | false | false | null |