url
stringlengths
79
94
original_message
stringlengths
5
2.73k
message
stringlengths
0
2.61k
original_label
stringclasses
4 values
is_good
bool
2 classes
is_bad
bool
2 classes
binary_label
float64
0
1
https://github.com/junit-team/junit4/commit/1254795902e56eb545e1fe696827924bc5e82b66
Mark ThreadGroups created by FailOnTimeout as daemon groups (#1687) Mark ThreadGroup created by FailOnTimeout as a daemon group. Previously, FailOnTimeout destroyed the ThreadGroup, which could cause race conditions if the ThreadGroup was referenced by other threads. Fixes #1652
Mark ThreadGroups created by FailOnTimeout as daemon groups Mark ThreadGroup created by FailOnTimeout as a daemon group. Previously, FailOnTimeout destroyed the ThreadGroup, which could cause race conditions if the ThreadGroup was referenced by other threads.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/435d41f0d45cfdbc1a38e1ad4eb1d5300da533f9
Use Google's Maven Central mirror We are using Maven 3.1.1 which by default uses HTTP instead of HTTPS for resolving artifacts from Maven Central. Maven Central recently discontinued HTTP support. Therefore the build on Travis started failing. By using an HTTPS mirror of Maven Central the build on Travis will work again. I chose Google's mirror because Travis uses this mirror by default, too. I did not upgrade to a new version of Maven because there is no newer version with Java 5 support and it should be possible to build JUnit 4 with Java 5 so that we can easily ensure that it works with Java 5.
Use Google's Maven Central mirror We are using Maven 3.1.1 which by default uses HTTP instead of HTTPS for resolving artifacts from Maven Central. Maven Central recently discontinued HTTP support. Therefore the build on Travis started failing. By using an HTTPS mirror of Maven Central the build on Travis will work again. I chose Google's mirror because Travis uses this mirror by default, too. I did not upgrade to a new version of Maven because there is no newer version with Java 5 support and it should be possible to build JUnit 4 with Java 5 so that we can easily ensure that it works with Java 5.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/6c5de817e7e0afdd4d09354693535520712595fc
Remove reference to obsolete mailing list
Remove reference to obsolete mailing list
No Why
false
false
null
https://github.com/junit-team/junit4/commit/467c3f8efe1a87e3029df282e4df60ad98bc4142
Deprecate Assert#assertThat The method 'assertThat' is used for writing assertions with Hamcrest. Hamcrest is an independent assertion library and contains an own 'assertThat' method in the class 'org.hamcrest.MatcherAssert'. It is available both in the old Hamcrest 1.3 release and in the current Hamcrest 2.1. Therefore the JUnit team recommends to use Hamcrest's own 'assertThat' directly.
Deprecate Assert#assertThat The method 'assertThat' is used for writing assertions with Hamcrest. Hamcrest is an independent assertion library and contains an own 'assertThat' method in the class 'org.hamcrest.MatcherAssert'. It is available both in the old Hamcrest 1.3 release and in the current Hamcrest 2.1. Therefore the JUnit team recommends to use Hamcrest's own 'assertThat' directly.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/8a367c1b918f02135d333f3cea8b576c20287361
Revert 'ExternalResource: declare after() to throw Throwable (#1421)' Revert commit cebbf5e15725b4dc247ac0557f6fa63f475b15af. It breaks code that extends ExternalResource, overrides after() and calls super.after() in after().
Revert 'ExternalResource: declare after() to throw Throwable (#1421)' Revert commit cebbf5e15725b4dc247ac0557f6fa63f475b15af. It breaks code that extends ExternalResource, overrides after() and calls super.after() in after().
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/37610e67f77db2f238e7fde2c36f1f0d180790b1
spelling: unwieldy
spelling: unwieldy
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/b9a1291cd0e72b0ba1babfd330a0148ab3d42b27
spelling: methods
spelling: methods
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/a5e71079e26cfa282a36b1eab806f596bc20a949
spelling: builder
spelling: builder
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/2101dad6cf8fcd94d351f65cf28812ec527d7bf5
spelling: assert
spelling: assert
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/039dbd17447bd7bb5b4d0f7861d87b5c22703832
style: remove space
style: remove space
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/6d0fad48ce3a05b32d903d2016c24d276b6e1eb8
Remove usages of FrameworkMember as a raw type. (#1596)
Remove usages of FrameworkMember as a raw type.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/61c3a030440ed9041aafd9e66d1c6c3ebc71440a
ParentRunner.classRules() returns modifiable List (#1578)
ParentRunner.classRules() returns modifiable List
No What
false
false
null
https://github.com/junit-team/junit4/commit/9b34c4b6e887c6ea8ea78748f9406c83c9118e71
Remove openjdk6 from Travis pipeline for now Related issue: #1577
Remove openjdk6 from Travis pipeline for now Related issue: #1577
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/e22bd95ab7e452245d4844f5e9b05564fe189f68
Change links to point directly to junit4/5 repos
Change links to point directly to junit4/5 repos
No Why
false
false
null
https://github.com/junit-team/junit4/commit/2510a7e82efabfd442b4cddfabe6150b4edf45f2
Update JUnit 5 teaser
Update JUnit 5 teaser
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/4d472c8b21a12eba59bf329ec759a7d51ff10c8b
Update campaign spending
Update campaign spending
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/3bd79f0cb669617dd883db354c3f05ead0fa3d6f
Use new logo and link to new website
Use new logo and link to new website
No Why
false
true
0
https://github.com/junit-team/junit4/commit/6fe93c1a2717ce06b252d8a45d7ca020d3dc3fb3
Deleted dead faq link. Fix #1248.
Deleted dead faq link.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/78029cd90a5a7be76fc54aa725be94f87f35927e
Publish from Travis Remove 11 Omit signing WIP
Publish from Travis Remove 11 Omit signing WIP
No Why
false
true
0
https://github.com/junit-team/junit4/commit/eb75886b2be7edf709441962bf3272e4319823c5
Add tests for serialization of Result.assumptionFailureCount.
Add tests for serialization of Result.assumptionFailureCount.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/4f2ed5d7a7bbe77f6c917c6ccc7de303896d1beb
Added name to contributors list
Added name to contributors list
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/5785d9df8fe25f68567272850cd65b4dc07da617
Deprecate rule ExpectedException (#1519) The method Assert.assertThrows provides a nicer way for verifying exceptions. In addition the use of ExpectedException is error-prone when used with other rules like TestWatcher because the order of rules is important in that case.
Deprecate rule ExpectedException The method Assert.assertThrows provides a nicer way for verifying exceptions. In addition the use of ExpectedException is error-prone when used with other rules like TestWatcher because the order of rules is important in that case.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/8e05e94956c1820e7a72d55795c5198835afca0e
Add siili
Add siili
No Why
false
true
0
https://github.com/junit-team/junit4/commit/236e75bd968935cf8728c3f7aaaccaefd2f9c737
Adapt links to reflect repo rename
Adapt links to reflect repo rename
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/d3d7a8b1389e53055d4de9de3aa319053b4a5524
Identify reflection package jdk.internal.reflect JDK 9 uses classes from the package jdk.internal.reflect instead of sun.reflect.
Identify reflection package jdk.internal.reflect JDK 9 uses classes from the package jdk.internal.reflect instead of sun.reflect.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/bdb1799a6b58c4ab40c418111333f4e8e1816e7e
Add Assert#expectThrows and Assert#assertThrows Closes #1154.
Add Assert#expectThrows and Assert#assertThrows
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/3d7de190844d92de87ca197cfd1fce74ae432f0f
Add test for handling InitializationError The code was changed by commit 0804ef4cd09b0e94783a9882c60914e22fca5108 but unfortunately the test was not part of the commit. The test is based on Philip Graf's test in pull request #1065. Co-authored-by: Philip Graf <[email protected]>
Add test for handling InitializationError The code was changed by commit 0804ef4cd09b0e94783a9882c60914e22fca5108 but unfortunately the test was not part of the commit. The test is based on Philip Graf's test in pull request #1065. Co-authored-by: Philip Graf <[email protected]>
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/9bad8ce0a56d056ec3b7166351b7405c8be7e834
License link on junit.org Added prominent link to the project's license. This patch fixes #1162. Signed-off-by: Allon Mureinik <[email protected]>
License link on junit.org Added prominent link to the project's license. This patch fixes #1162. Signed-off-by: Allon Mureinik <[email protected]>
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/eedd1f68fbd014beca60c979e8173c271ea5cf2d
Upate TestName to make the 'name' field volatile. This ensures that the name is published across threads correctly--for instance, if a parallelized runner is used. Closes #1157
Upate TestName to make the 'name' field volatile. This ensures that the name is published across threads correctly--for instance, if a parallelized runner is used.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/7a12b7070aaa88712ed449c0a746741fd7e0237a
Formatting
Formatting
Neither Why nor What
false
true
0
https://github.com/junit-team/junit4/commit/59baeed4cb3d24211960ad01fd3ee9e534b0e1da
Fixed lost names
Fixed lost names
No What
false
true
0
https://github.com/junit-team/junit4/commit/0ebb59e0dec269db0816c63fda6113b006b3de52
Simplification of theory parameter names, since format automatically deals with toString() and nulls.
Simplification of theory parameter names, since format automatically deals with toString() and nulls.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/178f854e4c7e31ece6d71f5aa4433f0432349f4f
Make stylistic changes Put { on first line with a space before it
Make stylistic changes Put { on first line with a space before it
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/561fb840af9d00abab5449f704a77fd6a7f2509d
removed spaces before period in comment
removed spaces before period in comment
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/d2b75f93d21d2584efab1129aacd1f3020c37fca
Build with Maven 3.1.1 (using Maven Wrapper) This makes the build independent from the Maven version that is installed on the build machine. E.g. Travis has Maven 3.5.6 installed that does not support Java 6 anymore. Maven version 3.1.1 is used because all newer version don't support Java 1.5.
Build with Maven 3.1.1 (using Maven Wrapper) This makes the build independent from the Maven version that is installed on the build machine. E.g. Travis has Maven 3.5.6 installed that does not support Java 6 anymore. Maven version 3.1.1 is used because all newer version don't support Java 1.5.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/ad9972ba5d135d1c5673f0773cb7027f7823feb5
Prefer interfaces over concrete classes Makes code easier to scan by removing unnecessary noise.
Prefer interfaces over concrete classes Makes code easier to scan by removing unnecessary noise.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/3a5772dab5ce8f3b2879a19009357d425e84400e
StopWatch does not need to be abstract. Fixes #1110.
StopWatch does not need to be abstract.
No What
false
false
null
https://github.com/junit-team/junit4/commit/6b97cfa77503a00416f401ad47f375f087e8c3cb
Fixed typo [WiKi -> Wiki]
Fixed typo [WiKi -> Wiki]
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/24dfdd762e753c83babca3768d4b508cf5c6a86c
Fix dead link to the ant task in FAQ (#1478) Documentation to the ant junit task has been moved to another location.
Fix dead link to the ant task in FAQ Documentation to the ant junit task has been moved to another location.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/cf9aa29323020439a3f8895ec7dc13e8e3219324
Added a few names
Added a few names
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/e15b287ccec2a1f4866a8bd1cd2a313a6163163d
Only use a property where multiple entries need syncing * The hamcrest version is only used in one place, i.e. the dependency. * Using properties to define dependency versions can cause issues for others. * Using properties to define a shared version across multiple dependencies causes less issues when you have multiple dependencies that need to be kept in sync. * We only have one dependency here and it doesn't need syncing to any other dependency * Therefore the right thing is to just specify the version in the dependency * End users can still override the dependency in their poms.
Only use a property where multiple entries need syncing * The hamcrest version is only used in one place, i.e. the dependency. * Using properties to define dependency versions can cause issues for others. * Using properties to define a shared version across multiple dependencies causes less issues when you have multiple dependencies that need to be kept in sync. * We only have one dependency here and it doesn't need syncing to any other dependency * Therefore the right thing is to just specify the version in the dependency * End users can still override the dependency in their poms.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/f851c3ee43e1966903ff66ecda3fa7f66c2d2ecb
test: no inline comment, comment space
test: no inline comment, comment space
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/6384edfffe7f8a2850d2bcde9a16a8e780734ebe
fail when AssertionError expected but not thrown When a user expected the production code to throw an AssertionError by using ExpectedException (together with the #handleAssertionErrors option) but the code under test didn't do so the test was not failing. This was because the ExpectedException rule caught its own AssertionError issued to signal that the expected exception was not thrown.
fail when AssertionError expected but not thrown When a user expected the production code to throw an AssertionError by using ExpectedException (together with the #handleAssertionErrors option) but the code under test didn't do so the test was not failing. This was because the ExpectedException rule caught its own AssertionError issued to signal that the expected exception was not thrown.
No What
false
false
null
https://github.com/junit-team/junit4/commit/0807a8cd01b6d63d54f9a3580540fa35b7fb292e
Kent & Erich patch swallowing in Merlin
Kent & Erich patch swallowing in Merlin
Neither Why nor What
false
false
null
https://github.com/junit-team/junit4/commit/78f5fa85b492353ad062f54d1f0ceec745537761
no #deleteOnExit, no inline comment, added space in comment
no #deleteOnExit, no inline comment, added space in comment
No Why
false
false
null
https://github.com/junit-team/junit4/commit/a90b496a6595856066504baf4f737fb853a6e45d
Ensure exceptions from methodBlock() don't result in unrooted tests. The introduction of the runLeaf() method in BlockJUnit4ClassRunner in JUnit 4.9 introduced a regression with regard to exception handling. Specifically, the invocation of methodBlock() is no longer executed within a try-catch block as was the case in previous versions of JUnit. Custom modifications to methodBlock() or the methods it invokes may in fact throw exceptions. In such cases, exceptions thrown from methodBlock() cause the current test execution to abort immediately. As a result, the failing test method is unrooted in test reports, and subsequent test methods are never invoked. Furthermore, RunListeners registered with JUnit are not notified. This commit addresses this issue by wrapping the invocation of methodBlock() within a try-catch block. If an exception is not thrown, the resulting Statement is passed to runLeaf(). If an exception is thrown, it is wrapped in a Fail statement which is passed to runLeaf(). Closes #1066 Closes #1082
Ensure exceptions from methodBlock() don't result in unrooted tests. The introduction of the runLeaf() method in BlockJUnit4ClassRunner in JUnit 4.9 introduced a regression with regard to exception handling. Specifically, the invocation of methodBlock() is no longer executed within a try-catch block as was the case in previous versions of JUnit. Custom modifications to methodBlock() or the methods it invokes may in fact throw exceptions. In such cases, exceptions thrown from methodBlock() cause the current test execution to abort immediately. As a result, the failing test method is unrooted in test reports, and subsequent test methods are never invoked. Furthermore, RunListeners registered with JUnit are not notified. This commit addresses this issue by wrapping the invocation of methodBlock() within a try-catch block. If an exception is not thrown, the resulting Statement is passed to runLeaf(). If an exception is thrown, it is wrapped in a Fail statement which is passed to runLeaf().
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/298cc4459cf76298f4b790a903fbdb6e6d20887d
small optimization if-else
small optimization if-else
No Why
false
false
null
https://github.com/junit-team/junit4/commit/dda4d08fc64933a8e4af33b745bd8219682b7bcb
Fixes imports
Fixes imports
No What
false
false
null
https://github.com/junit-team/junit4/commit/59f3fa6ea11433ffd914e6c2032cdad0036f435e
removed settings.xml, updated building-junit.txt and pom.xml
removed settings.xml, updated building-junit.txt and pom.xml
Neither Why nor What
false
false
null
https://github.com/junit-team/junit4/commit/01831e8f96e42c72e5abe5838e13554e9d48f3ee
Added arcbees logo
Added arcbees logo
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/0fdec440b59be32e16a084a2ff6fd7a596da2c8f
Prepare for Maven release
Prepare for Maven release
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/5ea3196f1cdbc32bc3a91b96bedc1964d3bb76d1
Used assertArrayEquals to avoid converting an array to a list. Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Used assertArrayEquals to avoid converting an array to a list. Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/96e051b21a8f277c03158c3db32e1b4e4b0389c2
getNanos() is a single thread confinement. Volatiles not needed!
getNanos() is a single thread confinement. Volatiles not needed!
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/a3e01b1ebea12f5fdfb6349e9e72623ac1f3b232
Cleaning up indentation The inline method refactoring conducted by eclipse introduced some extra tabs. Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Cleaning up indentation The inline method refactoring conducted by eclipse introduced some extra tabs. Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/b28fe09d1a54955bed2e4db5352c14fae195a418
fixes for #544 and #545
fixes for #544 and #545
No What
false
false
null
https://github.com/junit-team/junit4/commit/b1db2bb47b95aced929b7f801c9185045481da05
Remove tabs
Remove tabs
No Why
false
true
0
https://github.com/junit-team/junit4/commit/c4e3854ae71d7dd8b624a977712bee3e29d5bcdd
Added #finished(long nanos, Description description)
Added #finished(long nanos, Description description)
No Why
false
false
null
https://github.com/junit-team/junit4/commit/d24e5d821964508246b9670a08affab50e3ca87c
same as ANT => excluded internal packages
same as ANT => excluded internal packages
No Why
false
false
null
https://github.com/junit-team/junit4/commit/0a2601045f101930d0ca7f31c53b416fafbbe7a7
fixed Javadoc 'its' micros -> toMicros, millis -> toMillis, seconds -> toSeconds fixed Javadoc 3 lines to tab startTime -> startNanos endTime -> endNanos enum SUCCEEDED - > PASSED equalTo -> is(equalTo)
fixed Javadoc 'its' micros -> toMicros, millis -> toMillis, seconds -> toSeconds fixed Javadoc 3 lines to tab startTime -> startNanos endTime -> endNanos enum SUCCEEDED - > PASSED equalTo -> is(equalTo)
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/a2ea00d745f2770ff3b443f77ef72572d37209df
Add more contributors
Add more contributors
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/fa235e3520365aa9364ac16bf561e7a42524f0dc
Refactoring of the test case for JVM Method sorter Removed the string based equality, and improved naming (in particular calling the expected result 'actual' was confusing). Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Refactoring of the test case for JVM Method sorter Removed the string based equality, and improved naming (in particular calling the expected result 'actual' was confusing). Incomplete - task : Issue 551: Resolve sensitive equality in MethodSorter test.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/2246c5a6de14ae94f3d29a82b165653e67ca93a1
Converted tab to spaces
Converted tab to spaces
No Why
false
false
null
https://github.com/junit-team/junit4/commit/c7313b19a24165f4e6b39c3eb2c8165a02f1e108
List more contributor names
List more contributor names
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/9ee381470d56efa800420e5e22721e402aca01c2
Remove fast-tests maven target. Many of our tests store data in static fields, so the tests cannot be run in parallel. Fixes #1297
Remove fast-tests maven target. Many of our tests store data in static fields, so the tests cannot be run in parallel.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/ebb9d7f536a5b1be8364c6cb7367cac8c3849caa
Implemented the changes proposed davidhart82
Implemented the changes proposed davidhart82
No What
false
false
null
https://github.com/junit-team/junit4/commit/bbacbd93334540a5054bb50488f662c3f81a9c00
Remove @Deprecated from MethodRule and related methods.
Remove @Deprecated from MethodRule and related methods.
No Why
false
false
null
https://github.com/junit-team/junit4/commit/1079730d32227eaed5c69a908770572285ad6301
Add 42talents GmbH
Add 42talents GmbH
No Why
false
false
null
https://github.com/junit-team/junit4/commit/dfbf2ae868049c041c926f2bf2d7633056af5820
Add type wildcard
Add type wildcard
No Why
false
false
null
https://github.com/junit-team/junit4/commit/bcf2c17851197328bb7bc008f916a6648de193aa
Converted tabs to spaces Converted tabs to spaces for newly added code to be in line with guidelines.
Converted tabs to spaces Converted tabs to spaces for newly added code to be in line with guidelines.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/aff46c491d590ff2fcc43d0eaa0049593f6169b4
closed method assertEquals with }
closed method assertEquals with }
No Why
false
false
null
https://github.com/junit-team/junit4/commit/ab1eb66505631ec2ad8010cc071e0f625b2ad95d
Issue #426 Added suggestions by dsaff Removed the Markdown syntax, changed import order and removed confusing Maximum Blank Lines section.
Issue #426 Added suggestions by dsaff Removed the Markdown syntax, changed import order and removed confusing Maximum Blank Lines section.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/c236a9e019a814b3542dcfe3a3a61b036c14d252
Improved Test: ParallelMethodTest fails few times
Improved Test: ParallelMethodTest fails few times
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/430e3669badc46ae9ba97e513ddbd1a88a5b7f14
Suppress SecurityManager deprecation warnings
Suppress SecurityManager deprecation warnings
No Why
true
false
1
https://github.com/junit-team/junit4/commit/ec9bccf9521a6ccdd074f2618626507528a43bc9
Removed the unnecessary Note: block in javadoc
Removed the unnecessary Note: block in javadoc
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/41e5c7ed5f82b5a588828584c3ac765b40a76cea
improved implementation using Executors
improved implementation using Executors
No Why
false
false
null
https://github.com/junit-team/junit4/commit/32330b13f2ded8603665264f8400ddf1f6dd969a
make MethodSorter.NAME_ASCENDING a deterministic comparator, with Method.toString used as a tiebreaker
make MethodSorter.NAME_ASCENDING a deterministic comparator, with Method.toString used as a tiebreaker
No Why
true
false
1
https://github.com/junit-team/junit4/commit/dfaf332b4df0d98293ac135e5abf9de6a2623b14
Added different implementation for Null Sorter test Added an extra test case providing an alternative implementation for the getMethodsNullSorter test case. The new implementation passes when coverage analysis using jacoco is enabled, whereas the old one incorrectly fails. The new approach only checks the order of methods that are of interest (i.e., not looking at irrelevant extra methods that the coverage analyzer might generate). Furthermore the new approach avoid the 'sensitive equality' test smell by replacing toString-based equality by actual equality.
Added different implementation for Null Sorter test Added an extra test case providing an alternative implementation for the getMethodsNullSorter test case. The new implementation passes when coverage analysis using jacoco is enabled, whereas the old one incorrectly fails. The new approach only checks the order of methods that are of interest (i.e., not looking at irrelevant extra methods that the coverage analyzer might generate). Furthermore the new approach avoid the 'sensitive equality' test smell by replacing toString-based equality by actual equality.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/b978f680cfa3eb9b526cc8bd25c68a3eb6db3c45
Fix indentation
Fix indentation
No What
false
true
0
https://github.com/junit-team/junit4/commit/4411c102d489c2272d7e38606e912a54be4defa8
Restore folder `javadoc/latest` for Javadoc. This folder has been used for many years. There are links to Javadoc at that folder (e.g. http://stackoverflow.com/questions/156503/how-do-you-assert-that-a-certain-exception-is-thrown-in-junit-4-tests/2935935#2935935 ). Restoring the folder `javadoc/latest` will hopefully restore the Javadoc pages in Google Search, too.
Restore folder `javadoc/latest` for Javadoc. This folder has been used for many years. There are links to Javadoc at that folder (e.g. http://stackoverflow.com/questions/156503/how-do-you-assert-that-a-certain-exception-is-thrown-in-junit-4-tests/2935935#2935935 ). Restoring the folder `javadoc/latest` will hopefully restore the Javadoc pages in Google Search, too.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/23e6e92b774e1e3910acc6a903293972bc562500
Reorder assignments to match order of parameters.
Reorder assignments to match order of parameters.
No Why
true
false
1
https://github.com/junit-team/junit4/commit/d96a05f8d33ed781c701c58dd285bf6464112719
Create a Builder for FailOnTimeout. Delete all constructors created since 4.11 was released. Fix style issues.
Create a Builder for FailOnTimeout. Delete all constructors created since 4.11 was released. Fix style issues.
No Why
false
false
null
https://github.com/junit-team/junit4/commit/2b4ea7d30d22341fb488df73901277a5194fd424
implementing kcooney's suggestion
implementing kcooney's suggestion
No Why
false
false
null
https://github.com/junit-team/junit4/commit/8134371705a43fa2b2a8913678d4336d867f6647
Description.getTestClass() did not work reliably. Was assuming that the ClassLoader used for JUnit could also load test classes. While this may be true in a simple test runner based on a flat classpath, it is not true in all test runners. When we are given a Class object, keep it—do not try to reconstruct it from its name alone.
Description.getTestClass() did not work reliably. Was assuming that the ClassLoader used for JUnit could also load test classes. While this may be true in a simple test runner based on a flat classpath, it is not true in all test runners. When we are given a Class object, keep it—do not try to reconstruct it from its name alone.
No What
true
false
1
https://github.com/junit-team/junit4/commit/75225f76d430e45adcf36cef8d6fdbeb7629de57
Added 3 names and a link
Added 3 names and a link
No Why
false
true
0
https://github.com/junit-team/junit4/commit/01768666d362391a57a7e5989d23b6b1d1789eb0
Add info on --filter option
Add info on --filter option
No Why
false
false
null
https://github.com/junit-team/junit4/commit/388ae4ceb0c3f34b2ab339afafb22e6a6a032194
Added a name to list
Added a name to list
Why and What
false
true
0
https://github.com/junit-team/junit4/commit/56b5463c6adf89a03f489f3525a9a343bc43d960
each' instead of 'f' for the variable name
each' instead of 'f' for the variable name
No Why
false
false
null
https://github.com/junit-team/junit4/commit/4baabd8b27a276aacb2efa545dc5e3ee42d7b72b
Remove decoration on all external links
Remove decoration on all external links
No Why
false
false
null
https://github.com/junit-team/junit4/commit/934ebddf0bb286ebbff22028b9f5a9c016589b3f
Relocate Maven artifact 'junit-dep' to 'junit'
Relocate Maven artifact 'junit-dep' to 'junit'
No Why
false
false
null
https://github.com/junit-team/junit4/commit/0b62513fa20ea3975a580e5b89dad265f54d6112
Simplifying isEqualsRegardingNull.
Simplifying isEqualsRegardingNull.
No Why
false
true
0
https://github.com/junit-team/junit4/commit/48aabe1b16bd288f74ac4ff92e3a38792533be39
Fix for issue #55 Added Type check for MultiPointsMethod
Fix for issue #55 Added Type check for MultiPointsMethod
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/ce7ce514aa79a7a3be067552359722626937fe8f
Added AdNovum large logo
Added AdNovum large logo
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/16a2b51b9d9425cd7dacad85e2df97985996ca8d
Disable parts of doclint for the site's javadoc. This is a follow-up to e0367cd. That commit is missing to apply the doclint rules to site generation. Hence the site goal fails because of doclint issues. Now doclint is disabled for all groups but accessibility and reference for the site generation, too.
Disable parts of doclint for the site's javadoc. This is a follow-up to e0367cd. That commit is missing to apply the doclint rules to site generation. Hence the site goal fails because of doclint issues. Now doclint is disabled for all groups but accessibility and reference for the site generation, too.
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/30a349860acfa847dd7a60ef77df92f6831794c7
Disable summary report
Disable summary report
No Why
false
false
null
https://github.com/junit-team/junit4/commit/cbf5dd3f8efc106bcb438203942d781831121071
Organized imports according to project's conventions
Organized imports according to project's conventions
No Why
true
false
1
https://github.com/junit-team/junit4/commit/6b943e564adcc9a7106e54c24eb5d022bed1462f
changed the expectedCause() method to accept a Matcher instead of an explicit Throwable and made some documentation changes
changed the expectedCause() method to accept a Matcher instead of an explicit Throwable and made some documentation changes
No Why
true
false
1
https://github.com/junit-team/junit4/commit/1ef449139923a22333f262dc8c75fa057903040c
Increase running time of statement. Fixes #963. The time between starting the statement and calling the future is arbitrary. Now the execution time of the statement is very very long. This ensures that the statement is not already finished when the future is called.
Increase running time of statement. Fixes #963. The time between starting the statement and calling the future is arbitrary. Now the execution time of the statement is very very long. This ensures that the statement is not already finished when the future is called.
Why and What
true
false
1
https://github.com/junit-team/junit4/commit/2568203bdebd5a4a4ad9aa74b1d8369d22f668a3
Replaced IllegalArgumentException for IOException It's more consistent to throw an IOException instead of an IllegalArgumentException
Replaced IllegalArgumentException for IOException It's more consistent to throw an IOException instead of an IllegalArgumentException
Why and What
false
false
null
https://github.com/junit-team/junit4/commit/e9e9da84e9b50e233eac79c3879e2e0862778eeb
Added one link
Added one link
No Why
false
true
0
https://github.com/junit-team/junit4/commit/f6149a9236d9a2778bf2fd6db927fd9f498a79c8
Make serialization of Result compatible with 4.11
Make serialization of Result compatible with 4.11
No Why
false
false
null