Spaces:

open-llm-leaderboard

/

open_llm_leaderboard

like 11.7k

Running on CPU Upgrade

Following the creation of this PR, an ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been started. Any changes pushed to this PR will be synced with the test Space.
Since this PR has been created by a trusted author, the ephemeral Space has been configured with the correct hardware, storage, and secrets.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Two main changes:

• Improved date handling precision and corrected the rate limit logic.
• Introduced tests for python scripts, the first test is for this very case.

Changes:

• Higher rate limit check moved to the beginning of the function for early adjustment of the quota.
• Time limit calculation changed from string format to datetime object for more accurate comparisons.
• Added a parse_datetime function to convert ISO 8601 date strings to datetime objects, improving date handling accuracy.
• Changed date comparison logic to use datetime objects instead of string comparisons.
• Modified the rate limit check from > to >= to correctly enforce the quota limit.

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

I would put the parse_datetime in utils because it can be used elsewhere. Nice idea to use parse_datetime. Did you try it with users who already submitted a lot of models today?

@clefourrier just a sec, I'm fixing tests :D
Nope, I didn't try with specific names, I emulated "test_user" in various scenarios in my tests

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

Following new commits that happened in this PR, the ephemeral Space open-llm-leaderboard/open_llm_leaderboard-ci-pr-803 has been updated.
(This is an automated message.)

@clefourrier
Now we have:

• A separate parse_iso8601_datetime() function in src/display/utils.py for user_submission_permission() function in src/submission/check_validity.py
• Tests! You can run the current with the full path (I'll update pyproject.toml later to run all tests at a time). Here is my command to run it with poetry:
  poetry run python -m unittest tests/submission/test_user_submission_permission.py

PR is now merged/closed. The ephemeral Space has been deleted.
(This is an automated message.)

PR is now merged/closed. The ephemeral Space has been deleted.
(This is an automated message.)