Dataset Preview
Full Screen Viewer
Full Screen
The full dataset viewer is not available (click to read why). Only showing a preview of the rows.
The dataset generation failed
Error code: DatasetGenerationError
Exception: ArrowInvalid
Message: JSON parse error: Invalid value. in row 0
Traceback: Traceback (most recent call last):
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py", line 160, in _generate_tables
df = pandas_read_json(f)
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py", line 38, in pandas_read_json
return pd.read_json(path_or_buf, **kwargs)
File "/src/services/worker/.venv/lib/python3.9/site-packages/pandas/io/json/_json.py", line 815, in read_json
return json_reader.read()
File "/src/services/worker/.venv/lib/python3.9/site-packages/pandas/io/json/_json.py", line 1025, in read
obj = self._get_object_parser(self.data)
File "/src/services/worker/.venv/lib/python3.9/site-packages/pandas/io/json/_json.py", line 1051, in _get_object_parser
obj = FrameParser(json, **kwargs).parse()
File "/src/services/worker/.venv/lib/python3.9/site-packages/pandas/io/json/_json.py", line 1187, in parse
self._parse()
File "/src/services/worker/.venv/lib/python3.9/site-packages/pandas/io/json/_json.py", line 1403, in _parse
ujson_loads(json, precise_float=self.precise_float), dtype=None
ValueError: Expected object or value
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py", line 1854, in _prepare_split_single
for _, table in generator:
File "/src/services/worker/src/worker/job_runners/config/parquet_and_info.py", line 689, in wrapped
for item in generator(*args, **kwargs):
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py", line 163, in _generate_tables
raise e
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/packaged_modules/json/json.py", line 137, in _generate_tables
pa_table = paj.read_json(
File "pyarrow/_json.pyx", line 308, in pyarrow._json.read_json
File "pyarrow/error.pxi", line 154, in pyarrow.lib.pyarrow_internal_check_status
File "pyarrow/error.pxi", line 91, in pyarrow.lib.check_status
pyarrow.lib.ArrowInvalid: JSON parse error: Invalid value. in row 0
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/src/services/worker/src/worker/job_runners/config/parquet_and_info.py", line 1415, in compute_config_parquet_and_info_response
parquet_operations, partial, estimated_dataset_info = stream_convert_to_parquet(
File "/src/services/worker/src/worker/job_runners/config/parquet_and_info.py", line 991, in stream_convert_to_parquet
builder._prepare_split(
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py", line 1741, in _prepare_split
for job_id, done, content in self._prepare_split_single(
File "/src/services/worker/.venv/lib/python3.9/site-packages/datasets/builder.py", line 1897, in _prepare_split_single
raise DatasetGenerationError("An error occurred while generating the dataset") from e
datasets.exceptions.DatasetGenerationError: An error occurred while generating the datasetNeed help to make the dataset viewer work? Make sure to review how to configure the dataset viewer, and open a discussion for direct support.
commit
string | subject
string | message
string | repos
string | returncode
int64 | stderr
string | license
string | lang
string | diff
string |
|---|---|---|---|---|---|---|---|---|
2f5d44de3eb51779466def170ded64a4af8bc452 | IWSG: implement CHANGED_BY (#5680) | IWSG: implement CHANGED_BY (#5680)
| sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_iwsg.clas.abap
+++ src/objects/zcl_abapgit_object_iwsg.clas.abap
@@ -21,7 +21,30 @@
-CLASS zcl_abapgit_object_iwsg IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_OBJECT_IWSG IMPLEMENTATION.
+
+
+ METHOD get_field_rules.
+
+ ro_result = zcl_abapgit_field_rules=>create( ).
+ ro_result->add(
+ iv_table = '/IWFND/I_MED_SRH'
+ iv_field = 'CREATED_BY'
+ iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user
+ )->add(
+ iv_table = '/IWFND/I_MED_SRH'
+ iv_field = 'CREATED_TIMESTMP'
+ iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp
+ )->add(
+ iv_table = '/IWFND/I_MED_SRH'
+ iv_field = 'CHANGED_BY'
+ iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user
+ )->add(
+ iv_table = '/IWFND/I_MED_SRH'
+ iv_field = 'CHANGED_TIMESTMP'
+ iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ).
+
+ ENDMETHOD.
METHOD get_generic.
@@ -36,7 +59,13 @@
METHOD zif_abapgit_object~changed_by.
- rv_user = zcl_abapgit_objects_super=>c_user_unknown.
+
+ SELECT SINGLE changed_by FROM ('/IWFND/I_MED_SRH') INTO rv_user
+ WHERE srv_identifier = ms_item-obj_name.
+ IF sy-subrc <> 0.
+ rv_user = zcl_abapgit_objects_super=>c_user_unknown.
+ ENDIF.
+
ENDMETHOD.
@@ -102,27 +131,4 @@
get_generic( )->serialize( io_xml ).
ENDMETHOD.
-
- METHOD get_field_rules.
-
- ro_result = zcl_abapgit_field_rules=>create( ).
- ro_result->add(
- iv_table = '/IWFND/I_MED_SRH'
- iv_field = 'CREATED_BY'
- iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user
- )->add(
- iv_table = '/IWFND/I_MED_SRH'
- iv_field = 'CREATED_TIMESTMP'
- iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp
- )->add(
- iv_table = '/IWFND/I_MED_SRH'
- iv_field = 'CHANGED_BY'
- iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-user
- )->add(
- iv_table = '/IWFND/I_MED_SRH'
- iv_field = 'CHANGED_TIMESTMP'
- iv_fill_rule = zif_abapgit_field_rules=>c_fill_rule-timestamp ).
-
- ENDMETHOD.
-
ENDCLASS.
|
|
1af60a9f42d4b05791982072bc51d542a14784e4 | SSFO: Avoid side-effect in is_active (#5564) | SSFO: Avoid side-effect in is_active (#5564)
| sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_ssfo.clas.abap
+++ src/objects/zcl_abapgit_object_ssfo.clas.abap
@@ -318,6 +318,7 @@
METHOD zif_abapgit_object~is_active.
DATA: lv_ssfo_formname TYPE tdsfname.
+ DATA lv_inactive TYPE abap_bool.
lv_ssfo_formname = ms_item-obj_name.
@@ -325,9 +326,9 @@
EXPORTING
i_formname = lv_ssfo_formname
IMPORTING
- o_inactive = ms_item-inactive.
-
- rv_active = boolc( ms_item-inactive = abap_false ).
+ o_inactive = lv_inactive.
+
+ rv_active = boolc( lv_inactive = abap_false ).
ENDMETHOD.
|
|
d51643f02684c293ddae68a4924c4e32c82896b4 | SUSH: Clear metadata (#4967) | SUSH: Clear metadata (#4967)
Co-authored-by: Lars Hvam <[email protected]> | larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_sush.clas.abap
+++ src/objects/zcl_abapgit_object_sush.clas.abap
@@ -20,6 +20,14 @@
PROTECTED SECTION.
PRIVATE SECTION.
+ METHODS clear_metadata
+ CHANGING
+ cs_data_head TYPE any
+ ct_usobx TYPE table
+ ct_usobt TYPE table
+ ct_usobx_ext TYPE table
+ ct_usobt_ext TYPE table.
+
ENDCLASS.
@@ -232,31 +240,32 @@
METHOD zif_abapgit_object~serialize.
DATA:
- ls_key TYPE usobkey,
- lo_su22 TYPE REF TO object,
- lt_usobx TYPE usobx_t,
- lt_usobt TYPE usobt_t,
- lr_data_head TYPE REF TO data,
- lr_data_usobx_ext TYPE REF TO data,
- lr_data_usobt_ext TYPE REF TO data,
- lr_err TYPE REF TO cx_static_check,
- lx_error TYPE REF TO cx_root.
-
- FIELD-SYMBOLS: <ls_data_head> TYPE any,
- <lt_data_usobx_ext> TYPE ANY TABLE,
- <lt_data_usobt_ext> TYPE ANY TABLE.
+ ls_key TYPE usobkey,
+ lo_su22 TYPE REF TO object,
+ lt_usobx TYPE usobx_t,
+ lt_usobt TYPE usobt_t,
+ lr_head TYPE REF TO data,
+ lr_usobx_ext TYPE REF TO data,
+ lr_usobt_ext TYPE REF TO data,
+ lr_err TYPE REF TO cx_static_check,
+ lx_error TYPE REF TO cx_root.
+
+
+ FIELD-SYMBOLS: <ls_head> TYPE any,
+ <lt_usobx_ext> TYPE ANY TABLE,
+ <lt_usobt_ext> TYPE ANY TABLE.
ls_key = ms_item-obj_name.
TRY.
- CREATE DATA lr_data_head TYPE ('IF_SU22_ADT_OBJECT=>TS_SU2X_HEAD').
- ASSIGN lr_data_head->* TO <ls_data_head>.
-
- CREATE DATA lr_data_usobx_ext TYPE ('IF_SU22_ADT_OBJECT=>TT_SU2X_X').
- ASSIGN lr_data_usobx_ext->* TO <lt_data_usobx_ext>.
-
- CREATE DATA lr_data_usobt_ext TYPE ('IF_SU22_ADT_OBJECT=>TT_SU2X_T').
- ASSIGN lr_data_usobt_ext->* TO <lt_data_usobt_ext>.
+ CREATE DATA lr_head TYPE ('IF_SU22_ADT_OBJECT=>TS_SU2X_HEAD').
+ ASSIGN lr_head->* TO <ls_head>.
+
+ CREATE DATA lr_usobx_ext TYPE ('IF_SU22_ADT_OBJECT=>TT_SU2X_X').
+ ASSIGN lr_usobx_ext->* TO <lt_usobx_ext>.
+
+ CREATE DATA lr_usobt_ext TYPE ('IF_SU22_ADT_OBJECT=>TT_SU2X_T').
+ ASSIGN lr_usobt_ext->* TO <lt_usobt_ext>.
CREATE OBJECT lo_su22
TYPE ('CL_SU22_ADT_OBJECT').
@@ -266,18 +275,26 @@
EXPORTING
iv_key = ls_key
IMPORTING
- es_head = <ls_data_head>
+ es_head = <ls_head>
et_usobx = lt_usobx
et_usobt = lt_usobt
- et_usobx_ext = <lt_data_usobx_ext>
- et_usobt_ext = <lt_data_usobt_ext>.
+ et_usobx_ext = <lt_usobx_ext>
+ et_usobt_ext = <lt_usobt_ext>.
CATCH cx_static_check INTO lr_err.
zcx_abapgit_exception=>raise_with_text( lr_err ).
ENDTRY.
+ clear_metadata(
+ CHANGING
+ cs_data_head = <ls_head>
+ ct_usobx = lt_usobx
+ ct_usobt = lt_usobt
+ ct_usobx_ext = <lt_usobx_ext>
+ ct_usobt_ext = <lt_usobt_ext> ).
+
"HEAD
io_xml->add( iv_name = 'HEAD'
- ig_data = <ls_data_head> ).
+ ig_data = <ls_head> ).
"USOBX
io_xml->add( iv_name = 'USOBX'
@@ -289,15 +306,55 @@
"USOBX_EXT
io_xml->add( iv_name = 'USOBX_EXT'
- ig_data = <lt_data_usobx_ext> ).
+ ig_data = <lt_usobx_ext> ).
"USOBT_EXT
io_xml->add( iv_name = 'USOBT_EXT'
- ig_data = <lt_data_usobt_ext> ).
+ ig_data = <lt_usobt_ext> ).
CATCH cx_root INTO lx_error.
zcx_abapgit_exception=>raise_with_text( lx_error ).
ENDTRY.
ENDMETHOD.
+
+
+ METHOD clear_metadata.
+
+ DATA:
+ BEGIN OF ls_empty_metadata,
+ modifier TYPE c LENGTH 12, " usob_sm-modifier
+ moddate TYPE d, " usob_sm-moddate,
+ modtime TYPE t, " usob_sm-modtime,
+ srcsystem TYPE tadir-srcsystem,
+ author TYPE tadir-author,
+ devclass TYPE tadir-devclass,
+ END OF ls_empty_metadata.
+
+ FIELD-SYMBOLS:
+ <ls_usobx> TYPE any,
+ <ls_usbot> TYPE any,
+ <ls_usobt_ext> TYPE any,
+ <ls_usobx_ext> TYPE any.
+
+ MOVE-CORRESPONDING ls_empty_metadata TO cs_data_head.
+
+ LOOP AT ct_usobx ASSIGNING <ls_usobx>.
+ MOVE-CORRESPONDING ls_empty_metadata TO <ls_usobx>.
+ ENDLOOP.
+
+ LOOP AT ct_usobt ASSIGNING <ls_usbot>.
+ MOVE-CORRESPONDING ls_empty_metadata TO <ls_usbot>.
+ ENDLOOP.
+
+ LOOP AT ct_usobt_ext ASSIGNING <ls_usobt_ext>.
+ MOVE-CORRESPONDING ls_empty_metadata TO <ls_usobt_ext>.
+ ENDLOOP.
+
+ LOOP AT ct_usobx_ext ASSIGNING <ls_usobx_ext>.
+ MOVE-CORRESPONDING ls_empty_metadata TO <ls_usobx_ext>.
+ ENDLOOP.
+
+ ENDMETHOD.
+
ENDCLASS.
|
|
75f26ece9591f628f65c4a314257ec0478638cc0 | fix build errors | fix build errors | nununo/abapGit,larshp/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,apex8/abapGit,nununo/abapGit,larshp/abapGit,sbcgua/abapGit,apex8/abapGit | 0 | mit | ABAP | --- zabapgit.prog.abap
+++ zabapgit.prog.abap
@@ -14727,7 +14727,7 @@
IF <ls_diff>-result EQ lcl_diff=>c_diff-delete
OR <ls_diff>-result EQ lcl_diff=>c_diff-insert
OR <ls_diff>-result EQ lcl_diff=>c_diff-update.
- ADD 1 TO lv_anchor_count.
+ lv_anchor_count = lv_anchor_count + 1.
lv_anchor_name = | name="diff_{ lv_anchor_count }"|.
ELSE.
CLEAR lv_anchor_name.
@@ -14737,7 +14737,9 @@
|<tr>| && gc_newline &&
'<td' && lv_clocal && '><pre>' && lv_local && '</pre></td>' &&
gc_newline &&
- '<td> ' && |<a{ lv_anchor_name } href="#diff_{ lv_anchor_count + 1 }">{ <ls_diff>-result }</a>| && ' </td>' &&
+ '<td> ' &&
+ |<a{ lv_anchor_name } href="#diff_{ lv_anchor_count + 1 }">{ <ls_diff>-result }</a>| &&
+ ' </td>' &&
gc_newline &&
'<td' && lv_cremote && '><pre>' && lv_remote && '</pre></td>' &&
gc_newline &&
|
|
695ca90a62ab96f7200229956b2dbea0bb1e108f | #234, remove comments | #234, remove comments
| apex8/abapGit,EduardoCopat/abapGit,nununo/abapGit,sbcgua/abapGit,sbcgua/abapGit,nununo/abapGit,larshp/abapGit,apex8/abapGit,EduardoCopat/abapGit,larshp/abapGit | 0 | mit | ABAP | --- zabapgit.prog.abap
+++ zabapgit.prog.abap
@@ -19546,22 +19546,11 @@
lv_string TYPE string.
FIELD-SYMBOLS: <ls_field> LIKE LINE OF lt_fields.
-* <lg_any> TYPE any.
-
-
+
+ CLEAR: ev_key, es_file.
lv_string = iv_string. " type conversion
lt_fields = cl_http_utility=>if_http_utility~string_to_fields( lv_string ).
-* LOOP AT lt_fields ASSIGNING <ls_field>.
-* ASSIGN COMPONENT <ls_field>-name OF STRUCTURE es_file TO <lg_any>.
-* IF sy-subrc <> 0.
-* CONTINUE. " more structures might be encoded in same string
-* ENDIF.
-*
-* <lg_any> = <ls_field>-value.
-* ENDLOOP.
-
- CLEAR: ev_key, es_file.
READ TABLE lt_fields ASSIGNING <ls_field> WITH KEY name = 'KEY'.
IF sy-subrc = 0.
ev_key = <ls_field>-value.
@@ -19600,24 +19589,7 @@
METHOD file_encode.
DATA: lt_fields TYPE tihttpnvp,
-* lo_descr_ref TYPE REF TO cl_abap_structdescr,
ls_field LIKE LINE OF lt_fields.
-
-* FIELD-SYMBOLS: <ls_comp> LIKE LINE OF lo_descr_ref->components,
-* <lg_any> TYPE any.
-*
-*
-* lo_descr_ref ?= cl_abap_typedescr=>describe_by_data( is_file ).
-*
-* LOOP AT lo_descr_ref->components ASSIGNING <ls_comp>.
-*
-* ASSIGN COMPONENT <ls_comp>-name OF STRUCTURE is_file TO <lg_any>.
-* ASSERT sy-subrc = 0.
-*
-* ls_field-name = <ls_comp>-name.
-* ls_field-value = <lg_any>.
-* APPEND ls_field TO lt_fields.
-* ENDLOOP.
ls_field-name = 'KEY'.
ls_field-value = iv_key.
|
|
ca6003c8cf922eddf9cdc0ac68770696bea28435 | Branch overview: fix compress button #569 | Branch overview: fix compress button #569 | sbcgua/abapGit,EduardoCopat/abapGit,apex8/abapGit,nununo/abapGit,EduardoCopat/abapGit,nununo/abapGit,sbcgua/abapGit,larshp/abapGit,larshp/abapGit,apex8/abapGit | 0 | mit | ABAP | --- src/zabapgit_page_branch_overview.prog.abap
+++ src/zabapgit_page_branch_overview.prog.abap
@@ -363,7 +363,6 @@
METHOD constructor.
super->constructor( ).
ms_control-page_title = 'BRANCH_OVERVIEW'.
- ms_control-page_menu = build_menu( ).
mo_repo = io_repo.
refresh( ).
ENDMETHOD.
@@ -428,6 +427,9 @@
ro_html->add( '<br>' ).
ro_html->add( render_merge( ) ).
+
+ ro_html->add( '<br>' ).
+ ro_html->add( build_menu( )->render( ) ).
* see http://stackoverflow.com/questions/6081483/maximum-size-of-a-canvas-element
_add '<canvas id="gitGraph"></canvas>'.
|
|
00d2e6514c2b9a5add0e3a1f234f6ed4a4d6dcae | Tests for = and function shorthand | Tests for = and function shorthand
| mydoghasworms/abap-lisp,mydoghasworms/abap-lisp,mydoghasworms/abap-lisp | 0 | mit | ABAP | --- ZUSR_LISP_TESTS.abap
+++ ZUSR_LISP_TESTS.abap
@@ -144,6 +144,11 @@
perform code_test using '''a'.
perform code_test using '''(list 1 2 3)'.
+* Test DEFINE
+ perform code_test using '(define 22 23)'. "Err
+ perform code_test using '(define a 23)'.
+ perform code_test using 'a'. "Err
+
* Test strings
perform code_test using '"string value"'.
perform code_test using '"string value with \" escaped double quote"'.
@@ -237,10 +242,9 @@
perform code_test using '(if (< 2 1) 23)'.
perform code_test using '(if (< 2 1) 23 24)'.
-* Test DEFINE
- perform code_test using '(define 22 23)'. "Err
- perform code_test using '(define a 23)'. "Err
- perform code_test using 'a'. "Err
+* Test =
+ perform code_test using '(= 2 3)'.
+ perform code_test using '(= 3 3)'.
* Test nil?
perform code_test using '(nil? ())'.
@@ -259,6 +263,9 @@
perform code_test using 'b'.
perform code_test using '(b 20)'.
perform code_test using '((lambda (a) (+ a 20)) 10 )'.
+* Function shorthand
+ perform code_test using '(define (fact x) (if (= x 0) 1 (* x (fact (- x 1)))))'.
+ perform code_test using '(fact 8)'.
endif.
|
|
a367ab945b3e997e37d1ea96fba2b44b1c3a3090 | move unit test to master branch | move unit test to master branch | sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,EduardoCopat/abapGit,larshp/abapGit,apex8/abapGit,nununo/abapGit,apex8/abapGit,sbcgua/abapGit,nununo/abapGit | 0 | mit | ABAP | --- zabapgit.prog.abap
+++ zabapgit.prog.abap
@@ -16892,7 +16892,7 @@
lo_repo = lcl_repo_srv=>new_online(
iv_url = 'https://github.com/larshp/abapGit-Unit-Test.git'
- iv_branch_name = 'refs/heads/next-gen-xml'
+ iv_branch_name = 'refs/heads/master'
iv_package = c_package ).
lo_repo->status( ).
lo_repo->deserialize( ).
|
|
cabd44e690f1a283a78ec8bcd95f8e47efb23493 | Delete zcl_abapgitserver.clas.abap | Delete zcl_abapgitserver.clas.abap | larshp/abapGitServer,larshp/abapGitServer | 0 | mit | ABAP | --- zcl_abapgitserver.clas.abap
+++ zcl_abapgitserver.clas.abap
@@ -1,61 +0,0 @@
-class ZCL_ABAPGITSERVER definition
- public
- final
- create public .
-
-public section.
-
- interfaces IF_HTTP_EXTENSION .
-protected section.
-
- methods READ_MIME
- importing
- !IV_URL type STRING
- returning
- value(RV_DATA) type XSTRING .
-private section.
-ENDCLASS.
-
-
-
-CLASS ZCL_ABAPGITSERVER IMPLEMENTATION.
-
-
-METHOD if_http_extension~handle_request.
-
- DATA: lv_reason TYPE string,
- lv_path TYPE string.
-
-
- lv_path = server->request->get_header_field( '~path' ).
-
- IF lv_path CP 'sap/zgit/static/*'.
- server->response->set_data( read_mime( 'index.html' ) ).
- ELSE.
- server->response->set_data( read_mime( 'index.html' ) ).
- ENDIF.
-
- server->response->set_status( code = 200
- reason = lv_reason ).
-
-ENDMETHOD.
-
-
-METHOD read_mime.
-
- DATA: li_api TYPE REF TO if_mr_api,
- lv_url TYPE string.
-
-
- CONCATENATE '/SAP/PUBLIC/zgit/' iv_url INTO lv_url.
-
- li_api = cl_mime_repository_api=>if_mr_api~get_api( ).
-
- li_api->get(
- EXPORTING
- i_url = lv_url
- IMPORTING
- e_content = rv_data ).
-
-ENDMETHOD.
-ENDCLASS. |
|
c3148f358870e62fa9f2852a1d0ff53317b949eb | a bit of downport work | a bit of downport work
| larshp/abapGitServer,larshp/abapGitServer | 0 | mit | ABAP | --- src/service/zcl_ags_service_rest.clas.abap
+++ src/service/zcl_ags_service_rest.clas.abap
@@ -314,9 +314,15 @@
DATA: lt_trees TYPE STANDARD TABLE OF ty_tree WITH DEFAULT KEY.
+ FIELD-SYMBOLS: <ls_file> LIKE LINE OF rt_files,
+ <ls_tree> LIKE LINE OF lt_trees.
+
DATA(lo_commit) = NEW zcl_ags_obj_commit( iv_commit ).
- APPEND VALUE #( sha1 = lo_commit->get( )-tree base = '/' ) TO lt_trees.
+
+ APPEND INITIAL LINE TO lt_trees ASSIGNING <ls_tree>.
+ <ls_tree>-sha1 = lo_commit->get( )-tree.
+ <ls_tree>-base = '/'.
LOOP AT lt_trees ASSIGNING FIELD-SYMBOL(<ls_tree>).
DATA(lo_tree) = NEW zcl_ags_obj_tree( <ls_tree>-sha1 ).
@@ -324,15 +330,13 @@
LOOP AT lt_files ASSIGNING FIELD-SYMBOL(<ls_file>).
CASE <ls_file>-chmod.
WHEN zcl_ags_obj_tree=>c_chmod-dir.
- APPEND VALUE #(
- sha1 = <ls_file>-sha1
- base = <ls_tree>-base && <ls_file>-name && '/' )
- TO lt_trees.
+ APPEND INITIAL LINE TO lt_trees ASSIGNING <ls_tree>.
+ <ls_tree>-sha1 = <ls_file>-sha1.
+ <ls_tree>-base = <ls_tree>-base && <ls_file>-name && '/'.
WHEN OTHERS.
- APPEND VALUE #(
- filename = <ls_tree>-base && <ls_file>-name
- sha1 = <ls_file>-sha1 )
- TO rt_files.
+ APPEND INITIAL LINE TO rt_files ASSIGNING <ls_file>.
+ <ls_file>-filename = <ls_tree>-base && <ls_file>-name.
+ <ls_file>-sha1 = <ls_file>-sha1.
ENDCASE.
ENDLOOP.
ENDLOOP.
|
|
2067910d0a8d22911e87c190111d4faedc5a695e | issue 1232, better error message (#1290) | issue 1232, better error message (#1290)
| larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/git/zcl_abapgit_git_porcelain.clas.abap
+++ src/git/zcl_abapgit_git_porcelain.clas.abap
@@ -179,6 +179,8 @@
IF iv_name CS ` `.
zcx_abapgit_exception=>raise( 'Branch name cannot contain blank spaces' ).
+ ELSEIF iv_from = ''.
+ zcx_abapgit_exception=>raise( 'New branch, "from" SHA1 empty' ).
ENDIF.
* "client MUST send an empty packfile"
|
|
beb333425133120754c698d36bb13e49fd59139f | switch source: hide mime option | switch source: hide mime option | sbcgua/mockup_loader | 0 | mit | ABAP | --- src/zmockup_loader_switch_source.prog.abap
+++ src/zmockup_loader_switch_source.prog.abap
@@ -641,6 +641,14 @@
ls_btn-quickinfo = 'Upload file to to MIME storage (smw0)'.
sscrfields-functxt_03 = ls_btn.
+ " Hide MIME option, seems to be not used. Also need refactoring in terms of target/source mime (2 fields)
+ loop at screen.
+ if screen-name = 'P_MIME' or screen-name = 'TXT_MIME'.
+ screen-active = 0.
+ endif.
+ modify screen.
+ endloop.
+
perform get_stype.
at selection-screen output.
@@ -691,6 +699,8 @@
screen-active = 1.
when 'P_FPATH' or 'TXT_FP'.
screen-active = 1.
+ when 'P_MIME' or 'TXT_MIME'.
+ screen-active = 0.
endcase.
modify screen.
endloop.
@@ -712,6 +722,8 @@
loop at screen.
case screen-name.
when 'P_MPATH' or 'P_FPATH' or 'TXT_FP' or 'TXT_MP' or 'TXT_MP2'.
+ screen-active = 0.
+ when 'P_MIME' or 'TXT_MIME'.
screen-active = 0.
endcase.
modify screen.
|
|
3d26041779d9717810f93e6c0442467c6ea7d6ac | DEVC: Remove obsolete TADIR entries during uninstall (#4150) | DEVC: Remove obsolete TADIR entries during uninstall (#4150)
* DEVC: Remove obsolete TADIR entries
In case a package is local (ie no transports), abapGit will now check if objects still exist in the package. In case an object does not exist anymore, the corresponding TADIR entry will be removed. This allows empty local packages to be uninstalled automatically.
* Lint
Co-authored-by: Lars Hvam <[email protected]> | sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_devc.clas.abap
+++ src/objects/zcl_abapgit_object_devc.clas.abap
@@ -12,26 +12,48 @@
iv_language TYPE spras.
PROTECTED SECTION.
PRIVATE SECTION.
- METHODS:
- get_package RETURNING VALUE(ri_package) TYPE REF TO if_package
- RAISING zcx_abapgit_exception,
- update_pinf_usages IMPORTING ii_package TYPE REF TO if_package
- it_usage_data TYPE scomppdata
- RAISING zcx_abapgit_exception,
- set_lock IMPORTING ii_package TYPE REF TO if_package
- iv_lock TYPE abap_bool
- RAISING zcx_abapgit_exception,
- is_empty
- IMPORTING iv_package_name TYPE devclass
- RETURNING VALUE(rv_is_empty) TYPE abap_bool
- RAISING zcx_abapgit_exception,
- load_package
- IMPORTING iv_package_name TYPE devclass
- RETURNING VALUE(ri_package) TYPE REF TO if_package
- RAISING zcx_abapgit_exception.
-
- DATA:
- mv_local_devclass TYPE devclass.
+
+ DATA mv_local_devclass TYPE devclass .
+
+ METHODS get_package
+ RETURNING
+ VALUE(ri_package) TYPE REF TO if_package
+ RAISING
+ zcx_abapgit_exception .
+ METHODS update_pinf_usages
+ IMPORTING
+ !ii_package TYPE REF TO if_package
+ !it_usage_data TYPE scomppdata
+ RAISING
+ zcx_abapgit_exception .
+ METHODS set_lock
+ IMPORTING
+ !ii_package TYPE REF TO if_package
+ !iv_lock TYPE abap_bool
+ RAISING
+ zcx_abapgit_exception .
+ METHODS is_empty
+ IMPORTING
+ !iv_package_name TYPE devclass
+ RETURNING
+ VALUE(rv_is_empty) TYPE abap_bool
+ RAISING
+ zcx_abapgit_exception .
+ METHODS load_package
+ IMPORTING
+ !iv_package_name TYPE devclass
+ RETURNING
+ VALUE(ri_package) TYPE REF TO if_package
+ RAISING
+ zcx_abapgit_exception .
+ METHODS is_local
+ IMPORTING
+ !iv_package_name TYPE devclass
+ RETURNING
+ VALUE(rv_is_local) TYPE abap_bool .
+ METHODS remove_obsolete_tadir
+ IMPORTING
+ !iv_package_name TYPE devclass .
ENDCLASS.
@@ -76,6 +98,19 @@
AND NOT ( object = 'DEVC' AND obj_name = iv_package_name )
AND devclass = iv_package_name.
rv_is_empty = boolc( sy-subrc <> 0 ).
+
+ ENDMETHOD.
+
+
+ METHOD is_local.
+
+ DATA lv_dlvunit TYPE tdevc-dlvunit.
+
+ SELECT SINGLE dlvunit FROM tdevc INTO lv_dlvunit
+ WHERE devclass = iv_package_name AND intsys <> 'SAP'.
+ IF sy-subrc = 0 AND lv_dlvunit = 'LOCAL'.
+ rv_is_local = abap_true.
+ ENDIF.
ENDMETHOD.
@@ -100,6 +135,50 @@
ELSEIF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
+
+ ENDMETHOD.
+
+
+ METHOD remove_obsolete_tadir.
+
+ DATA:
+ lv_pack TYPE devclass,
+ lt_pack TYPE STANDARD TABLE OF devclass,
+ ls_tadir TYPE zif_abapgit_definitions=>ty_tadir,
+ lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
+ ls_item TYPE zif_abapgit_definitions=>ty_item.
+
+ " TADIR entries must remain for transportable packages
+ IF is_local( iv_package_name ) = abap_false.
+ RETURN.
+ ENDIF.
+
+ " Clean-up sub packages first
+ SELECT devclass FROM tdevc INTO TABLE lt_pack WHERE parentcl = iv_package_name.
+
+ LOOP AT lt_pack INTO lv_pack.
+ remove_obsolete_tadir( lv_pack ).
+ ENDLOOP.
+
+ " Remove TADIR entries for objects that do not exist anymore
+ SELECT * FROM tadir INTO CORRESPONDING FIELDS OF TABLE lt_tadir WHERE devclass = iv_package_name.
+
+ LOOP AT lt_tadir INTO ls_tadir.
+ ls_item-obj_type = ls_tadir-object.
+ ls_item-obj_name = ls_tadir-obj_name.
+
+ IF zcl_abapgit_objects=>exists( ls_item ) = abap_false.
+ CALL FUNCTION 'TR_TADIR_INTERFACE'
+ EXPORTING
+ wi_delete_tadir_entry = abap_true
+ wi_tadir_pgmid = 'R3TR'
+ wi_tadir_object = ls_tadir-object
+ wi_tadir_obj_name = ls_tadir-obj_name
+ wi_test_modus = abap_false
+ EXCEPTIONS
+ OTHERS = 1 ##FM_SUBRC_OK.
+ ENDIF.
+ ENDLOOP.
ENDMETHOD.
@@ -262,6 +341,8 @@
" in the package has to be released.
lv_package = ms_item-obj_name.
+
+ remove_obsolete_tadir( lv_package ).
IF is_empty( lv_package ) = abap_true.
|
|
680dbd6b74ce1d4b550c7352e5afa27a8b378b60 | DDLS-Serialization: Write transport request entry (#2927) | DDLS-Serialization: Write transport request entry (#2927)
| larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_ddls.clas.abap
+++ src/objects/zcl_abapgit_object_ddls.clas.abap
@@ -177,6 +177,8 @@
objectname = ms_item-obj_name
devclass = iv_package
prid = 0.
+
+ corr_insert( iv_package ).
CATCH cx_root INTO lx_error.
zcx_abapgit_exception=>raise( iv_text = lx_error->get_text( )
|
|
8bd932f9449c8c193ffa0959f91346eb55bb2df3 | FUGR, FAE fix (#3611) | FUGR, FAE fix (#3611)
* FUGR, FAE fix
* FUGR, cache includes in instance
* remove CNAM field | sbcgua/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,larshp/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_fugr.clas.abap
+++ src/objects/zcl_abapgit_object_fugr.clas.abap
@@ -36,6 +36,8 @@
END OF ty_tpool_i18n .
TYPES:
tt_tpool_i18n TYPE STANDARD TABLE OF ty_tpool_i18n .
+
+ DATA: mt_includes_cache TYPE ty_sobj_name_tt.
METHODS check_rfc_parameters
IMPORTING
@@ -562,7 +564,6 @@
TYPES: BEGIN OF ty_reposrc,
progname TYPE reposrc-progname,
- cnam TYPE reposrc-cnam,
END OF ty_reposrc.
DATA: lt_reposrc TYPE STANDARD TABLE OF ty_reposrc WITH DEFAULT KEY,
@@ -577,6 +578,11 @@
FIELD-SYMBOLS: <lv_include> LIKE LINE OF rt_includes,
<ls_func> LIKE LINE OF lt_functab.
+
+ IF lines( mt_includes_cache ) > 0.
+ rt_includes = mt_includes_cache.
+ RETURN.
+ ENDIF.
lv_program = main_name( ).
lt_functab = functions( ).
@@ -648,11 +654,13 @@
ENDIF.
ENDLOOP.
- SELECT progname cnam FROM reposrc
- INTO TABLE lt_reposrc
- FOR ALL ENTRIES IN rt_includes
- WHERE progname = rt_includes-table_line
- AND r3state = 'A'.
+ IF lines( rt_includes ) > 0.
+ SELECT progname FROM reposrc
+ INTO TABLE lt_reposrc
+ FOR ALL ENTRIES IN rt_includes
+ WHERE progname = rt_includes-table_line
+ AND r3state = 'A'.
+ ENDIF.
SORT lt_reposrc BY progname ASCENDING.
ENDIF.
@@ -669,6 +677,8 @@
ENDLOOP.
APPEND lv_program TO rt_includes.
+
+ mt_includes_cache = rt_includes.
ENDMETHOD.
|
|
eea7f2527a9a1568559a7a1d3f9c384e62095916 | PARA: Unlock in case of errors (#4526) | PARA: Unlock in case of errors (#4526)
If a PARA object cannot be deleted, it remains locked.
The change unlocks the object in this case. | larshp/abapGit,larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_para.clas.abap
+++ src/objects/zcl_abapgit_object_para.clas.abap
@@ -6,11 +6,26 @@
PROTECTED SECTION.
PRIVATE SECTION.
+
+ METHODS unlock
+ IMPORTING
+ !iv_paramid TYPE memoryid .
ENDCLASS.
CLASS zcl_abapgit_object_para IMPLEMENTATION.
+
+
+ METHOD unlock.
+
+ CALL FUNCTION 'RS_ACCESS_PERMISSION'
+ EXPORTING
+ mode = 'FREE'
+ object = iv_paramid
+ object_class = 'PARA'.
+
+ ENDMETHOD.
METHOD zif_abapgit_object~changed_by.
@@ -54,12 +69,14 @@
SELECT COUNT(*) FROM cross
WHERE ( type = 'P' OR type = 'Q' ) AND name = lv_paramid.
IF sy-subrc = 0.
+ unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ELSE.
SELECT COUNT(*) FROM dd04l BYPASSING BUFFER
WHERE memoryid = lv_paramid
AND as4local = 'A'.
IF sy-subrc = 0.
+ unlock( lv_paramid ).
zcx_abapgit_exception=>raise( 'PARA: Parameter is still used' ).
ENDIF.
ENDIF.
@@ -89,14 +106,11 @@
type = 'CR'.
ENDIF.
ELSE.
+ unlock( lv_paramid ).
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
- CALL FUNCTION 'RS_ACCESS_PERMISSION'
- EXPORTING
- mode = 'FREE'
- object = lv_paramid
- object_class = 'PARA'.
+ unlock( lv_paramid ).
ENDMETHOD.
|
|
1dd5ebcb4277221b84b2f07a8b9e2396c5e0b5c0 | Fix dump for repos using data tables (#5581) | Fix dump for repos using data tables (#5581)
* Fix dump for repos using data tables
Fixes dump in `zcl_abapgit_data_util` in case the data table does not exist yet.
* Method
Co-authored-by: Lars Hvam <[email protected]> | sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/data/zcl_abapgit_data_serializer.clas.abap
+++ src/data/zcl_abapgit_data_serializer.clas.abap
@@ -28,6 +28,11 @@
VALUE(rr_data) TYPE REF TO data
RAISING
zcx_abapgit_exception .
+ METHODS exists_database_table
+ IMPORTING
+ !iv_name TYPE tadir-obj_name
+ RETURNING
+ VALUE(rv_exists) TYPE abap_bool.
ENDCLASS.
@@ -57,6 +62,28 @@
ENDTRY.
rv_data = zcl_abapgit_convert=>string_to_xstring_utf8( lv_string ).
+
+ ENDMETHOD.
+
+
+ METHOD exists_database_table.
+
+ DATA lv_table TYPE tabname.
+ DATA lv_subrc TYPE sy-subrc.
+
+ lv_table = iv_name.
+
+ CALL FUNCTION 'DD_EXIST_TABLE'
+ EXPORTING
+ tabname = lv_table
+ status = 'A'
+ IMPORTING
+ subrc = lv_subrc
+ EXCEPTIONS
+ wrong_status = 1
+ OTHERS = 2.
+
+ rv_exists = boolc( sy-subrc = 0 AND lv_subrc = 0 ).
ENDMETHOD.
@@ -101,14 +128,16 @@
ASSERT ls_config-type = zif_abapgit_data_config=>c_data_type-tabu. " todo
ASSERT ls_config-name IS NOT INITIAL.
- lr_data = read_database_table(
- iv_name = ls_config-name
- it_where = ls_config-where ).
+ IF exists_database_table( ls_config-name ) = abap_true.
+ lr_data = read_database_table(
+ iv_name = ls_config-name
+ it_where = ls_config-where ).
- ls_file-filename = zcl_abapgit_data_utils=>build_filename( ls_config ).
- ls_file-data = convert_itab_to_json( lr_data ).
- ls_file-sha1 = zcl_abapgit_hash=>sha1_blob( ls_file-data ).
- APPEND ls_file TO rt_files.
+ ls_file-filename = zcl_abapgit_data_utils=>build_filename( ls_config ).
+ ls_file-data = convert_itab_to_json( lr_data ).
+ ls_file-sha1 = zcl_abapgit_hash=>sha1_blob( ls_file-data ).
+ APPEND ls_file TO rt_files.
+ ENDIF.
ENDLOOP.
|
|
1ee92803d69e7fbcfc7cbb822474c5779f370a74 | bump version to v1.24.6 | bump version to v1.24.6 | EduardoCopat/abapGit,nununo/abapGit,EduardoCopat/abapGit,apex8/abapGit,sbcgua/abapGit,larshp/abapGit,apex8/abapGit,sbcgua/abapGit,larshp/abapGit,nununo/abapGit | 0 | mit | ABAP | --- src/zabapgit.prog.abap
+++ src/zabapgit.prog.abap
@@ -3,7 +3,7 @@
* See http://www.abapgit.org
CONSTANTS: gc_xml_version TYPE string VALUE 'v1.0.0', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v1.24.5'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v1.24.6'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
|
|
1a94c9a0f068947faa4925f70dac52edbefd8f8d | TYPE: Serialize active version (#4593) | TYPE: Serialize active version (#4593)
* TYPE: Serialize active version
When a new type-pools is created, SAP creates active version by default. SY-SUBRC is always set to 0 for the first function module call as there is always an active version hence, second function will never be called. Remove the second call.
* Multiple changes
Check existence of the object using TADIR entry
If the active object doesn't exist, show proper message
* Existence check using PROGDIR
* Replace SELECT..ENDSELECT
Co-authored-by: Lars Hvam <[email protected]> | larshp/abapGit,larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_type.clas.abap
+++ src/objects/zcl_abapgit_object_type.clas.abap
@@ -11,7 +11,7 @@
METHODS read
EXPORTING ev_ddtext TYPE ddtypet-ddtext
et_source TYPE abaptxt255_tab
- RAISING zcx_abapgit_not_found.
+ RAISING zcx_abapgit_exception.
METHODS create
IMPORTING iv_ddtext TYPE ddtypet-ddtext
@@ -23,7 +23,7 @@
-CLASS zcl_abapgit_object_type IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
METHOD create.
@@ -92,23 +92,7 @@
reps_not_exist = 2
OTHERS = 3.
IF sy-subrc <> 0.
- " Inactive version
- CALL FUNCTION 'TYPD_GET_OBJECT'
- EXPORTING
- typdname = lv_typdname
- r3state = 'I'
- TABLES
- psmodisrc = lt_psmodisrc
- psmodilog = lt_psmodilog
- psource = et_source
- ptrdir = lt_ptrdir
- EXCEPTIONS
- version_not_found = 1
- reps_not_exist = 2
- OTHERS = 3.
- ENDIF.
- IF sy-subrc <> 0.
- RAISE EXCEPTION TYPE zcx_abapgit_not_found.
+ zcx_abapgit_exception=>raise( |No active version found for { ms_item-obj_type } { ms_item-obj_name }| ).
ENDIF.
ENDMETHOD.
@@ -162,13 +146,17 @@
METHOD zif_abapgit_object~exists.
- TRY.
- read( ).
- rv_bool = abap_true.
- CATCH zcx_abapgit_not_found
- zcx_abapgit_exception.
- rv_bool = abap_false.
- ENDTRY.
+ DATA: lv_progname TYPE progname,
+ lv_state TYPE r3state.
+
+ lv_progname = |%_C{ ms_item-obj_name }|.
+ SELECT SINGLE state
+ FROM progdir
+ INTO lv_state
+ WHERE name = lv_progname.
+ IF lv_state IS NOT INITIAL.
+ rv_bool = abap_true.
+ ENDIF.
ENDMETHOD.
@@ -209,13 +197,8 @@
lt_source TYPE abaptxt255_tab.
- TRY.
- read( IMPORTING
- ev_ddtext = lv_ddtext
- et_source = lt_source ).
- CATCH zcx_abapgit_not_found.
- RETURN.
- ENDTRY.
+ read( IMPORTING ev_ddtext = lv_ddtext
+ et_source = lt_source ).
io_xml->add( iv_name = 'DDTEXT'
ig_data = lv_ddtext ).
|
|
7f312f8634bb4538ce50d6853fd4633f9dd352ed | Patch: fix regression | Patch: fix regression | EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/ui/zcl_abapgit_html_action_utils.clas.abap
+++ src/ui/zcl_abapgit_html_action_utils.clas.abap
@@ -202,7 +202,7 @@
DATA: lt_fields TYPE tihttpnvp.
- ASSERT eg_file IS SUPPLIED OR eg_object IS SUPPLIED.
+ ASSERT eg_file IS SUPPLIED OR eg_object IS SUPPLIED OR ev_key IS SUPPLIED.
CLEAR: ev_key, eg_file, eg_object.
lt_fields = parse_fields_upper_case_name( iv_string ).
|
|
16d69e8ab993fd7b1903cf9f0732af964c1306f5 | DOCV: Handle namespaces (#5756) | DOCV: Handle namespaces (#5756)
| sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_docv.clas.abap
+++ src/objects/zcl_abapgit_object_docv.clas.abap
@@ -1,22 +1,37 @@
-CLASS zcl_abapgit_object_docv DEFINITION PUBLIC INHERITING FROM zcl_abapgit_objects_super FINAL.
+CLASS zcl_abapgit_object_docv DEFINITION
+ PUBLIC
+ INHERITING FROM zcl_abapgit_objects_super
+ FINAL
+ CREATE PUBLIC.
PUBLIC SECTION.
+
INTERFACES zif_abapgit_object.
+
+ METHODS constructor
+ IMPORTING
+ !is_item TYPE zif_abapgit_definitions=>ty_item
+ !iv_language TYPE spras.
PROTECTED SECTION.
PRIVATE SECTION.
- CONSTANTS: c_typ TYPE dokhl-typ VALUE 'E',
- c_version TYPE dokhl-dokversion VALUE '0001',
- c_name TYPE string VALUE 'DOC'.
- TYPES: BEGIN OF ty_data,
- doctitle TYPE dsyst-doktitle,
- head TYPE thead,
- lines TYPE tline_tab,
- END OF ty_data.
+ TYPES:
+ BEGIN OF ty_data,
+ doctitle TYPE dsyst-doktitle,
+ head TYPE thead,
+ lines TYPE tline_tab,
+ END OF ty_data.
- METHODS: read
- RETURNING VALUE(rs_data) TYPE ty_data.
+ CONSTANTS c_typ TYPE dokhl-typ VALUE 'E' ##NO_TEXT.
+ CONSTANTS c_version TYPE dokhl-dokversion VALUE '0001' ##NO_TEXT.
+ CONSTANTS c_name TYPE string VALUE 'DOC' ##NO_TEXT.
+ DATA mv_id TYPE dokhl-id.
+ DATA mv_doc_object TYPE dokhl-object.
+
+ METHODS read
+ RETURNING
+ VALUE(rs_data) TYPE ty_data.
ENDCLASS.
@@ -24,20 +39,34 @@
CLASS zcl_abapgit_object_docv IMPLEMENTATION.
- METHOD read.
+ METHOD constructor.
- DATA: lv_object TYPE dokhl-object,
- lv_id TYPE dokhl-id.
+ DATA: lv_prefix TYPE namespace,
+ lv_bare_name TYPE progname.
+
+ super->constructor( is_item = is_item
+ iv_language = iv_language ).
+
+ CALL FUNCTION 'RS_NAME_SPLIT_NAMESPACE'
+ EXPORTING
+ name_with_namespace = ms_item-obj_name
+ IMPORTING
+ namespace = lv_prefix
+ name_without_namespace = lv_bare_name.
+
+ mv_id = lv_bare_name(2).
+ mv_doc_object = |{ lv_prefix }{ lv_bare_name+2(*) }|.
+
+ ENDMETHOD.
- lv_id = ms_item-obj_name(2).
- lv_object = ms_item-obj_name+2.
+ METHOD read.
CALL FUNCTION 'DOCU_READ'
EXPORTING
- id = lv_id
+ id = mv_id
langu = mv_language
- object = lv_object
+ object = mv_doc_object
typ = c_typ
version = c_version
IMPORTING
@@ -59,18 +88,11 @@
METHOD zif_abapgit_object~delete.
- DATA: lv_id TYPE dokhl-id,
- lv_object TYPE dokhl-object.
-
-
- lv_id = ms_item-obj_name(2).
- lv_object = ms_item-obj_name+2.
-
CALL FUNCTION 'DOCU_DEL'
EXPORTING
- id = lv_id
+ id = mv_id
langu = mv_language
- object = lv_object
+ object = mv_doc_object
typ = c_typ
EXCEPTIONS
ret_code = 1
@@ -104,16 +126,9 @@
METHOD zif_abapgit_object~exists.
- DATA: lv_id TYPE dokhl-id,
- lv_object TYPE dokhl-object.
-
-
- lv_id = ms_item-obj_name(2).
- lv_object = ms_item-obj_name+2.
-
- SELECT SINGLE id FROM dokil INTO lv_id
- WHERE id = lv_id
- AND object = lv_object. "#EC CI_GENBUFF
+ SELECT SINGLE id FROM dokil INTO mv_id
+ WHERE id = mv_id
+ AND object = mv_doc_object. "#EC CI_GENBUFF
rv_bool = boolc( sy-subrc = 0 ).
|
|
ffac70b9c3097ba5f231131164b54abd6c567c95 | TRAN: ignore object not found while delete | TRAN: ignore object not found while delete
If the transaction can't be found in FM RPY_TRANSACTION_DELETE, it's already deleted | sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,EduardoCopat/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_tran.clas.abap
+++ src/objects/zcl_abapgit_object_tran.clas.abap
@@ -510,7 +510,7 @@
transaction = lv_transaction
EXCEPTIONS
not_excecuted = 1
- object_not_found = 2
+ object_not_found = 0
OTHERS = 3.
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( 'Error from RPY_TRANSACTION_DELETE' ).
|
|
9974246775c47a453d86d9284b9758bf128b6406 | DTDCs no longer have an own data class (#5478) | DTDCs no longer have an own data class (#5478)
Starting with ABAP Platform 2208 DTDC does no longer have an own workbench data class but instead uses CL_BLUE_SOURCE_OBJECT_DATA directly.
In addition:
The field that carries the ABAP language version changed from ABAP_LANGUAGE_VERSION to ABAP_LANGU_VERSION in ABAP Platform 2208. So to make it work in both releases < and >= ABAP Platform 2208 we have to try to clear both versions of that field.
Co-authored-by: Lars Hvam <[email protected]>
Co-authored-by: Marc Bernard <b87df29b98274de0b03db8f81c149b8b52bd050e@users.noreply.github.com> | larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_dtdc.clas.abap
+++ src/objects/zcl_abapgit_object_dtdc.clas.abap
@@ -34,13 +34,18 @@
RETURNING
VALUE(ri_wb_object_operator) TYPE REF TO object
RAISING
- zcx_abapgit_exception.
-
- DATA:
- mr_dynamic_cache TYPE REF TO data,
- mv_dynamic_cache_key TYPE seu_objkey,
- mi_persistence TYPE REF TO if_wb_object_persist,
- mi_wb_object_operator TYPE REF TO object.
+ zcx_abapgit_exception,
+
+ has_own_wb_data_class
+ RETURNING
+ VALUE(rv_supported) TYPE abap_bool.
+
+ DATA:
+ mr_dynamic_cache TYPE REF TO data,
+ mv_dynamic_cache_key TYPE seu_objkey,
+ mv_has_own_wb_data_class TYPE abap_bool,
+ mi_persistence TYPE REF TO if_wb_object_persist,
+ mi_wb_object_operator TYPE REF TO object.
ENDCLASS.
@@ -54,9 +59,9 @@
ASSIGN COMPONENT iv_fieldname OF STRUCTURE cs_dynamic_cache
TO <lv_value>.
- ASSERT sy-subrc = 0.
-
- CLEAR: <lv_value>.
+ IF sy-subrc = 0.
+ CLEAR: <lv_value>.
+ ENDIF.
ENDMETHOD.
@@ -102,6 +107,17 @@
clear_field(
EXPORTING
iv_fieldname = 'METADATA-PACKAGE_REF'
+ CHANGING
+ cs_dynamic_cache = cs_dynamic_cache ).
+
+ clear_field(
+ EXPORTING
+ iv_fieldname = 'METADATA-ABAP_LANGUAGE_VERSION'
+ CHANGING
+ cs_dynamic_cache = cs_dynamic_cache ).
+ clear_field(
+ EXPORTING
+ iv_fieldname = 'METADATA-ABAP_LANGU_VERSION'
CHANGING
cs_dynamic_cache = cs_dynamic_cache ).
@@ -121,9 +137,14 @@
iv_language = iv_language ).
mv_dynamic_cache_key = ms_item-obj_name.
-
- TRY.
- CREATE DATA mr_dynamic_cache TYPE ('CL_DTDC_WB_OBJECT_DATA=>TY_DTDC_OBJECT_DATA').
+ mv_has_own_wb_data_class = has_own_wb_data_class( ).
+
+ TRY.
+ IF mv_has_own_wb_data_class = abap_true.
+ CREATE DATA mr_dynamic_cache TYPE ('CL_DTDC_WB_OBJECT_DATA=>TY_DTDC_OBJECT_DATA').
+ ELSE.
+ CREATE DATA mr_dynamic_cache TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
+ ENDIF.
CREATE OBJECT mi_persistence TYPE ('CL_DTDC_OBJECT_PERSIST').
CATCH cx_sy_create_error.
@@ -148,7 +169,11 @@
li_wb_object_operator = get_wb_object_operator( ).
- CREATE DATA lr_dynamic_cache_old TYPE ('CL_DTDC_WB_OBJECT_DATA=>TY_DTDC_OBJECT_DATA').
+ IF mv_has_own_wb_data_class = abap_true.
+ CREATE DATA lr_dynamic_cache_old TYPE ('CL_DTDC_WB_OBJECT_DATA=>TY_DTDC_OBJECT_DATA').
+ ELSE.
+ CREATE DATA lr_dynamic_cache_old TYPE ('CL_BLUE_SOURCE_OBJECT_DATA=>TY_OBJECT_DATA').
+ ENDIF.
ASSIGN lr_dynamic_cache_old->* TO <ls_dynamic_cache_old>.
ASSERT sy-subrc = 0.
@@ -274,7 +299,11 @@
li_wb_object_operator = get_wb_object_operator( ).
TRY.
- CREATE OBJECT li_object_data_model TYPE ('CL_DTDC_WB_OBJECT_DATA').
+ IF mv_has_own_wb_data_class = abap_true.
+ CREATE OBJECT li_object_data_model TYPE ('CL_DTDC_WB_OBJECT_DATA').
+ ELSE.
+ CREATE OBJECT li_object_data_model TYPE ('CL_BLUE_SOURCE_OBJECT_DATA').
+ ENDIF.
ASSIGN COMPONENT 'CONTENT-SOURCE' OF STRUCTURE <ls_dynamic_cache>
TO <lv_source>.
@@ -421,4 +450,20 @@
iv_string = lv_source ).
ENDMETHOD.
+
+
+ METHOD has_own_wb_data_class.
+
+ DATA:
+ lr_own_type TYPE REF TO data,
+ lx_error TYPE REF TO cx_root.
+
+ TRY.
+ CREATE DATA lr_own_type TYPE ('CL_DTDC_WB_OBJECT_DATA=>TY_DTDC_OBJECT_DATA').
+ rv_supported = abap_true.
+ CATCH cx_root INTO lx_error.
+ rv_supported = abap_false.
+ ENDTRY.
+
+ ENDMETHOD.
ENDCLASS.
|
|
a96fed4b26ca3ed833b4c781039b7b5efa55727e | ENHC: Fix diffs due to OTR (#5538) | ENHC: Fix diffs due to OTR (#5538)
`cl_enh_composite` already handles OTR shorttext and there's no need to use `zcl_abapgit_sotr_handler`.
Update test case:
https://github.com/abapGit-tests/ENHC
Co-authored-by: Lars Hvam <[email protected]> | larshp/abapGit,sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_enhc.clas.abap
+++ src/objects/zcl_abapgit_object_enhc.clas.abap
@@ -136,10 +136,6 @@
li_enh_composite->if_enh_object~activate( ).
li_enh_composite->if_enh_object~unlock( ).
- zcl_abapgit_sotr_handler=>create_sotr(
- iv_package = iv_package
- io_xml = io_xml ).
-
CATCH cx_enh_root INTO lx_enh_root.
zcx_abapgit_exception=>raise_with_text( lx_enh_root ).
ENDTRY.
@@ -229,12 +225,6 @@
io_xml->add( iv_name = 'LONGTEXT_ID'
ig_data = lv_longtext_id ).
- zcl_abapgit_sotr_handler=>read_sotr(
- iv_pgmid = 'R3TR'
- iv_object = ms_item-obj_type
- iv_obj_name = ms_item-obj_name
- io_xml = io_xml ).
-
CATCH cx_enh_root INTO lx_enh_root.
zcx_abapgit_exception=>raise_with_text( lx_enh_root ).
ENDTRY.
|
|
ffc411b8f14fd620768eae22b35b54c7c1a13674 | use remote .abapgit if local repo is empty (#2736) | use remote .abapgit if local repo is empty (#2736)
* use remote .abapgit if repo is empty
* use method find_remote_dot_abapgit
* cleanup
* cleanup /2
| EduardoCopat/abapGit,sbcgua/abapGit,larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/zcl_abapgit_file_status.clas.abap
+++ src/zcl_abapgit_file_status.clas.abap
@@ -404,10 +404,20 @@
METHOD status.
DATA: lv_index LIKE sy-tabix,
- lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit.
-
- FIELD-SYMBOLS <ls_result> LIKE LINE OF rt_results.
-
+ lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit,
+ lt_local TYPE zif_abapgit_definitions=>ty_files_item_tt.
+
+ FIELD-SYMBOLS: <ls_result> LIKE LINE OF rt_results.
+
+ lt_local = io_repo->get_files_local( ii_log = ii_log ).
+
+ IF lines( lt_local ) <= 2.
+ " Less equal two means that we have only the .abapgit.xml and the package in
+ " our local repository. In this case we have to update our local .abapgit.xml
+ " from the remote one. Otherwise we get errors when e.g. the folder starting
+ " folder is different.
+ io_repo->find_remote_dot_abapgit( ).
+ ENDIF.
rt_results = calculate_status(
iv_devclass = io_repo->get_package( )
|
|
1b154ccf7f5ba2f098a7ee971114c1acaff2f0f0 | list superpackages, fix double entries #1612 (#1632) | list superpackages, fix double entries #1612 (#1632)
list superpackages, fix double entries #1612 | sbcgua/abapGit,larshp/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/zcl_abapgit_sap_package.clas.abap
+++ src/zcl_abapgit_sap_package.clas.abap
@@ -20,11 +20,37 @@
-CLASS zcl_abapgit_sap_package IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_SAP_PACKAGE IMPLEMENTATION.
METHOD constructor.
mv_package = iv_package.
+ ENDMETHOD.
+
+
+ METHOD zif_abapgit_sap_package~are_changes_recorded_in_tr_req.
+
+ DATA: li_package TYPE REF TO if_package.
+
+ cl_package_factory=>load_package(
+ EXPORTING
+ i_package_name = mv_package
+ IMPORTING
+ e_package = li_package
+ EXCEPTIONS
+ object_not_existing = 1
+ unexpected_error = 2
+ intern_err = 3
+ no_access = 4
+ object_locked_and_modified = 5
+ OTHERS = 6 ).
+
+ IF sy-subrc <> 0.
+ zcx_abapgit_exception=>raise( |Error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE { sy-subrc }| ).
+ ENDIF.
+
+ rv_are_changes_rec_in_tr_req = li_package->wbo_korr_flag.
+
ENDMETHOD.
@@ -131,48 +157,6 @@
ENDMETHOD.
- METHOD zif_abapgit_sap_package~create_local.
-
- DATA: ls_package TYPE scompkdtln.
-
-
- ls_package-devclass = mv_package.
- ls_package-ctext = mv_package.
- ls_package-parentcl = '$TMP'.
- ls_package-dlvunit = 'LOCAL'.
- ls_package-as4user = sy-uname.
-
- create( ls_package ).
-
- ENDMETHOD. "create
-
-
- METHOD zif_abapgit_sap_package~are_changes_recorded_in_tr_req.
-
- DATA: li_package TYPE REF TO if_package.
-
- cl_package_factory=>load_package(
- EXPORTING
- i_package_name = mv_package
- IMPORTING
- e_package = li_package
- EXCEPTIONS
- object_not_existing = 1
- unexpected_error = 2
- intern_err = 3
- no_access = 4
- object_locked_and_modified = 5
- OTHERS = 6 ).
-
- IF sy-subrc <> 0.
- zcx_abapgit_exception=>raise( |Error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE { sy-subrc }| ).
- ENDIF.
-
- rv_are_changes_rec_in_tr_req = li_package->wbo_korr_flag.
-
- ENDMETHOD.
-
-
METHOD zif_abapgit_sap_package~create_child.
DATA: li_parent TYPE REF TO if_package,
@@ -207,6 +191,22 @@
ENDMETHOD.
+ METHOD zif_abapgit_sap_package~create_local.
+
+ DATA: ls_package TYPE scompkdtln.
+
+
+ ls_package-devclass = mv_package.
+ ls_package-ctext = mv_package.
+ ls_package-parentcl = '$TMP'.
+ ls_package-dlvunit = 'LOCAL'.
+ ls_package-as4user = sy-uname.
+
+ create( ls_package ).
+
+ ENDMETHOD. "create
+
+
METHOD zif_abapgit_sap_package~exists.
cl_package_factory=>load_package(
@@ -293,7 +293,6 @@
FROM tdevc WHERE devclass = mv_package. "#EC CI_GENBUFF
IF sy-subrc = 0 AND NOT lv_parent IS INITIAL.
- APPEND lv_parent TO rt_list.
lt_list = zcl_abapgit_factory=>get_sap_package( lv_parent )->list_superpackages( ).
APPEND LINES OF lt_list TO rt_list.
ENDIF.
|
|
11a175d467ec374bf8b515001845eddc75c3df51 | stage: remove also ignored local files | stage: remove also ignored local files
Ignored files posses the property that they do not exist in remotes but do exist in local
repositories.
Before this patch, local ignored files were displayed in the Stage. | EduardoCopat/abapGit,sbcgua/abapGit,larshp/abapGit,EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/zcl_abapgit_stage_logic.clas.abap
+++ src/zcl_abapgit_stage_logic.clas.abap
@@ -52,7 +52,8 @@
DATA: lv_index TYPE i.
- FIELD-SYMBOLS: <ls_remote> LIKE LINE OF cs_files-remote.
+ FIELD-SYMBOLS: <ls_remote> LIKE LINE OF cs_files-remote,
+ <ls_local> LIKE LINE OF cs_files-local.
LOOP AT cs_files-remote ASSIGNING <ls_remote>.
@@ -70,6 +71,17 @@
ENDLOOP.
+ LOOP AT cs_files-local ASSIGNING <ls_local>.
+ lv_index = sy-tabix.
+
+ IF io_repo->get_dot_abapgit( )->is_ignored(
+ iv_path = <ls_local>-file-path
+ iv_filename = <ls_local>-file-filename ) = abap_true.
+ DELETE cs_files-local INDEX lv_index.
+ ENDIF.
+
+ ENDLOOP.
+
ENDMETHOD.
|
|
842073277275a21b9e5759c686243a6c7740823a | v1.48.0 | v1.48.0 | sbcgua/abapGit,larshp/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/zif_abapgit_definitions.intf.abap
+++ src/zif_abapgit_definitions.intf.abap
@@ -2,7 +2,7 @@
PUBLIC .
CONSTANTS gc_xml_version TYPE string VALUE 'v1.0.0' ##NO_TEXT.
- CONSTANTS gc_abap_version TYPE string VALUE 'v1.47.0' ##NO_TEXT.
+ CONSTANTS gc_abap_version TYPE string VALUE 'v1.48.0' ##NO_TEXT.
TYPES:
ty_type TYPE c LENGTH 6 .
|
|
e66db7f33f7304f9691f2c95a8d5aa7663760ef2 | deflate implementation, issue #122 | deflate implementation, issue #122
fix very slow decompression
not closing the issue right now as it still could use some refactoring
getting it out there so it can be tested, if it doesnt work roll back to version 0.80
on test repository the runtime went from 330 seconds to 30 seconds | nununo/abapGit,larshp/abapGit,EduardoCopat/abapGit,apex8/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,nununo/abapGit,sbcgua/abapGit,apex8/abapGit | 0 | mit | ABAP | --- zabapgit.abap
+++ zabapgit.abap
@@ -3,7 +3,7 @@
* See https://github.com/larshp/abapGit/
CONSTANTS: gc_xml_version TYPE string VALUE 'v0.2-alpha', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v0.80'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v0.81'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
@@ -204,6 +204,713 @@
ENDCLASS. "lcx_not_found IMPLEMENTATION
*----------------------------------------------------------------------*
+* CLASS lcl_zlib_huffman DEFINITION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_huffman DEFINITION FINAL.
+
+ PUBLIC SECTION.
+ TYPES: ty_lengths TYPE STANDARD TABLE OF i WITH DEFAULT KEY.
+
+ CONSTANTS: c_maxbits TYPE i VALUE 15.
+
+ METHODS:
+ constructor
+ IMPORTING it_lengths TYPE ty_lengths,
+ get_count
+ IMPORTING iv_index TYPE i
+ RETURNING VALUE(rv_value) TYPE i,
+ get_symbol
+ IMPORTING iv_index TYPE i
+ RETURNING VALUE(rv_value) TYPE i.
+
+ PRIVATE SECTION.
+
+ DATA: mt_count TYPE STANDARD TABLE OF i WITH DEFAULT KEY,
+ mt_symbol TYPE STANDARD TABLE OF i WITH DEFAULT KEY.
+
+ENDCLASS. "lcl_zlib_huffman DEFINITION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib_huffman DEFINITION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_huffman IMPLEMENTATION.
+
+ METHOD get_count.
+ READ TABLE mt_count INDEX iv_index INTO rv_value. "#EC CI_SUBRC
+ ENDMETHOD. "count
+
+ METHOD get_symbol.
+ READ TABLE mt_symbol INDEX iv_index INTO rv_value. "#EC CI_SUBRC
+ ENDMETHOD. "symbol
+
+ METHOD constructor.
+
+ DATA: lv_index TYPE i,
+ lt_offset TYPE TABLE OF i,
+ lv_length LIKE LINE OF it_lengths,
+ lv_prev TYPE i,
+ lv_count LIKE LINE OF mt_count.
+
+ FIELD-SYMBOLS: <lv_offset> LIKE LINE OF lt_offset,
+ <lv_symbol> LIKE LINE OF mt_symbol,
+ <lv_i> LIKE LINE OF it_lengths.
+
+
+ DO c_maxbits TIMES.
+ APPEND 0 TO mt_count.
+ ENDDO.
+ LOOP AT it_lengths INTO lv_index.
+ IF lv_index = 0.
+ CONTINUE.
+ ENDIF.
+ READ TABLE mt_count INDEX lv_index ASSIGNING <lv_i>.
+ ASSERT sy-subrc = 0.
+ <lv_i> = <lv_i> + 1.
+ ENDLOOP.
+
+************
+
+ APPEND 0 TO lt_offset.
+ DO c_maxbits - 1 TIMES.
+ READ TABLE mt_count INDEX sy-index INTO lv_count.
+ ASSERT sy-subrc = 0.
+ lv_prev = lv_prev + lv_count.
+ APPEND lv_prev TO lt_offset.
+ ENDDO.
+
+ DO lines( it_lengths ) TIMES.
+ APPEND 0 TO mt_symbol.
+ ENDDO.
+ DO lines( it_lengths ) TIMES.
+ lv_index = sy-index.
+ READ TABLE it_lengths INDEX lv_index INTO lv_length.
+ ASSERT sy-subrc = 0.
+ IF lv_length = 0.
+ CONTINUE.
+ ENDIF.
+ READ TABLE lt_offset INDEX lv_length ASSIGNING <lv_offset>.
+ ASSERT sy-subrc = 0.
+ READ TABLE mt_symbol INDEX <lv_offset> + 1 ASSIGNING <lv_symbol>.
+ ASSERT sy-subrc = 0.
+ <lv_symbol> = lv_index - 1.
+ <lv_offset> = <lv_offset> + 1.
+ ENDDO.
+
+ ENDMETHOD. "constructor
+
+ENDCLASS. "lcl_zlib_huffman DEFINITION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib_convert DEFINITION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_convert DEFINITION FINAL.
+
+ PUBLIC SECTION.
+ CLASS-METHODS:
+ hex_to_bits
+ IMPORTING iv_hex TYPE xsequence
+ RETURNING VALUE(rv_bits) TYPE string,
+ bits_to_int
+ IMPORTING iv_bits TYPE clike
+ RETURNING VALUE(rv_int) TYPE i,
+ int_to_hex
+ IMPORTING iv_int TYPE i
+ RETURNING VALUE(rv_hex) TYPE xstring.
+
+ENDCLASS. "lcl_zlib_convert DEFINITION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib_convert IMPLEMENTATION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_convert IMPLEMENTATION.
+
+ METHOD hex_to_bits.
+
+ DATA: lv_x TYPE x LENGTH 1,
+ lv_c TYPE c LENGTH 1,
+ lv_bit TYPE i,
+ lv_hex TYPE xstring.
+
+
+ lv_hex = iv_hex.
+ WHILE NOT lv_hex IS INITIAL.
+ lv_x = lv_hex.
+ DO 8 TIMES.
+ lv_bit = sy-index.
+ GET BIT lv_bit OF lv_x INTO lv_c.
+ CONCATENATE rv_bits lv_c INTO rv_bits.
+ ENDDO.
+ lv_hex = lv_hex+1.
+ ENDWHILE.
+
+ ENDMETHOD. "hex_to_bits
+
+ METHOD bits_to_int.
+
+ DATA: lv_c TYPE c LENGTH 1,
+ lv_bits TYPE string.
+
+ lv_bits = iv_bits.
+
+ WHILE NOT lv_bits IS INITIAL.
+ lv_c = lv_bits.
+ rv_int = rv_int * 2.
+ rv_int = rv_int + lv_c.
+ lv_bits = lv_bits+1.
+ ENDWHILE.
+
+ ENDMETHOD. "bits_to_int
+
+ METHOD int_to_hex.
+
+ DATA: lv_x TYPE x.
+
+
+ lv_x = iv_int.
+ rv_hex = lv_x.
+
+ ENDMETHOD. "int_to_hex
+
+ENDCLASS. "lcl_zlib_convert IMPLEMENTATION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib_stream DEFINITION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_stream DEFINITION FINAL.
+
+ PUBLIC SECTION.
+ METHODS:
+ constructor
+ IMPORTING iv_data TYPE xstring,
+ take_bits
+ IMPORTING iv_length TYPE i
+ RETURNING VALUE(rv_bits) TYPE string,
+ take_int
+ IMPORTING iv_length TYPE i
+ RETURNING VALUE(rv_int) TYPE i,
+ remaining
+ RETURNING VALUE(rv_length) TYPE i.
+
+ PRIVATE SECTION.
+ DATA: mv_compressed TYPE xstring,
+ mv_bits TYPE string.
+
+ENDCLASS. "lcl_zlib_stream DEFINITION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib_stream IMPLEMENTATION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib_stream IMPLEMENTATION.
+
+ METHOD constructor.
+
+ mv_compressed = iv_data.
+
+ ENDMETHOD. "constructor
+
+ METHOD remaining.
+
+ rv_length = xstrlen( mv_compressed ) + 1.
+
+ ENDMETHOD. "remaining
+
+ METHOD take_int.
+
+ rv_int = lcl_zlib_convert=>bits_to_int( take_bits( iv_length ) ).
+
+ ENDMETHOD. "take_int
+
+ METHOD take_bits.
+
+ DATA: lv_left TYPE i,
+ lv_index TYPE i,
+ lv_x TYPE x LENGTH 1.
+
+
+ WHILE strlen( rv_bits ) < iv_length.
+ IF mv_bits IS INITIAL.
+ lv_x = mv_compressed(1).
+ mv_bits = lcl_zlib_convert=>hex_to_bits( lv_x ).
+ mv_compressed = mv_compressed+1.
+ ENDIF.
+ lv_left = iv_length - strlen( rv_bits ).
+ IF lv_left >= strlen( mv_bits ).
+ CONCATENATE mv_bits rv_bits INTO rv_bits.
+ CLEAR mv_bits.
+ ELSE.
+ lv_index = strlen( mv_bits ) - lv_left.
+ CONCATENATE mv_bits+lv_index(lv_left) rv_bits INTO rv_bits.
+ mv_bits = mv_bits(lv_index).
+ ENDIF.
+
+ ENDWHILE.
+
+ ENDMETHOD. "take_bits
+
+ENDCLASS. "lcl_zlib_stream IMPLEMENTATION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib DEFINITION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib DEFINITION FINAL.
+
+ PUBLIC SECTION.
+ TYPES: BEGIN OF ty_decompress,
+ raw TYPE xstring,
+ compressed_len TYPE i,
+ END OF ty_decompress.
+
+ CLASS-METHODS:
+ decompress
+ IMPORTING iv_compressed TYPE xsequence
+ RETURNING VALUE(rs_data) TYPE ty_decompress.
+
+ PRIVATE SECTION.
+ CONSTANTS: c_maxdcodes TYPE i VALUE 30.
+
+ CLASS-DATA: gv_out TYPE xstring,
+ go_lencode TYPE REF TO lcl_zlib_huffman,
+ go_distcode TYPE REF TO lcl_zlib_huffman,
+ go_stream TYPE REF TO lcl_zlib_stream.
+
+ TYPES: BEGIN OF ty_pair,
+ length TYPE i,
+ distance TYPE i,
+ END OF ty_pair.
+
+ CLASS-METHODS:
+ decode
+ IMPORTING io_huffman TYPE REF TO lcl_zlib_huffman
+ RETURNING VALUE(rv_symbol) TYPE i,
+ map_length
+ IMPORTING iv_code TYPE i
+ RETURNING VALUE(rv_length) TYPE i,
+ map_distance
+ IMPORTING iv_code TYPE i
+ RETURNING VALUE(rv_distance) TYPE i,
+ dynamic,
+ fixed,
+ read_pair
+ IMPORTING iv_length TYPE i
+ RETURNING VALUE(rs_pair) TYPE ty_pair,
+ copy_out
+ IMPORTING is_pair TYPE ty_pair.
+
+ENDCLASS. "lcl_zlib DEFINITION
+
+*----------------------------------------------------------------------*
+* CLASS lcl_zlib IMPLEMENTATION
+*----------------------------------------------------------------------*
+*
+*----------------------------------------------------------------------*
+CLASS lcl_zlib IMPLEMENTATION.
+
+ METHOD decode.
+
+ DATA: lv_bit TYPE c LENGTH 1,
+ lv_len TYPE i,
+ lv_count TYPE i,
+ lv_code TYPE i,
+ lv_index TYPE i,
+ lv_first TYPE i,
+ lv_bits TYPE string.
+
+
+ DO lcl_zlib_huffman=>c_maxbits TIMES.
+ lv_len = sy-index.
+
+ lv_bit = go_stream->take_bits( 1 ).
+ CONCATENATE lv_bits lv_bit INTO lv_bits.
+ lv_code = lcl_zlib_convert=>bits_to_int( lv_bits ).
+ lv_count = io_huffman->get_count( lv_len ).
+
+ IF lv_code - lv_count < lv_first.
+ rv_symbol = io_huffman->get_symbol( lv_index + lv_code - lv_first + 1 ).
+ RETURN.
+ ENDIF.
+ lv_index = lv_index + lv_count.
+ lv_first = lv_first + lv_count.
+ lv_first = lv_first * 2.
+ ENDDO.
+
+ ENDMETHOD. "decode
+
+ METHOD fixed.
+
+ DATA: lt_lengths TYPE lcl_zlib_huffman=>ty_lengths.
+
+
+ DO 144 TIMES.
+ APPEND 8 TO lt_lengths.
+ ENDDO.
+ DO 112 TIMES.
+ APPEND 9 TO lt_lengths.
+ ENDDO.
+ DO 24 TIMES.
+ APPEND 7 TO lt_lengths.
+ ENDDO.
+ DO 8 TIMES.
+ APPEND 8 TO lt_lengths.
+ ENDDO.
+
+ CREATE OBJECT go_lencode
+ EXPORTING
+ it_lengths = lt_lengths.
+
+ CLEAR lt_lengths.
+ DO c_maxdcodes TIMES.
+ APPEND 5 TO lt_lengths.
+ ENDDO.
+
+ CREATE OBJECT go_distcode
+ EXPORTING
+ it_lengths = lt_lengths.
+
+ ENDMETHOD. "fixed
+
+ METHOD copy_out.
+
+* copy one byte at a time, it is not possible to copy using
+* string offsets, as it might copy data that does not exist
+* in mv_out yet
+
+ DATA: lv_distance TYPE i,
+ lv_index TYPE i,
+ lv_x TYPE x LENGTH 1.
+
+
+ lv_distance = xstrlen( gv_out ) - is_pair-distance.
+ DO is_pair-length TIMES.
+ lv_index = sy-index - 1 + lv_distance.
+ lv_x = gv_out+lv_index(1).
+ CONCATENATE gv_out lv_x INTO gv_out IN BYTE MODE.
+ ENDDO.
+
+ ENDMETHOD. "copy_out
+
+ METHOD dynamic.
+
+ DATA: lv_nlen TYPE i,
+ lv_ndist TYPE i,
+ lv_ncode TYPE i,
+ lv_index TYPE i,
+ lv_length TYPE i,
+ lv_symbol TYPE i,
+ lt_order TYPE TABLE OF i,
+ lt_lengths TYPE lcl_zlib_huffman=>ty_lengths,
+ lt_dists TYPE lcl_zlib_huffman=>ty_lengths.
+
+ FIELD-SYMBOLS: <lv_length> LIKE LINE OF lt_lengths.
+
+
+ APPEND 16 TO lt_order.
+ APPEND 17 TO lt_order.
+ APPEND 18 TO lt_order.
+ APPEND 0 TO lt_order.
+ APPEND 8 TO lt_order.
+ APPEND 7 TO lt_order.
+ APPEND 9 TO lt_order.
+ APPEND 6 TO lt_order.
+ APPEND 10 TO lt_order.
+ APPEND 5 TO lt_order.
+ APPEND 11 TO lt_order.
+ APPEND 4 TO lt_order.
+ APPEND 12 TO lt_order.
+ APPEND 3 TO lt_order.
+ APPEND 13 TO lt_order.
+ APPEND 2 TO lt_order.
+ APPEND 14 TO lt_order.
+ APPEND 1 TO lt_order.
+ APPEND 15 TO lt_order.
+
+ lv_nlen = go_stream->take_int( 5 ) + 257.
+ lv_ndist = go_stream->take_int( 5 ) + 1.
+ lv_ncode = go_stream->take_int( 4 ) + 4.
+
+ DO 19 TIMES.
+ APPEND 0 TO lt_lengths.
+ ENDDO.
+
+ DO lv_ncode TIMES.
+ READ TABLE lt_order INDEX sy-index INTO lv_index.
+ ASSERT sy-subrc = 0.
+ lv_index = lv_index + 1.
+ READ TABLE lt_lengths INDEX lv_index ASSIGNING <lv_length>.
+ ASSERT sy-subrc = 0.
+ <lv_length> = go_stream->take_int( 3 ).
+ ENDDO.
+
+ CREATE OBJECT go_lencode
+ EXPORTING
+ it_lengths = lt_lengths.
+
+ CLEAR lt_lengths.
+ WHILE lines( lt_lengths ) < lv_nlen + lv_ndist.
+ lv_symbol = decode( go_lencode ).
+
+ IF lv_symbol < 16.
+ APPEND lv_symbol TO lt_lengths.
+ ELSE.
+ lv_length = 0.
+ IF lv_symbol = 16.
+ READ TABLE lt_lengths INDEX lines( lt_lengths ) INTO lv_length.
+ ASSERT sy-subrc = 0.
+ lv_symbol = go_stream->take_int( 2 ) + 3.
+ ELSEIF lv_symbol = 17.
+ lv_symbol = go_stream->take_int( 3 ) + 3.
+ ELSE.
+ lv_symbol = go_stream->take_int( 7 ) + 11.
+ ENDIF.
+ DO lv_symbol TIMES.
+ APPEND lv_length TO lt_lengths.
+ ENDDO.
+ ENDIF.
+ ENDWHILE.
+
+ lt_dists = lt_lengths.
+ DELETE lt_lengths FROM lv_nlen + 1.
+ DELETE lt_dists TO lv_nlen.
+
+ CREATE OBJECT go_lencode
+ EXPORTING
+ it_lengths = lt_lengths.
+
+ CREATE OBJECT go_distcode
+ EXPORTING
+ it_lengths = lt_dists.
+
+ ENDMETHOD. "dynamic
+
+ METHOD read_pair.
+
+ DATA: lv_symbol TYPE i.
+
+
+ rs_pair-length = map_length( iv_length ).
+
+ lv_symbol = decode( go_distcode ).
+ rs_pair-distance = map_distance( lv_symbol ).
+
+ ENDMETHOD. "read_pair
+
+ METHOD map_distance.
+
+ DEFINE _distance.
+ rv_distance = go_stream->take_int( &1 ).
+ rv_distance = rv_distance + &2.
+ END-OF-DEFINITION.
+
+ CASE iv_code.
+ WHEN 0.
+ _distance 0 1.
+ WHEN 1.
+ _distance 0 2.
+ WHEN 2.
+ _distance 0 3.
+ WHEN 3.
+ _distance 0 4.
+ WHEN 4.
+ _distance 1 5.
+ WHEN 5.
+ _distance 1 7.
+ WHEN 6.
+ _distance 2 9.
+ WHEN 7.
+ _distance 2 13.
+ WHEN 8.
+ _distance 3 17.
+ WHEN 9.
+ _distance 3 25.
+ WHEN 10.
+ _distance 4 33.
+ WHEN 11.
+ _distance 4 49.
+ WHEN 12.
+ _distance 5 65.
+ WHEN 13.
+ _distance 5 97.
+ WHEN 14.
+ _distance 6 129.
+ WHEN 15.
+ _distance 6 193.
+ WHEN 16.
+ _distance 7 257.
+ WHEN 17.
+ _distance 7 385.
+ WHEN 18.
+ _distance 8 513.
+ WHEN 19.
+ _distance 8 769.
+ WHEN 20.
+ _distance 9 1025.
+ WHEN 21.
+ _distance 9 1537.
+ WHEN 22.
+ _distance 10 2049.
+ WHEN 23.
+ _distance 10 3073.
+ WHEN 24.
+ _distance 11 4097.
+ WHEN 25.
+ _distance 11 6145.
+ WHEN 26.
+ _distance 12 8193.
+ WHEN 27.
+ _distance 12 12289.
+ WHEN 28.
+ _distance 13 16385.
+ WHEN 29.
+ _distance 13 24577.
+ WHEN OTHERS.
+ ASSERT 1 = 0.
+ ENDCASE.
+
+ ENDMETHOD. "map_distance
+
+ METHOD map_length.
+
+ DEFINE _length.
+ rv_length = go_stream->take_int( &1 ).
+ rv_length = rv_length + &2.
+ END-OF-DEFINITION.
+
+ CASE iv_code.
+ WHEN 257.
+ _length 0 3.
+ WHEN 258.
+ _length 0 4.
+ WHEN 259.
+ _length 0 5.
+ WHEN 260.
+ _length 0 6.
+ WHEN 261.
+ _length 0 7.
+ WHEN 262.
+ _length 0 8.
+ WHEN 263.
+ _length 0 9.
+ WHEN 264.
+ _length 0 10.
+ WHEN 265.
+ _length 1 11.
+ WHEN 266.
+ _length 1 13.
+ WHEN 267.
+ _length 1 15.
+ WHEN 268.
+ _length 1 17.
+ WHEN 269.
+ _length 2 19.
+ WHEN 270.
+ _length 2 23.
+ WHEN 271.
+ _length 2 27.
+ WHEN 272.
+ _length 2 31.
+ WHEN 273.
+ _length 3 35.
+ WHEN 274.
+ _length 3 43.
+ WHEN 275.
+ _length 3 51.
+ WHEN 276.
+ _length 3 59.
+ WHEN 277.
+ _length 4 67.
+ WHEN 278.
+ _length 4 83.
+ WHEN 279.
+ _length 4 99.
+ WHEN 280.
+ _length 4 115.
+ WHEN 281.
+ _length 5 131.
+ WHEN 282.
+ _length 5 163.
+ WHEN 283.
+ _length 5 195.
+ WHEN 284.
+ _length 5 227.
+ WHEN 285.
+ _length 0 258.
+ WHEN OTHERS.
+ ASSERT 1 = 0.
+ ENDCASE.
+
+ ENDMETHOD. "map_length
+
+ METHOD decompress.
+
+ DATA: lv_x TYPE x LENGTH 1,
+ lv_symbol TYPE i,
+ lv_bfinal TYPE c LENGTH 1,
+ lv_btype TYPE c LENGTH 2.
+
+
+ IF iv_compressed IS INITIAL.
+ RETURN.
+ ENDIF.
+
+ CLEAR gv_out.
+ CREATE OBJECT go_stream
+ EXPORTING
+ iv_data = iv_compressed.
+
+ DO.
+ lv_bfinal = go_stream->take_bits( 1 ).
+
+ lv_btype = go_stream->take_bits( 2 ).
+ CASE lv_btype.
+ WHEN '01'.
+ fixed( ).
+ WHEN '10'.
+ dynamic( ).
+ WHEN OTHERS.
+ ASSERT 1 = 0.
+ ENDCASE.
+
+ DO.
+ lv_symbol = decode( go_lencode ).
+
+ IF lv_symbol < 256.
+ lv_x = lcl_zlib_convert=>int_to_hex( lv_symbol ).
+ CONCATENATE gv_out lv_x INTO gv_out IN BYTE MODE.
+ ELSEIF lv_symbol = 256.
+ EXIT.
+ ELSE.
+ copy_out( read_pair( lv_symbol ) ).
+ ENDIF.
+
+ ENDDO.
+
+ IF lv_bfinal = '1'.
+ EXIT.
+ ENDIF.
+
+ ENDDO.
+
+ rs_data-raw = gv_out.
+ rs_data-compressed_len = xstrlen( iv_compressed ) - go_stream->remaining( ).
+
+ ENDMETHOD. "decompress
+
+ENDCLASS. "lcl_zlib IMPLEMENTATION
+
+*----------------------------------------------------------------------*
* CLASS lcl_tadir DEFINITION
*----------------------------------------------------------------------*
*
@@ -214,13 +921,13 @@
CLASS-METHODS:
read
IMPORTING iv_package TYPE tadir-devclass
- RETURNING value(rt_tadir) TYPE tt_tadir
+ RETURNING VALUE(rt_tadir) TYPE tt_tadir
RAISING lcx_exception,
read_single
IMPORTING iv_pgmid TYPE tadir-pgmid DEFAULT 'R3TR'
iv_object TYPE tadir-object
iv_obj_name TYPE tadir-obj_name
- RETURNING value(rs_tadir) TYPE tadir.
+ RETURNING VALUE(rs_tadir) TYPE tadir.
PRIVATE SECTION.
CLASS-METHODS:
@@ -228,7 +935,7 @@
IMPORTING iv_package TYPE tadir-devclass
iv_parent TYPE tadir-devclass
iv_path TYPE string
- RETURNING value(rt_tadir) TYPE tt_tadir
+ RETURNING VALUE(rt_tadir) TYPE tt_tadir
RAISING lcx_exception.
ENDCLASS. "lcl_tadir DEFINITION
@@ -345,7 +1052,7 @@
RAISING lcx_exception.
CLASS-METHODS get_username
- RETURNING value(rv_username) TYPE string
+ RETURNING VALUE(rv_username) TYPE string
RAISING lcx_exception.
CLASS-METHODS set_email
@@ -353,13 +1060,13 @@
RAISING lcx_exception.
CLASS-METHODS get_email
- RETURNING value(rv_email) TYPE string
+ RETURNING VALUE(rv_email) TYPE string
RAISING lcx_exception.
PRIVATE SECTION.
CLASS-METHODS read
IMPORTING iv_name TYPE tdobname
- RETURNING value(rv_value) TYPE string
+ RETURNING VALUE(rv_value) TYPE string
RAISING lcx_exception.
CLASS-METHODS save
@@ -549,11 +1256,11 @@
METHODS xml_render
IMPORTING iv_normalize TYPE sap_bool DEFAULT abap_true
- RETURNING value(rv_string) TYPE string.
+ RETURNING VALUE(rv_string) TYPE string.
METHODS xml_element
IMPORTING iv_name TYPE string
- RETURNING value(ri_element) TYPE REF TO if_ixml_element.
+ RETURNING VALUE(ri_element) TYPE REF TO if_ixml_element.
METHODS xml_add
IMPORTING ii_root TYPE REF TO if_ixml_element OPTIONAL
@@ -562,7 +1269,7 @@
METHODS xml_find
IMPORTING ii_root TYPE REF TO if_ixml_element OPTIONAL
iv_name TYPE string
- RETURNING value(ri_element) TYPE REF TO if_ixml_element.
+ RETURNING VALUE(ri_element) TYPE REF TO if_ixml_element.
PRIVATE SECTION.
@@ -1023,10 +1730,10 @@
IMPORTING iv_message TYPE string.
CLASS-METHODS get_html
- RETURNING value(rv_html) TYPE string.
+ RETURNING VALUE(rv_html) TYPE string.
CLASS-METHODS get_debug
- RETURNING value(rv_debug) TYPE sap_bool.
+ RETURNING VALUE(rv_debug) TYPE sap_bool.
CLASS-METHODS clear.
@@ -1128,7 +1835,7 @@
PUBLIC SECTION.
CLASS-METHODS get
- RETURNING value(rv_time) TYPE t_unixtime
+ RETURNING VALUE(rv_time) TYPE t_unixtime
RAISING lcx_exception.
PRIVATE SECTION.
@@ -1200,17 +1907,17 @@
PUBLIC SECTION.
CLASS-METHODS host
IMPORTING iv_repo TYPE string
- RETURNING value(rv_host) TYPE string
+ RETURNING VALUE(rv_host) TYPE string
RAISING lcx_exception.
CLASS-METHODS name
IMPORTING iv_repo TYPE string
- RETURNING value(rv_name) TYPE string
+ RETURNING VALUE(rv_name) TYPE string
RAISING lcx_exception.
CLASS-METHODS path_name
IMPORTING iv_repo TYPE string
- RETURNING value(rv_path_name) TYPE string
+ RETURNING VALUE(rv_path_name) TYPE string
RAISING lcx_exception.
PRIVATE SECTION.
@@ -1275,29 +1982,29 @@
PUBLIC SECTION.
CLASS-METHODS bitbyte_to_int
IMPORTING iv_bits TYPE clike
- RETURNING value(rv_int) TYPE i.
+ RETURNING VALUE(rv_int) TYPE i.
CLASS-METHODS x_to_bitbyte
IMPORTING iv_x TYPE x
- RETURNING value(rv_bitbyte) TYPE t_bitbyte.
+ RETURNING VALUE(rv_bitbyte) TYPE t_bitbyte.
CLASS-METHODS string_to_xstring_utf8
IMPORTING iv_string TYPE string
- RETURNING value(rv_xstring) TYPE xstring.
+ RETURNING VALUE(rv_xstring) TYPE xstring.
CLASS-METHODS xstring_to_string_utf8
IMPORTING iv_data TYPE xstring
- RETURNING value(rv_string) TYPE string.
+ RETURNING VALUE(rv_string) TYPE string.
CLASS-METHODS xstring_to_int
IMPORTING iv_xstring TYPE xstring
- RETURNING value(rv_i) TYPE i
+ RETURNING VALUE(rv_i) TYPE i
RAISING lcx_exception.
CLASS-METHODS int_to_xstring
IMPORTING iv_i TYPE i
iv_length TYPE i
- RETURNING value(rv_xstring) TYPE xstring.
+ RETURNING VALUE(rv_xstring) TYPE xstring.
ENDCLASS. "lcl_convert DEFINITION
@@ -1444,10 +2151,10 @@
iv_remote TYPE xstring.
METHODS get
- RETURNING value(rt_diff) TYPE tt_diffs.
+ RETURNING VALUE(rt_diff) TYPE tt_diffs.
METHODS count
- RETURNING value(rs_count) TYPE st_count.
+ RETURNING VALUE(rs_count) TYPE st_count.
PRIVATE SECTION.
DATA mt_diff TYPE tt_diffs.
@@ -1462,12 +2169,12 @@
IMPORTING it_local TYPE abaptxt255_tab
it_remote TYPE abaptxt255_tab
it_delta TYPE vxabapt255_tab
- RETURNING value(rt_diff) TYPE tt_diffs.
+ RETURNING VALUE(rt_diff) TYPE tt_diffs.
CLASS-METHODS: compute
IMPORTING it_local TYPE abaptxt255_tab
it_remote TYPE abaptxt255_tab
- RETURNING value(rt_delta) TYPE vxabapt255_tab.
+ RETURNING VALUE(rt_delta) TYPE vxabapt255_tab.
ENDCLASS. "lcl_diff DEFINITION
@@ -1626,7 +2333,7 @@
CLASS-METHODS:
check IMPORTING it_results TYPE tt_results
iv_top TYPE devclass
- RETURNING value(rv_errors) TYPE string,
+ RETURNING VALUE(rv_errors) TYPE string,
create.
PRIVATE SECTION.
@@ -1636,7 +2343,7 @@
iv_top TYPE devclass
iv_package TYPE devclass
RETURNING
- value(rv_path) TYPE string.
+ VALUE(rv_path) TYPE string.
ENDCLASS. "lcl_package DEFINITION
@@ -1793,14 +2500,14 @@
iv_extra TYPE clike OPTIONAL
io_xml TYPE REF TO lcl_xml
iv_normalize TYPE sap_bool DEFAULT abap_true
- RETURNING value(rs_file) TYPE st_file
+ RETURNING VALUE(rs_file) TYPE st_file
RAISING lcx_exception.
CLASS-METHODS read_xml
IMPORTING is_item TYPE st_item
iv_extra TYPE clike OPTIONAL
it_files TYPE tt_files
- RETURNING value(ro_xml) TYPE REF TO lcl_xml
+ RETURNING VALUE(ro_xml) TYPE REF TO lcl_xml
RAISING lcx_exception.
CLASS-METHODS read_abap
@@ -1815,7 +2522,7 @@
IMPORTING is_item TYPE st_item
iv_extra TYPE clike OPTIONAL
it_abap TYPE STANDARD TABLE
- RETURNING value(rs_file) TYPE st_file
+ RETURNING VALUE(rs_file) TYPE st_file
RAISING lcx_exception.
CLASS-METHODS activation_add
@@ -1836,13 +2543,13 @@
CLASS-METHODS read_progdir
IMPORTING iv_program TYPE programm
- RETURNING value(rs_progdir) TYPE ty_progdir.
+ RETURNING VALUE(rs_progdir) TYPE ty_progdir.
CLASS-METHODS serialize_program
IMPORTING is_item TYPE st_item
iv_program TYPE programm OPTIONAL
iv_extra TYPE clike OPTIONAL
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize_program
@@ -1857,7 +2564,7 @@
IMPORTING is_item TYPE st_item
iv_extra TYPE clike OPTIONAL
iv_ext TYPE string
- RETURNING value(rv_filename) TYPE string.
+ RETURNING VALUE(rv_filename) TYPE string.
CLASS-METHODS serialize_dynpros
IMPORTING iv_program_name TYPE programm
@@ -2466,7 +3173,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -2628,7 +3335,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -2778,7 +3485,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -2815,36 +3522,36 @@
CLASS-METHODS exists
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rv_exists) TYPE sap_bool.
+ RETURNING VALUE(rv_exists) TYPE sap_bool.
CLASS-METHODS serialize_abap
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rt_source) TYPE tt_string
+ RETURNING VALUE(rt_source) TYPE tt_string
RAISING lcx_exception.
CLASS-METHODS serialize_locals_imp
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rt_source) TYPE tt_string
+ RETURNING VALUE(rt_source) TYPE tt_string
RAISING lcx_exception.
CLASS-METHODS serialize_locals_def
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rt_source) TYPE tt_string
+ RETURNING VALUE(rt_source) TYPE tt_string
RAISING lcx_exception.
CLASS-METHODS serialize_testclasses
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rt_source) TYPE tt_string
+ RETURNING VALUE(rt_source) TYPE tt_string
RAISING lcx_exception.
CLASS-METHODS serialize_macros
IMPORTING is_clskey TYPE seoclskey
- RETURNING value(rt_source) TYPE tt_string
+ RETURNING VALUE(rt_source) TYPE tt_string
RAISING lcx_exception.
CLASS-METHODS serialize_xml
IMPORTING is_item TYPE st_item
- RETURNING value(ro_xml) TYPE REF TO lcl_xml
+ RETURNING VALUE(ro_xml) TYPE REF TO lcl_xml
RAISING lcx_exception.
CLASS-METHODS remove_signatures
@@ -3477,7 +4184,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -3497,19 +4204,19 @@
PRIVATE SECTION.
CLASS-METHODS get_filename
IMPORTING iv_url TYPE string
- RETURNING value(rv_filename) TYPE string.
+ RETURNING VALUE(rv_filename) TYPE string.
CLASS-METHODS find_content
IMPORTING is_item TYPE st_item
it_files TYPE tt_files
iv_url TYPE string
- RETURNING value(rv_content) TYPE xstring
+ RETURNING VALUE(rv_content) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS build_filename
IMPORTING is_item TYPE st_item
iv_filename TYPE string
- RETURNING value(rv_filename) TYPE string.
+ RETURNING VALUE(rv_filename) TYPE string.
CLASS-METHODS get_url_for_io
IMPORTING iv_loio TYPE sdok_docid
@@ -3793,7 +4500,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -3842,11 +4549,11 @@
CLASS-METHODS to_icfhndlist
IMPORTING it_list TYPE tt_icfhandler
- RETURNING value(rt_list) TYPE icfhndlist.
+ RETURNING VALUE(rt_list) TYPE icfhndlist.
CLASS-METHODS find_parent
IMPORTING iv_url TYPE string
- RETURNING value(rv_parent) TYPE icfparguid
+ RETURNING VALUE(rv_parent) TYPE icfparguid
RAISING lcx_exception.
ENDCLASS. "lcl_object_sicf DEFINITION
@@ -4190,7 +4897,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -4388,7 +5095,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -4417,7 +5124,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -4443,22 +5150,22 @@
CLASS-METHODS:
get_limu_objects
IMPORTING is_item TYPE st_item
- RETURNING value(rt_objects) TYPE wdy_md_transport_keys,
+ RETURNING VALUE(rt_objects) TYPE wdy_md_transport_keys,
read
IMPORTING is_item TYPE st_item
- RETURNING value(rs_component) TYPE wdy_component_metadata
+ RETURNING VALUE(rs_component) TYPE wdy_component_metadata
RAISING lcx_exception,
read_controller
IMPORTING is_key TYPE wdy_md_controller_key
- RETURNING value(rs_controller) TYPE wdy_md_controller_meta_data
+ RETURNING VALUE(rs_controller) TYPE wdy_md_controller_meta_data
RAISING lcx_exception,
read_definition
IMPORTING is_key TYPE wdy_md_component_key
- RETURNING value(rs_definition) TYPE wdy_md_component_meta_data
+ RETURNING VALUE(rs_definition) TYPE wdy_md_component_meta_data
RAISING lcx_exception,
read_view
IMPORTING is_key TYPE wdy_md_view_key
- RETURNING value(rs_view) TYPE wdy_md_view_meta_data
+ RETURNING VALUE(rs_view) TYPE wdy_md_view_meta_data
RAISING lcx_exception,
recover_controller
IMPORTING is_controller TYPE wdy_md_controller_meta_data
@@ -4471,15 +5178,15 @@
RAISING lcx_exception,
delta_controller
IMPORTING is_controller TYPE wdy_md_controller_meta_data
- RETURNING value(rs_delta) TYPE svrs2_xversionable_object
+ RETURNING VALUE(rs_delta) TYPE svrs2_xversionable_object
RAISING lcx_exception,
delta_definition
IMPORTING is_definition TYPE wdy_md_component_meta_data
- RETURNING value(rs_delta) TYPE svrs2_xversionable_object
+ RETURNING VALUE(rs_delta) TYPE svrs2_xversionable_object
RAISING lcx_exception,
delta_view
IMPORTING is_view TYPE wdy_md_view_meta_data
- RETURNING value(rs_delta) TYPE svrs2_xversionable_object
+ RETURNING VALUE(rs_delta) TYPE svrs2_xversionable_object
RAISING lcx_exception.
ENDCLASS. "lcl_object_wdyn DEFINITION
@@ -5072,7 +5779,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -5270,7 +5977,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -5470,7 +6177,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -5727,7 +6434,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -5934,7 +6641,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -6078,7 +6785,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -6314,7 +7021,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -6585,7 +7292,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -6781,7 +7488,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -6943,7 +7650,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -7115,7 +7822,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -7334,7 +8041,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -7501,7 +8208,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -7667,7 +8374,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -7687,22 +8394,22 @@
PRIVATE SECTION.
CLASS-METHODS main_name
IMPORTING is_item TYPE st_item
- RETURNING value(rv_program) TYPE program
+ RETURNING VALUE(rv_program) TYPE program
RAISING lcx_exception.
CLASS-METHODS functions
IMPORTING is_item TYPE st_item
- RETURNING value(rt_functab) TYPE tt_rs38l_incl
+ RETURNING VALUE(rt_functab) TYPE tt_rs38l_incl
RAISING lcx_exception.
CLASS-METHODS includes
IMPORTING is_item TYPE st_item
- RETURNING value(rt_includes) TYPE rso_t_objnm
+ RETURNING VALUE(rt_includes) TYPE rso_t_objnm
RAISING lcx_exception.
CLASS-METHODS serialize_functions
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize_functions
@@ -7712,7 +8419,7 @@
CLASS-METHODS serialize_xml
IMPORTING is_item TYPE st_item
- RETURNING value(rs_file) TYPE st_file
+ RETURNING VALUE(rs_file) TYPE st_file
RAISING lcx_exception.
CLASS-METHODS deserialize_xml
@@ -7723,7 +8430,7 @@
CLASS-METHODS serialize_includes
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize_includes
@@ -8021,15 +8728,15 @@
CALL FUNCTION 'RS_GET_ALL_INCLUDES'
EXPORTING
- program = lv_program
+ program = lv_program
* WITH_RESERVED_INCLUDES =
* WITH_CLASS_INCLUDES = ' ' hmm, todo
TABLES
- includetab = rt_includes
+ includetab = rt_includes
EXCEPTIONS
- not_existent = 1
- no_program = 2
- OTHERS = 3.
+ not_existent = 1
+ no_program = 2
+ OTHERS = 3.
IF sy-subrc <> 0.
_raise 'Error from RS_GET_ALL_INCLUDES'.
ENDIF.
@@ -8323,7 +9030,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -8515,7 +9222,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -8675,7 +9382,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -8835,7 +9542,7 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -9131,13 +9838,13 @@
PUBLIC SECTION.
CLASS-METHODS serialize
IMPORTING is_item TYPE st_item
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS status
IMPORTING it_files TYPE tt_files
iv_package TYPE devclass OPTIONAL
- RETURNING value(rt_results) TYPE tt_results
+ RETURNING VALUE(rt_results) TYPE tt_results
RAISING lcx_exception.
CLASS-METHODS deserialize
@@ -9155,7 +9862,7 @@
CLASS-METHODS class_name
IMPORTING is_item TYPE st_item
- RETURNING value(rv_class_name) TYPE string.
+ RETURNING VALUE(rv_class_name) TYPE string.
PRIVATE SECTION.
CLASS-METHODS resolve_tabl
@@ -9165,7 +9872,7 @@
CLASS-METHODS check_warning
IMPORTING is_item TYPE st_item
iv_package TYPE devclass
- RETURNING value(rv_cancel) TYPE abap_bool
+ RETURNING VALUE(rv_cancel) TYPE abap_bool
RAISING lcx_exception.
CLASS-METHODS update_package_tree
@@ -9178,7 +9885,7 @@
CLASS-METHODS compare_files
IMPORTING it_repo TYPE tt_files
is_gen TYPE st_file
- RETURNING value(rv_match) TYPE sap_bool
+ RETURNING VALUE(rv_match) TYPE sap_bool
RAISING lcx_exception.
CLASS-METHODS show_progress
@@ -9729,17 +10436,17 @@
PUBLIC SECTION.
CLASS-METHODS adler32
IMPORTING iv_xstring TYPE xstring
- RETURNING value(rv_checksum) TYPE t_adler32.
+ RETURNING VALUE(rv_checksum) TYPE t_adler32.
CLASS-METHODS sha1
IMPORTING iv_type TYPE t_type
iv_data TYPE xstring
- RETURNING value(rv_sha1) TYPE t_sha1
+ RETURNING VALUE(rv_sha1) TYPE t_sha1
RAISING lcx_exception.
CLASS-METHODS sha1_raw
IMPORTING iv_data TYPE xstring
- RETURNING value(rv_sha1) TYPE t_sha1
+ RETURNING VALUE(rv_sha1) TYPE t_sha1
RAISING lcx_exception.
ENDCLASS. "lcl_hash DEFINITION
@@ -9844,12 +10551,12 @@
PUBLIC SECTION.
CLASS-METHODS decode
IMPORTING iv_data TYPE xstring
- RETURNING value(rt_objects) TYPE tt_objects
+ RETURNING VALUE(rt_objects) TYPE tt_objects
RAISING lcx_exception.
CLASS-METHODS decode_tree
IMPORTING iv_data TYPE xstring
- RETURNING value(rt_nodes) TYPE tt_nodes
+ RETURNING VALUE(rt_nodes) TYPE tt_nodes
RAISING lcx_exception.
CLASS-METHODS decode_deltas
@@ -9858,21 +10565,21 @@
CLASS-METHODS decode_commit
IMPORTING iv_data TYPE xstring
- RETURNING value(rs_commit) TYPE st_commit
+ RETURNING VALUE(rs_commit) TYPE st_commit
RAISING lcx_exception.
CLASS-METHODS encode
IMPORTING it_objects TYPE tt_objects
- RETURNING value(rv_data) TYPE xstring
+ RETURNING VALUE(rv_data) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS encode_tree
IMPORTING it_nodes TYPE tt_nodes
- RETURNING value(rv_data) TYPE xstring.
+ RETURNING VALUE(rv_data) TYPE xstring.
CLASS-METHODS encode_commit
IMPORTING is_commit TYPE st_commit
- RETURNING value(rv_data) TYPE xstring.
+ RETURNING VALUE(rv_data) TYPE xstring.
PRIVATE SECTION.
CONSTANTS: c_pack_start TYPE x LENGTH 4 VALUE '5041434B', " PACK
@@ -9883,7 +10590,7 @@
CLASS-METHODS type_and_length
IMPORTING is_object TYPE st_object
- RETURNING value(rv_xstring) TYPE xstring
+ RETURNING VALUE(rv_xstring) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS delta
@@ -9896,7 +10603,7 @@
CLASS-METHODS get_type
IMPORTING iv_x TYPE x
- RETURNING value(rv_type) TYPE t_type
+ RETURNING VALUE(rv_type) TYPE t_type
RAISING lcx_exception.
CLASS-METHODS get_length
@@ -10472,23 +11179,27 @@
* result when '7801'
* compressed data might be larger than origial so add 10, adding 10 is safe
* as package always ends with SHA1 checksum
- DO lv_expected + 10 TIMES.
- lv_compressed_len = sy-index.
-
- cl_abap_gzip=>decompress_binary(
- EXPORTING
- gzip_in = lv_data
- gzip_in_len = lv_compressed_len
- IMPORTING
- raw_out = lv_decompressed
- raw_out_len = lv_decompress_len ).
-
- IF lv_decompress_len = lv_expected.
- EXIT.
- ELSE.
- CLEAR lv_compressed_len.
- ENDIF.
- ENDDO.
+* DO lv_expected + 10 TIMES.
+* lv_compressed_len = sy-index.
+*
+* cl_abap_gzip=>decompress_binary(
+* EXPORTING
+* gzip_in = lv_data
+* gzip_in_len = lv_compressed_len
+* IMPORTING
+* raw_out = lv_decompressed
+* raw_out_len = lv_decompress_len ).
+*
+* IF lv_decompress_len = lv_expected.
+* EXIT.
+* ELSE.
+* CLEAR lv_compressed_len.
+* ENDIF.
+* ENDDO.
+ DATA: ls_data TYPE lcl_zlib=>ty_decompress.
+ ls_data = lcl_zlib=>decompress( lv_data ).
+ lv_compressed_len = ls_data-compressed_len.
+ lv_decompressed = ls_data-raw.
IF lv_compressed_len IS INITIAL.
_raise 'Decompression falied :o/'.
@@ -10592,7 +11303,7 @@
PUBLIC SECTION.
CLASS-METHODS list
- RETURNING value(rt_repos) TYPE tt_repos_persi
+ RETURNING VALUE(rt_repos) TYPE tt_repos_persi
RAISING lcx_exception.
CLASS-METHODS update
@@ -10617,7 +11328,7 @@
PRIVATE SECTION.
CLASS-METHODS read_text_online
- RETURNING value(rt_repos) TYPE tt_repos_persi
+ RETURNING VALUE(rt_repos) TYPE tt_repos_persi
RAISING lcx_exception.
CLASS-METHODS save_text_online
@@ -10625,10 +11336,10 @@
RAISING lcx_exception.
CLASS-METHODS header_online
- RETURNING value(rs_header) TYPE thead.
+ RETURNING VALUE(rs_header) TYPE thead.
CLASS-METHODS read_text_offline
- RETURNING value(rt_repos) TYPE tt_repos_persi
+ RETURNING VALUE(rt_repos) TYPE tt_repos_persi
RAISING lcx_exception.
CLASS-METHODS save_text_offline
@@ -10636,11 +11347,11 @@
RAISING lcx_exception.
CLASS-METHODS header_offline
- RETURNING value(rs_header) TYPE thead.
+ RETURNING VALUE(rs_header) TYPE thead.
CLASS-METHODS read_text
IMPORTING is_header TYPE thead
- RETURNING value(rt_lines) TYPE tlinetab
+ RETURNING VALUE(rt_lines) TYPE tlinetab
RAISING lcx_exception.
CLASS-METHODS save_text
@@ -10998,7 +11709,7 @@
PRIVATE SECTION.
CLASS-METHODS pkt_string
IMPORTING iv_string TYPE string
- RETURNING value(rv_pkt) TYPE string
+ RETURNING VALUE(rv_pkt) TYPE string
RAISING lcx_exception.
CLASS-METHODS find_branch
@@ -11014,11 +11725,11 @@
CLASS-METHODS length_utf8_hex
IMPORTING iv_data TYPE xstring
- RETURNING value(rv_len) TYPE i.
+ RETURNING VALUE(rv_len) TYPE i.
CLASS-METHODS parse_branch_list
IMPORTING iv_data TYPE string
- RETURNING value(rt_list) TYPE tt_branch_list
+ RETURNING VALUE(rt_list) TYPE tt_branch_list
RAISING lcx_exception.
CLASS-METHODS set_headers
@@ -11032,7 +11743,7 @@
RAISING lcx_exception.
CLASS-METHODS get_null
- RETURNING value(rv_c) TYPE char1.
+ RETURNING VALUE(rv_c) TYPE char1.
ENDCLASS. "lcl_transport DEFINITION
@@ -11468,17 +12179,17 @@
iv_obj_name TYPE tadir-obj_name.
CLASS-METHODS file_upload
- RETURNING value(rv_xstr) TYPE xstring
+ RETURNING VALUE(rv_xstr) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS decode_files
IMPORTING iv_xstr TYPE xstring
- RETURNING value(rt_files) TYPE tt_files
+ RETURNING VALUE(rt_files) TYPE tt_files
RAISING lcx_exception.
CLASS-METHODS filename
IMPORTING iv_str TYPE string
- RETURNING value(rv_filename) TYPE string
+ RETURNING VALUE(rv_filename) TYPE string
RAISING lcx_exception.
CLASS-METHODS file_download
@@ -11492,11 +12203,11 @@
CLASS-METHODS encode_files
IMPORTING it_files TYPE tt_files
- RETURNING value(rv_xstr) TYPE xstring
+ RETURNING VALUE(rv_xstr) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS get_message
- RETURNING value(rv_message) TYPE string
+ RETURNING VALUE(rv_message) TYPE string
RAISING lcx_exception.
ENDCLASS. "lcl_zip DEFINITION
@@ -11988,7 +12699,7 @@
IMPORTING is_repo TYPE st_repo
is_comment TYPE st_comment
it_files TYPE tt_files
- RETURNING value(rv_branch) TYPE t_sha1
+ RETURNING VALUE(rv_branch) TYPE t_sha1
RAISING lcx_exception.
PRIVATE SECTION.
@@ -12002,7 +12713,7 @@
CLASS-METHODS root_tree
IMPORTING it_objects TYPE tt_objects
iv_branch TYPE t_sha1
- RETURNING value(rt_nodes) TYPE tt_nodes
+ RETURNING VALUE(rt_nodes) TYPE tt_nodes
RAISING lcx_exception.
CLASS-METHODS receive_pack
@@ -12011,7 +12722,7 @@
it_nodes TYPE tt_nodes
it_files TYPE tt_files
iv_branch TYPE t_sha1
- RETURNING value(rv_branch) TYPE t_sha1
+ RETURNING VALUE(rv_branch) TYPE t_sha1
RAISING lcx_exception.
ENDCLASS. "lcl_porcelain DEFINITION
@@ -12254,35 +12965,35 @@
IMPORTING iv_html TYPE string.
CLASS-METHODS render
- RETURNING value(rv_html) TYPE string
+ RETURNING VALUE(rv_html) TYPE string
RAISING lcx_exception.
CLASS-METHODS render_css
- RETURNING value(rv_html) TYPE string.
+ RETURNING VALUE(rv_html) TYPE string.
CLASS-METHODS render_repo_online
IMPORTING is_repo_persi TYPE st_repo_persi
- RETURNING value(rv_html) TYPE string
+ RETURNING VALUE(rv_html) TYPE string
RAISING lcx_exception.
CLASS-METHODS render_repo_offline
IMPORTING is_repo_persi TYPE st_repo_persi
- RETURNING value(rv_html) TYPE string
+ RETURNING VALUE(rv_html) TYPE string
RAISING lcx_exception.
CLASS-METHODS repo_name
IMPORTING is_repo TYPE st_repo_persi
- RETURNING value(rv_name) TYPE string
+ RETURNING VALUE(rv_name) TYPE string
RAISING lcx_exception.
CLASS-METHODS render_header
- RETURNING value(rv_html) TYPE string.
+ RETURNING VALUE(rv_html) TYPE string.
CLASS-METHODS render_menu
- RETURNING value(rv_html) TYPE string.
+ RETURNING VALUE(rv_html) TYPE string.
CLASS-METHODS render_footer
- RETURNING value(rv_html) TYPE string.
+ RETURNING VALUE(rv_html) TYPE string.
CLASS-METHODS install
IMPORTING iv_url TYPE string
@@ -12324,7 +13035,7 @@
CLASS-METHODS struct_encode
IMPORTING ig_structure1 TYPE any
ig_structure2 TYPE any OPTIONAL
- RETURNING value(rv_string) TYPE string.
+ RETURNING VALUE(rv_string) TYPE string.
CLASS-METHODS struct_decode
IMPORTING iv_string TYPE clike
@@ -12332,11 +13043,11 @@
RAISING lcx_exception.
CLASS-METHODS popup_comment
- RETURNING value(rs_comment) TYPE st_comment
+ RETURNING VALUE(rs_comment) TYPE st_comment
RAISING lcx_exception.
CLASS-METHODS get_logo_src
- RETURNING value(rv_src) TYPE string.
+ RETURNING VALUE(rv_src) TYPE string.
CLASS-METHODS zipexport
RAISING lcx_exception.
|
|
3caea00f30c666df1e413073fd35d6e065fd51a1 | change delems from parse test to more generic ones | change delems from parse test to more generic ones
| sbcgua/abap_data_parser | 0 | mit | ABAP | --- zcl_data_parser.clas.testclasses.abap
+++ zcl_data_parser.clas.testclasses.abap
@@ -77,12 +77,12 @@
begin of ty_dummy,
mandt type mandt,
tdate type datum,
- tchar type veri_c08,
- traw type veri_x1,
+ tchar type char08,
+ traw type thraw1,
tstring type string,
talpha type veri_alpha,
- tdecimal type veri_cur13,
- tnumber type veri_n04,
+ tdecimal type dmbtr,
+ tnumber type numc04,
tinteger type i,
tfloat type float,
end of ty_dummy,
@@ -376,7 +376,7 @@
data: begin of wrong_struc ##NEEDED,
mandt type mandt,
tdate type datum,
- tchar type veri_c08,
+ tchar type char08,
end of wrong_struc.
data:
|
|
068cf963d9b5ab66d05dc7f4b0e029867beffd57 | ENHO: implement changed_by #1417 (#1436) | ENHO: implement changed_by #1417 (#1436)
| larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_enho.clas.abap
+++ src/objects/zcl_abapgit_object_enho.clas.abap
@@ -28,8 +28,43 @@
ENDMETHOD. "zif_abapgit_object~get_metadata
METHOD zif_abapgit_object~changed_by.
- rv_user = c_user_unknown. " todo
- ENDMETHOD. "zif_abapgit_object~changed_by
+
+ DATA: lv_enh_id TYPE enhname,
+ li_enho TYPE REF TO zif_abapgit_object_enho,
+ lt_log TYPE enh_log_it,
+ li_log_obj TYPE REF TO if_enh_log,
+ ls_enhlog TYPE enhlog,
+ lv_lines TYPE i,
+ lt_enhlog TYPE STANDARD TABLE OF enhlog WITH DEFAULT KEY,
+ li_enh_tool TYPE REF TO if_enh_tool.
+
+
+ lv_enh_id = ms_item-obj_name.
+ TRY.
+ li_enh_tool = cl_enh_factory=>get_enhancement(
+ enhancement_id = lv_enh_id
+ bypassing_buffer = abap_true ).
+ CATCH cx_enh_root.
+ rv_user = c_user_unknown.
+ RETURN.
+ ENDTRY.
+
+ lt_log = li_enh_tool->get_log( ).
+
+ LOOP AT lt_log INTO li_log_obj.
+ ls_enhlog = li_log_obj->get_enhlog( ).
+ APPEND ls_enhlog TO lt_enhlog.
+ ENDLOOP.
+
+ lv_lines = lines( lt_enhlog ).
+ READ TABLE lt_enhlog INTO ls_enhlog INDEX lv_lines.
+ IF sy-subrc = 0.
+ rv_user = ls_enhlog-loguser.
+ ELSE.
+ rv_user = c_user_unknown.
+ ENDIF.
+
+ ENDMETHOD.
METHOD zif_abapgit_object~exists.
|
|
155044e2a63d0f75d6067fc4ce88d7baf46424dc | GET_REPO_SHOW dont lookup empty key (#4550) | GET_REPO_SHOW dont lookup empty key (#4550)
if the key is empty, dont try looking it up | larshp/abapGit,larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/persist/zcl_abapgit_persistence_user.clas.abap
+++ src/persist/zcl_abapgit_persistence_user.clas.abap
@@ -268,6 +268,10 @@
rv_key = ms_user-repo_show.
+ IF rv_key IS INITIAL.
+ RETURN.
+ ENDIF.
+
" Check if repo exists
TRY.
lo_repo = zcl_abapgit_repo_srv=>get_instance( )->get( rv_key ).
|
|
2fc8087de17ec8d59227b0900952ff00900c0476 | In the popup for the creation of a new offline project the OK button is missing or better is there but without a text, it's a quite difficult to find it ;-) Fixed with label "OK" | In the popup for the creation of a new offline project the OK button is missing or better is there but without a text, it's a quite difficult to find it ;-)
Fixed with label "OK"
| larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/ui/zcl_abapgit_popups.clas.abap
+++ src/ui/zcl_abapgit_popups.clas.abap
@@ -903,7 +903,7 @@
popup_title = 'New Offline Project'
programname = sy-cprog
formname = 'PACKAGE_POPUP'
- ok_pushbuttontext = ''
+ ok_pushbuttontext = 'OK'
icon_ok_push = lv_icon_ok
first_pushbutton = lv_button1
icon_button_1 = lv_icon1
|
|
e2e703a0bddf5cf3d8b6b6acc82c8c4b0296437c | DOMA do not serialize texts without language #2311 | DOMA do not serialize texts without language #2311 | larshp/abapGit,EduardoCopat/abapGit,larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_doma.clas.abap
+++ src/objects/zcl_abapgit_object_doma.clas.abap
@@ -4,6 +4,7 @@
INTERFACES zif_abapgit_object.
ALIASES mo_files FOR zif_abapgit_object~mo_files.
+ PROTECTED SECTION.
PRIVATE SECTION.
TYPES: BEGIN OF ty_dd01_texts,
@@ -155,7 +156,7 @@
APPEND INITIAL LINE TO lt_dd01_texts ASSIGNING <ls_dd01_text>.
MOVE-CORRESPONDING ls_dd01v TO <ls_dd01_text>.
- LOOP AT lt_dd07v ASSIGNING <ls_dd07v>.
+ LOOP AT lt_dd07v ASSIGNING <ls_dd07v> WHERE NOT ddlanguage IS INITIAL.
APPEND INITIAL LINE TO lt_dd07_texts ASSIGNING <ls_dd07_text>.
MOVE-CORRESPONDING <ls_dd07v> TO <ls_dd07_text>.
ENDLOOP.
|
|
0d8b4dd7f548d462ffd11af0102e2c16736a93dc | WDCC: Fix syntax error on lower releases (#5005) | WDCC: Fix syntax error on lower releases (#5005)
| sbcgua/abapGit,larshp/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_wdcc.clas.abap
+++ src/objects/zcl_abapgit_object_wdcc.clas.abap
@@ -147,7 +147,7 @@
io_xml->read( EXPORTING iv_name = 'RELID'
CHANGING cg_data = ls_orig_config-relid ).
- SELECT SINGLE author createdon FROM wdy_config_data INTO ( ls_orig_config-author, ls_orig_config-createdon )
+ SELECT SINGLE author createdon FROM wdy_config_data INTO (ls_orig_config-author, ls_orig_config-createdon)
WHERE config_id = lv_config_id AND
config_type = lv_config_type AND
config_var = lv_config_var.
|
|
bd7313b4725f036ffcac177b1d43fd64d8abf82b | Delete PARA after DTEL, #1539 | Delete PARA after DTEL, #1539 | EduardoCopat/abapGit,sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/zcl_abapgit_dependencies.clas.abap
+++ src/zcl_abapgit_dependencies.clas.abap
@@ -114,6 +114,9 @@
ENDIF.
WHEN 'DTEL'.
<ls_tadir>-korrnum = '8000'.
+ WHEN 'PARA'.
+* PARA after DTEL
+ <ls_tadir>-korrnum = '8100'.
WHEN 'DOMA'.
<ls_tadir>-korrnum = '9000'.
WHEN 'PROG'.
|
|
c573b94a57acb5d73940508a2b923d3b1ac96069 | ZCL_ABAPGIT_CONVERT additional unit tests (#3976) | ZCL_ABAPGIT_CONVERT additional unit tests (#3976)
| larshp/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/utils/zcl_abapgit_convert.clas.testclasses.abap
+++ src/utils/zcl_abapgit_convert.clas.testclasses.abap
@@ -9,6 +9,10 @@
METHODS convert_int FOR TESTING RAISING zcx_abapgit_exception.
METHODS split_string FOR TESTING.
METHODS convert_bitbyte FOR TESTING RAISING zcx_abapgit_exception.
+ METHODS string_to_xstring_utf8 FOR TESTING.
+ METHODS xstring_to_string_utf8 FOR TESTING.
+ METHODS base64_to_xstring FOR TESTING.
+ METHODS conversion_exit_isola_output FOR TESTING.
METHODS alpha_output FOR TESTING.
ENDCLASS.
@@ -19,6 +23,54 @@
*
*----------------------------------------------------------------------*
CLASS ltcl_convert IMPLEMENTATION.
+
+ METHOD conversion_exit_isola_output.
+
+ DATA lv_laiso TYPE laiso.
+
+ lv_laiso = zcl_abapgit_convert=>conversion_exit_isola_output( 'E' ).
+
+ cl_abap_unit_assert=>assert_equals(
+ act = lv_laiso
+ exp = 'EN' ).
+
+ ENDMETHOD.
+
+ METHOD base64_to_xstring.
+
+ DATA lv_result TYPE xstring.
+
+ lv_result = zcl_abapgit_convert=>base64_to_xstring( 'YWJhcA==' ).
+
+ cl_abap_unit_assert=>assert_equals(
+ act = lv_result
+ exp = '61626170' ).
+
+ ENDMETHOD.
+
+ METHOD string_to_xstring_utf8.
+
+ DATA lv_result TYPE xstring.
+
+ lv_result = zcl_abapgit_convert=>string_to_xstring_utf8( 'abc' ).
+
+ cl_abap_unit_assert=>assert_equals(
+ act = lv_result
+ exp = '616263' ).
+
+ ENDMETHOD.
+
+ METHOD xstring_to_string_utf8.
+
+ DATA lv_result TYPE string.
+
+ lv_result = zcl_abapgit_convert=>xstring_to_string_utf8( '616263' ).
+
+ cl_abap_unit_assert=>assert_equals(
+ act = lv_result
+ exp = 'abc' ).
+
+ ENDMETHOD.
METHOD alpha_output.
|
|
8dc1156d75484152deba45a45b8b7051ad9dfb07 | Apack migration, Suppress dialog (#4616) | Apack migration, Suppress dialog (#4616)
#4612 | sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/apack/zcl_abapgit_apack_migration.clas.abap
+++ src/apack/zcl_abapgit_apack_migration.clas.abap
@@ -115,19 +115,37 @@
ls_interface_properties-state = '1'.
ls_interface_properties-unicode = abap_true.
- CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE'
- EXPORTING
- devclass = '$TMP'
- CHANGING
- interface = ls_interface_properties
- EXCEPTIONS
- existing = 1
- is_class = 2
- db_error = 3
- component_error = 4
- no_access = 5
- other = 6
- OTHERS = 7.
+ TRY.
+ CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE'
+ EXPORTING
+ devclass = '$TMP'
+ suppress_dialog = abap_true " Parameter missing in 702
+ CHANGING
+ interface = ls_interface_properties
+ EXCEPTIONS
+ existing = 1
+ is_class = 2
+ db_error = 3
+ component_error = 4
+ no_access = 5
+ other = 6
+ OTHERS = 7.
+ CATCH cx_sy_dyn_call_param_not_found.
+ CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE'
+ EXPORTING
+ devclass = '$TMP'
+ CHANGING
+ interface = ls_interface_properties
+ EXCEPTIONS
+ existing = 1
+ is_class = 2
+ db_error = 3
+ component_error = 4
+ no_access = 5
+ other = 6
+ OTHERS = 7.
+ ENDTRY.
+
IF sy-subrc <> 0.
zcx_abapgit_exception=>raise_t100( ).
ENDIF.
|
|
73b5ddc2766bbdb9632392c6c3c2960b1d9c72f5 | downport | downport | larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_objects_super.clas.abap
+++ src/objects/zcl_abapgit_objects_super.clas.abap
@@ -313,7 +313,6 @@
suppress_protocol = abap_false
with_program_includes = abap_false
suppress_dictionary_check = abap_false
- phased_activation = abap_false
TABLES
p_e071 = lt_e071_tadirs
p_xmsg = lt_messages.
|
|
5c65f3411d5fc52ea41c98ae0ac4faa029579bb4 | CHDO: clear UZEIT and UTIME dynamically (#3256) | CHDO: clear UZEIT and UTIME dynamically (#3256)
Co-authored-by: Lars Hvam <[email protected]> | sbcgua/abapGit,larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_chdo.clas.abap
+++ src/objects/zcl_abapgit_object_chdo.clas.abap
@@ -45,6 +45,12 @@
tt_change_document TYPE STANDARD TABLE OF ty_change_document.
DATA: mv_object TYPE cdobjectcl.
+ METHODS:
+ clear_field
+ IMPORTING
+ iv_fieldname TYPE string
+ CHANGING
+ cs_structure TYPE any.
ENDCLASS.
@@ -263,11 +269,37 @@
<ls_reports_generated>-author, <ls_reports_generated>-updname,
<ls_reports_generated>-devclass.
ENDLOOP.
+
LOOP AT ls_change_object-objects ASSIGNING <ls_objects>.
- CLEAR: <ls_objects>-udate, <ls_objects>-utime.
- ENDLOOP.
+
+ clear_field(
+ EXPORTING
+ iv_fieldname = |UDATE|
+ CHANGING
+ cs_structure = <ls_objects> ).
+
+ clear_field(
+ EXPORTING
+ iv_fieldname = |UTIME|
+ CHANGING
+ cs_structure = <ls_objects> ).
+
+ ENDLOOP.
+
LOOP AT ls_change_object-objects_text ASSIGNING <ls_objects_text>.
- CLEAR: <ls_objects_text>-udate, <ls_objects_text>-utime.
+
+ clear_field(
+ EXPORTING
+ iv_fieldname = |UDATE|
+ CHANGING
+ cs_structure = <ls_objects_text> ).
+
+ clear_field(
+ EXPORTING
+ iv_fieldname = |UTIME|
+ CHANGING
+ cs_structure = <ls_objects_text> ).
+
ENDLOOP.
io_xml->add( iv_name = 'CHDO'
@@ -425,4 +457,20 @@
ENDMETHOD.
+ METHOD clear_field.
+
+ FIELD-SYMBOLS: <lv_field> TYPE data.
+
+ ASSIGN
+ COMPONENT iv_fieldname
+ OF STRUCTURE cs_structure
+ TO <lv_field>.
+ IF sy-subrc <> 0.
+ RETURN. " Field is not available in lower NW versions
+ ENDIF.
+
+ CLEAR: <lv_field>.
+
+ ENDMETHOD.
+
ENDCLASS.
|
|
6733803e9705b0c5f01ebdec6a7edd94c62b2c28 | CSS styles | CSS styles
Stole a bit of the SAPUI5 bluecrystal theme.
| nununo/abapGit,larshp/abapGit,sbcgua/abapGit,nununo/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,apex8/abapGit,EduardoCopat/abapGit,apex8/abapGit,larshp/abapGit | 0 | mit | ABAP | --- zabapgit.abap
+++ zabapgit.abap
@@ -7841,7 +7841,7 @@
&& gc_newline &&
'</head>'
&& gc_newline &&
- '<body>'. "#EC NOTEXT
+ '<body style="background: rgba(222, 241, 242, 1);">' && gc_newline. "#EC NOTEXT
ENDMETHOD. "render_head
@@ -8470,7 +8470,8 @@
rv_html = '<style type="text/css">' && gc_newline &&
'body {' && gc_newline && "#EC NOTEXT
- ' font-family: verdana;' && gc_newline && "#EC NOTEXT
+ ' font-family: Arial,Helvetica,sans-serif;' && gc_newline && "#EC NOTEXT
+ ' background: #DEF1F2;' && gc_newline && "#EC NOTEXT
'}' && gc_newline &&
'a:link {' && gc_newline && "#EC NOTEXT
' color: blue;' && gc_newline && "#EC NOTEXT
@@ -8515,6 +8516,19 @@
'pre {' && gc_newline &&
' display: inline;' && gc_newline &&
'}' && gc_newline &&
+ 'table, th, td {' && gc_newline &&
+ ' border: 1px solid black;' && gc_newline &&
+ ' border-collapse: collapse;' && gc_newline &&
+ '}' && gc_newline &&
+ 'th, td {' && gc_newline &&
+ ' padding: 5px;' && gc_newline &&
+ '}' && gc_newline &&
+ 'th {' && gc_newline &&
+ ' background: #e5e5e5;' && gc_newline &&
+ '}' && gc_newline &&
+ 'td {' && gc_newline &&
+ ' background: #F8FCFC;' && gc_newline &&
+ '}' && gc_newline &&
'</style>' && gc_newline.
ENDMETHOD. "render_css
@@ -8651,10 +8665,10 @@
rv_html = rv_html && '<table border="1">' && gc_newline &&
'<tr>' && gc_newline &&
- '<td><u>Local object</u></td>' && gc_newline &&
- '<td></td>' && gc_newline &&
- '<td><u>Remote file</u></td>' && gc_newline &&
- '<td></td>' && gc_newline &&
+ '<th><u>Local object</u></th>' && gc_newline &&
+ '<th></td>' && gc_newline &&
+ '<th><u>Remote file</u></th>' && gc_newline &&
+ '<th></th>' && gc_newline &&
'</tr>' && gc_newline.
LOOP AT lt_results ASSIGNING <ls_result>.
|
|
0831569297befb023a064190bd9bc57f11aefb83 | new friendly progress indicators | new friendly progress indicators | larshp/abapGit,sbcgua/abapGit,nununo/abapGit,apex8/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,nununo/abapGit,larshp/abapGit,apex8/abapGit | 0 | mit | ABAP | --- zabapgit.prog.abap
+++ zabapgit.prog.abap
@@ -3,7 +3,7 @@
* See http://www.abapgit.org
CONSTANTS: gc_xml_version TYPE string VALUE 'v1.0.0', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v1.7.14'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v1.8.0'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
@@ -145,6 +145,107 @@
CLASS lcx_not_found IMPLEMENTATION.
ENDCLASS. "lcx_not_found IMPLEMENTATION
+
+CLASS lcl_progress DEFINITION.
+
+ PUBLIC SECTION.
+ CLASS-METHODS:
+ show
+ IMPORTING
+ iv_key TYPE string
+ VALUE(iv_current) TYPE i
+ iv_total TYPE i
+ iv_text TYPE csequence.
+
+ PRIVATE SECTION.
+ TYPES: BEGIN OF ty_stack,
+ key TYPE string,
+ current TYPE i,
+ total TYPE i,
+ text TYPE string,
+ END OF ty_stack.
+
+ CLASS-DATA:
+ gt_stack TYPE STANDARD TABLE OF ty_stack WITH DEFAULT KEY.
+
+ CLASS-METHODS:
+ calc_pct
+ RETURNING VALUE(rv_pct) TYPE i,
+ build_text
+ RETURNING VALUE(rv_text) TYPE string.
+
+ENDCLASS.
+
+CLASS lcl_progress IMPLEMENTATION.
+
+ METHOD show.
+
+ FIELD-SYMBOLS: <ls_stack> LIKE LINE OF gt_stack.
+
+* assumption:
+* all callers must end with calling this method with iv_current = iv_total
+* to clear the progress of that sub element
+ ASSERT lines( gt_stack ) < 10.
+
+ READ TABLE gt_stack INDEX lines( gt_stack ) ASSIGNING <ls_stack>.
+ IF sy-subrc <> 0 OR <ls_stack>-key <> iv_key.
+ APPEND INITIAL LINE TO gt_stack ASSIGNING <ls_stack>.
+ ENDIF.
+ <ls_stack>-key = iv_key.
+ <ls_stack>-current = iv_current.
+ <ls_stack>-total = iv_total.
+ <ls_stack>-text = iv_text.
+
+ CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
+ EXPORTING
+ percentage = calc_pct( )
+ text = build_text( ).
+
+ IF iv_current = iv_total.
+ DELETE gt_stack INDEX lines( gt_stack ).
+ ENDIF.
+
+ ENDMETHOD.
+
+ METHOD build_text.
+
+ FIELD-SYMBOLS: <ls_stack> LIKE LINE OF gt_stack.
+
+
+ LOOP AT gt_stack ASSIGNING <ls_stack>.
+ IF sy-tabix = 1.
+ rv_text = |{ <ls_stack>-key } { <ls_stack>-text }|.
+ ELSE.
+ rv_text = |{ rv_text } - { <ls_stack>-key } { <ls_stack>-text }|.
+
+ IF <ls_stack>-current <> 1 AND <ls_stack>-total <> 1.
+ rv_text = |{ rv_text } ({ <ls_stack>-current }/{ <ls_stack>-total })|.
+ ENDIF.
+ ENDIF.
+ ENDLOOP.
+
+ ENDMETHOD.
+
+ METHOD calc_pct.
+
+ DATA: lv_f TYPE f.
+
+ FIELD-SYMBOLS: <ls_stack> LIKE LINE OF gt_stack.
+
+
+ READ TABLE gt_stack ASSIGNING <ls_stack> INDEX 1.
+ ASSERT sy-subrc = 0.
+
+ lv_f = ( <ls_stack>-current / <ls_stack>-total ) * 100.
+ rv_pct = lv_f.
+
+ IF rv_pct = 100.
+ rv_pct = 99.
+ ENDIF.
+
+ ENDMETHOD.
+
+ENDCLASS.
CLASS lcl_log DEFINITION.
@@ -12553,9 +12654,8 @@
RETURNING VALUE(rv_name) TYPE string
RAISING lcx_exception,
get_files_local
- IMPORTING io_log TYPE REF TO lcl_log OPTIONAL
- iv_show_progress TYPE abap_bool DEFAULT abap_false
- RETURNING VALUE(rt_files) TYPE ty_files_tt
+ IMPORTING io_log TYPE REF TO lcl_log OPTIONAL
+ RETURNING VALUE(rt_files) TYPE ty_files_tt
RAISING lcx_exception,
get_files_remote
RETURNING VALUE(rt_files) TYPE ty_files_tt
@@ -12577,11 +12677,6 @@
mt_remote TYPE ty_files_tt,
ms_data TYPE lcl_persistence_repo=>ty_repo.
- CLASS-METHODS show_progress
- IMPORTING iv_current TYPE i
- iv_total TYPE i
- iv_obj_name TYPE tadir-obj_name.
-
ENDCLASS. "lcl_repo DEFINITION
*----------------------------------------------------------------------*
@@ -12654,11 +12749,6 @@
CLASS-METHODS delete_obj
IMPORTING is_item TYPE ty_item
RAISING lcx_exception.
-
- CLASS-METHODS show_progress
- IMPORTING iv_current TYPE i
- iv_total TYPE i
- iv_obj_name TYPE tadir-obj_name.
ENDCLASS. "lcl_object DEFINITION
@@ -12836,6 +12926,11 @@
LOOP AT it_files ASSIGNING <ls_file>.
+ lcl_progress=>show( iv_key = 'Status'
+ iv_current = sy-tabix
+ iv_total = lines( it_files )
+ iv_text = <ls_file>-filename ) ##NO_TEXT.
+
SPLIT <ls_file>-filename AT '.' INTO lv_pre lv_type lv_ext.
TRANSLATE lv_pre TO UPPER CASE.
TRANSLATE lv_type TO UPPER CASE.
@@ -13157,21 +13252,6 @@
*----------------------------------------------------------------------*
CLASS lcl_objects IMPLEMENTATION.
- METHOD show_progress.
-
- DATA: lv_pct TYPE i,
- lv_f TYPE f.
-
-
- lv_f = ( iv_current / iv_total ) * 100.
- lv_pct = lv_f.
- CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
- EXPORTING
- percentage = lv_pct
- text = iv_obj_name.
-
- ENDMETHOD. "show_progress
-
METHOD check_warning.
DATA: lv_question TYPE c LENGTH 200,
@@ -13613,9 +13693,10 @@
lt_results = prioritize_deser( lt_results ).
LOOP AT lt_results ASSIGNING <ls_result>.
- show_progress( iv_current = sy-tabix
- iv_total = lines( lt_results )
- iv_obj_name = <ls_result>-obj_name ).
+ lcl_progress=>show( iv_key = 'Deserialize'
+ iv_current = sy-tabix
+ iv_total = lines( lt_results )
+ iv_text = <ls_result>-obj_name ) ##NO_TEXT.
CLEAR ls_item.
ls_item-obj_type = <ls_result>-obj_type.
@@ -15343,6 +15424,11 @@
super->refresh( ).
+ lcl_progress=>show( iv_key = 'Fetch'
+ iv_current = 1
+ iv_total = 1
+ iv_text = 'Remote files' ) ##NO_TEXT.
+
lcl_git_porcelain=>pull( EXPORTING io_repo = me
IMPORTING et_files = mt_remote
et_objects = mt_objects
@@ -15438,23 +15524,6 @@
ENDMETHOD.
- METHOD show_progress.
-
- DATA: lv_pct TYPE i,
- lv_text TYPE string,
- lv_f TYPE f.
-
-
- lv_f = ( iv_current / iv_total ) * 100.
- lv_pct = lv_f.
- lv_text = |{ iv_obj_name } ({ iv_current }/{ iv_total })|.
- CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
- EXPORTING
- percentage = lv_pct
- text = lv_text.
-
- ENDMETHOD.
-
METHOD get_files_local.
DATA: lt_tadir TYPE lcl_tadir=>ty_tadir_tt,
@@ -15472,11 +15541,10 @@
lt_tadir = lcl_tadir=>read( get_package( ) ).
LOOP AT lt_tadir ASSIGNING <ls_tadir>.
- IF iv_show_progress = abap_true.
- show_progress( iv_current = sy-tabix
- iv_total = lines( lt_tadir )
- iv_obj_name = <ls_tadir>-obj_name ).
- ENDIF.
+ lcl_progress=>show( iv_key = 'Files'
+ iv_current = sy-tabix
+ iv_total = lines( lt_tadir )
+ iv_text = <ls_tadir>-obj_name ) ##NO_TEXT.
ls_item-obj_type = <ls_tadir>-object.
ls_item-obj_name = <ls_tadir>-obj_name.
@@ -16586,8 +16654,7 @@
CREATE OBJECT lo_log.
- lt_zip = lo_repo->get_files_local( io_log = lo_log
- iv_show_progress = abap_true ).
+ lt_zip = lo_repo->get_files_local( lo_log ).
IF lo_log->count( ) > 0.
lo_log->show( ).
@@ -17655,12 +17722,6 @@
CLASS-METHODS needs_installation
RETURNING VALUE(rv_not_completely_installed) TYPE abap_bool.
- CLASS-METHODS show_progress
- IMPORTING
- iv_current TYPE i
- iv_total TYPE i
- iv_text TYPE string.
-
ENDCLASS.
CLASS lcl_gui_page_diff DEFINITION FINAL.
@@ -19427,27 +19488,6 @@
ENDMETHOD.
- METHOD show_progress.
-
- DATA: lv_text TYPE c LENGTH 100,
- lv_pct TYPE i,
- lv_f TYPE f.
-
-
- lv_text = iv_text.
- lv_f = ( iv_current / iv_total ) * 100.
- lv_pct = lv_f.
- IF lv_pct = 100.
- lv_pct = 99.
- ENDIF.
-
- CALL FUNCTION 'SAPGUI_PROGRESS_INDICATOR'
- EXPORTING
- percentage = lv_pct
- text = lv_text.
-
- ENDMETHOD.
-
METHOD render_error.
CREATE OBJECT ro_html.
@@ -19499,9 +19539,10 @@
ro_html->add( render_explore( ) ).
ELSE.
LOOP AT lt_repos INTO lo_repo.
- show_progress( iv_current = sy-tabix
- iv_total = lines( lt_repos )
- iv_text = lo_repo->get_name( ) ).
+ lcl_progress=>show( iv_key = 'Render'
+ iv_current = sy-tabix
+ iv_total = lines( lt_repos )
+ iv_text = lo_repo->get_name( ) ) ##NO_TEXT.
IF lo_repo->is_offline( ) = abap_true.
lo_repo_offline ?= lo_repo.
@@ -21509,7 +21550,7 @@
lv_data = lo_db->read(
iv_type = ms_key-type
iv_value = ms_key-value ).
- CATCH lcx_not_found.
+ CATCH lcx_not_found ##NO_HANDLER.
ENDTRY.
lv_data = lcl_xml_pretty=>print( lv_data ).
@@ -21625,7 +21666,7 @@
lv_data = lo_db->read(
iv_type = ms_key-type
iv_value = ms_key-value ).
- CATCH lcx_not_found.
+ CATCH lcx_not_found ##NO_HANDLER.
ENDTRY.
lo_db->lock(
|
|
17af91de8e8ba4082ce7ae9f38a90560cdb978f8 | new design, toc, #202 | new design, toc, #202 | apex8/abapGit,apex8/abapGit,larshp/abapGit,sbcgua/abapGit,larshp/abapGit,EduardoCopat/abapGit,nununo/abapGit,nununo/abapGit,sbcgua/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- zabapgit.prog.abap
+++ zabapgit.prog.abap
@@ -3,7 +3,7 @@
* See http://www.abapgit.org
CONSTANTS: gc_xml_version TYPE string VALUE 'v1.0.0', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v1.4.5'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v1.4.6'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
@@ -14647,8 +14647,8 @@
TYPES: ty_value TYPE c LENGTH 12.
TYPES: BEGIN OF ty_content,
- type TYPE ty_type,
- value TYPE ty_value,
+ type TYPE ty_type,
+ value TYPE ty_value,
data_str TYPE string,
END OF ty_content,
tt_content TYPE SORTED TABLE OF ty_content WITH UNIQUE KEY value.
@@ -16536,6 +16536,11 @@
' margin-top: 0.5em;' && gc_newline &&
' padding-bottom: 0.5em;' && gc_newline &&
' border-bottom: 3px double lightgrey;' && gc_newline &&
+ '}' && gc_newline &&
+ 'div#toc {' && gc_newline &&
+ ' display: block;' && gc_newline &&
+ ' background-color: #f2f2f2;' && gc_newline &&
+ ' padding: 1em;' && gc_newline &&
'}' && gc_newline &&
'.mixedbar {' && gc_newline &&
' width: 98%; /*IE7 compat5 mode workaround, OMG it so sucks!*/' && gc_newline &&
@@ -16852,6 +16857,11 @@
CLASS-METHODS render_menu
RETURNING VALUE(rv_html) TYPE string.
+ CLASS-METHODS render_toc
+ IMPORTING it_list TYPE lcl_repo_srv=>ty_repo_tt
+ RETURNING VALUE(rv_html) TYPE string
+ RAISING lcx_exception.
+
CLASS-METHODS install
IMPORTING iv_url TYPE string
RAISING lcx_exception.
@@ -18117,6 +18127,32 @@
ENDMETHOD.
+ METHOD render_toc.
+
+ DATA: lo_repo LIKE LINE OF it_list,
+ lv_class TYPE string.
+
+
+ rv_html = '<div id="toc">' && gc_newline &&
+ '<span class="menu">' && gc_newline.
+
+ LOOP AT it_list INTO lo_repo.
+ IF sy-tabix = lines( it_list ).
+ lv_class = ' class="menu_end"'.
+ ENDIF.
+
+ rv_html = rv_html &&
+ '<a' && lv_class && ' href="#' && lo_repo->get_name( ) &&'">' &&
+ lo_repo->get_name( ) &&
+ '</a> '.
+ ENDLOOP.
+
+ rv_html = rv_html &&
+ '</span>' && gc_newline &&
+ '</div>' && gc_newline.
+
+ ENDMETHOD.
+
METHOD lif_gui_page~render.
DATA: lt_repos TYPE lcl_repo_srv=>ty_repo_tt,
@@ -18127,14 +18163,9 @@
lt_repos = lcl_repo_srv=>list( ).
- rv_html = lcl_gui=>header( ) && render_menu( ).
-
- LOOP AT lt_repos INTO lo_repo.
- rv_html = rv_html &&
- '<a href="#' && lo_repo->get_name( ) &&'" class="grey">' &&
- lo_repo->get_name( ) &&
- '</a> '.
- ENDLOOP.
+ rv_html = lcl_gui=>header( ) &&
+ render_menu( ) &&
+ render_toc( lt_repos ).
IF lt_repos[] IS INITIAL.
rv_html = rv_html && '<br><a href="sapevent:explore">Explore</a> new projects'.
|
|
0cc10cd44ff502d4a0bffe7c13d65bd4b40d5e53 | SRVD: Downport (#3424) | SRVD: Downport (#3424)
Co-authored-by: Lars Hvam <[email protected]> | sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,larshp/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_srvb.clas.abap
+++ src/objects/zcl_abapgit_object_srvb.clas.abap
@@ -128,9 +128,10 @@
CREATE OBJECT li_object_data_model TYPE ('CL_SRVB_OBJECT_DATA').
li_object_data_model->set_data( <ls_service_binding> ).
- mi_persistence->save(
+ CALL METHOD mi_persistence->('SAVE')
+ EXPORTING
p_object_data = li_object_data_model
- p_access_mode = lv_access_mode ).
+ p_access_mode = lv_access_mode. " does not exist in 702
corr_insert( iv_package ).
|
|
1f49f7a76ded8c9612b7e42c4c2f973ff113cfb1 | Issue 3130: TYPE: Type Group/Pool isn't being recognized (#3131) | Issue 3130: TYPE: Type Group/Pool isn't being recognized (#3131)
* Create pull.yml
* Update zcl_abapgit_git_transport.clas.abap
* Update zcl_abapgit_git_transport.clas.abap
* Update pull.yml
* Delete pull.yml
* Remove select for exists check
Due to the language flag-specific select a type group/pool couldn't be found. Removed the select at all because the following FM also recognizes unexistent type groups/pools and sets sy-subrc to something <> 0.
* Fill description if available in login language
Co-authored-by: pull[bot] <f1b6a38c6b7dcc9fba4a07d134ffd8b2fc533614@users.noreply.github.com>
Co-authored-by: Lars Hvam <[email protected]>
| sbcgua/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_type.clas.abap
+++ src/objects/zcl_abapgit_object_type.clas.abap
@@ -11,8 +11,7 @@
METHODS read
EXPORTING ev_ddtext TYPE ddtypet-ddtext
et_source TYPE abaptxt255_tab
- RAISING zcx_abapgit_exception
- zcx_abapgit_not_found.
+ RAISING zcx_abapgit_not_found.
METHODS create
IMPORTING iv_ddtext TYPE ddtypet-ddtext
@@ -24,7 +23,7 @@
-CLASS ZCL_ABAPGIT_OBJECT_TYPE IMPLEMENTATION.
+CLASS zcl_abapgit_object_type IMPLEMENTATION.
METHOD create.
@@ -74,11 +73,8 @@
SELECT SINGLE ddtext FROM ddtypet
INTO ev_ddtext
- WHERE typegroup = ms_item-obj_name
- AND ddlanguage = mv_language.
- IF sy-subrc <> 0.
- RAISE EXCEPTION TYPE zcx_abapgit_not_found.
- ENDIF.
+ WHERE typegroup = ms_item-obj_name
+ AND ddlanguage = mv_language.
lv_typdname = ms_item-obj_name.
CALL FUNCTION 'TYPD_GET_OBJECT'
@@ -94,7 +90,7 @@
reps_not_exist = 2
OTHERS = 3.
IF sy-subrc <> 0.
- zcx_abapgit_exception=>raise( 'error from TYPD_GET_OBJECT' ).
+ RAISE EXCEPTION TYPE zcx_abapgit_not_found.
ENDIF.
ENDMETHOD.
@@ -166,7 +162,8 @@
TRY.
read( ).
rv_bool = abap_true.
- CATCH zcx_abapgit_not_found zcx_abapgit_exception.
+ CATCH zcx_abapgit_not_found
+ zcx_abapgit_exception.
rv_bool = abap_false.
ENDTRY.
|
|
15a6832f913229ba0b0b94f83f12b189549935cc | Indentation fixes | Indentation fixes | larshp/abapGit,larshp/abapGit,EduardoCopat/abapGit,apex8/abapGit,sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,apex8/abapGit | 0 | mit | ABAP | --- src/zabapgit_git.prog.abap
+++ src/zabapgit_git.prog.abap
@@ -152,8 +152,8 @@
CHANGING cv_data TYPE xstring.
CLASS-METHODS zlib_compress_length
- CHANGING cv_data TYPE xstring
- RAISING lcx_exception.
+ CHANGING cv_data TYPE xstring
+ RAISING lcx_exception.
ENDCLASS. "lcl_pack DEFINITION
@@ -969,9 +969,9 @@
IF lv_compressed(lv_compressed_len) <> lv_data(lv_compressed_len).
"Lets try with zlib before error in out for good
"This fixes issues with TFS 2017 and visualstudio.com Git repos
- zlib_compress_length( CHANGING cv_data = lv_data ).
+ zlib_compress_length( CHANGING cv_data = lv_data ).
ELSE.
- lv_data = lv_data+lv_compressed_len.
+ lv_data = lv_data+lv_compressed_len.
ENDIF.
ELSEIF lv_zlib = c_zlib_hmm.
|
|
d849b2ac4f1a6a4098fd658a09d747746c48f0af | Translations are deleted upon activation | Translations are deleted upon activation
Translations should be inserted as active text pools, only the text pool of the master language can be inactive. Otherwise translations will be deleted upon activation. | sbcgua/abapGit,sbcgua/abapGit,apex8/abapGit,EduardoCopat/abapGit,larshp/abapGit,apex8/abapGit,EduardoCopat/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/zabapgit_objects.prog.abap
+++ src/zabapgit_objects.prog.abap
@@ -1461,23 +1461,30 @@
ENDIF.
READ TABLE it_tpool WITH KEY id = 'R' TRANSPORTING NO FIELDS.
- IF ( sy-subrc = 0 AND lines( it_tpool ) = 1 ) OR lines( it_tpool ) = 0.
- RETURN. " no action for includes
- ENDIF.
-
- INSERT TEXTPOOL iv_program
- FROM it_tpool
- LANGUAGE lv_language
- STATE 'I'.
- IF sy-subrc <> 0.
- zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
- ENDIF.
-
- IF lv_language = mv_language. " Add just once
+ IF ( sy-subrc = 0 AND lines( it_tpool ) = 1 AND lv_language = mv_language ) OR lines( it_tpool ) = 0.
+ RETURN. " no action for includes unless there is a translation of the program description
+ ENDIF.
+
+ IF lv_language = mv_language. "Textpool in master language needs to be activated
+ INSERT TEXTPOOL iv_program
+ FROM it_tpool
+ LANGUAGE lv_language
+ STATE 'I'.
+ IF sy-subrc <> 0.
+ zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
+ ENDIF.
+
lcl_objects_activation=>add( iv_type = 'REPT'
iv_name = iv_program ).
- ENDIF.
-
+ ELSE. "Translations are always active
+ INSERT TEXTPOOL iv_program
+ FROM it_tpool
+ LANGUAGE lv_language
+ STATE 'A'.
+ IF sy-subrc <> 0.
+ zcx_abapgit_exception=>raise( 'error from INSERT TEXTPOOL' ).
+ ENDIF.
+ ENDIF.
ENDMETHOD. "deserialize_textpool
METHOD deserialize_cua.
|
|
d79a38eec20cacf73dafeb436d685dbe458b646d | Enable AFF to delete TADIR entries (#5326) | Enable AFF to delete TADIR entries (#5326)
* Enable AFF to delete TADIR entries
* AbapLint policy I
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com>
* AbapLine policy II
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com>
* AbapLint policy III
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com>
* AbapLint policy IV
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com>
* AbapLint policy V
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com>
* AbapLint XY
* don't call AFF for trivial tasks
Co-authored-by: abaplint[bot] <589dee37d0e82f3cabf9dea701e9ec2fd481eb1e@users.noreply.github.com> | larshp/abapGit,larshp/abapGit,sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/aff/zcl_abapgit_object_common_aff.clas.abap
+++ src/objects/aff/zcl_abapgit_object_common_aff.clas.abap
@@ -92,6 +92,17 @@
iv_msgv3 = <ls_msg>-msgv3
iv_msgv4 = <ls_msg>-msgv4 ).
ENDLOOP.
+
+ CALL FUNCTION 'TR_TADIR_INTERFACE'
+ EXPORTING
+ wi_delete_tadir_entry = abap_true
+ wi_tadir_pgmid = 'R3TR'
+ wi_tadir_object = ms_item-obj_type
+ wi_tadir_obj_name = ms_item-obj_name
+ wi_tadir_devclass = ms_item-devclass
+ wi_test_modus = abap_false.
+ IF sy-subrc <> 0.
+ ENDIF.
CATCH cx_root INTO lx_error.
zcx_abapgit_exception=>raise_with_text( lx_error ).
@@ -214,6 +225,7 @@
iv_type = <ls_type>
is_item = ms_item ).
ENDLOOP.
+
tadir_insert( ms_item-devclass ).
CATCH cx_static_check INTO lx_exception.
|
|
10306e2fdd9e88708be53af41dad44bae00383fa | properly delete WDYA TADIR entry | properly delete WDYA TADIR entry | sbcgua/abapGit,EduardoCopat/abapGit,apex8/abapGit,nununo/abapGit,sbcgua/abapGit,larshp/abapGit,EduardoCopat/abapGit,larshp/abapGit,nununo/abapGit,apex8/abapGit | 0 | mit | ABAP | --- zabapgit.abap
+++ zabapgit.abap
@@ -3,7 +3,7 @@
* See https://github.com/larshp/abapGit/
CONSTANTS: gc_xml_version TYPE string VALUE 'v0.2-alpha', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v0.76'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v0.77'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
@@ -5309,8 +5309,10 @@
METHOD delete.
- DATA: li_app TYPE REF TO if_wdy_md_application,
- lv_name TYPE wdy_application_name.
+ DATA: li_app TYPE REF TO if_wdy_md_application,
+ lv_objkey TYPE wdy_wb_appl_name,
+ lv_type TYPE seu_type,
+ lv_name TYPE wdy_application_name.
lv_name = is_item-obj_name.
@@ -5320,6 +5322,19 @@
version = 'A' ).
li_app->if_wdy_md_object~delete( ).
li_app->if_wdy_md_lockable_object~save_to_database( ).
+
+* method save_to_database calls function module TR_TADIR_INTERFACE
+* with test mode = X, so it does not delete the TADIR entry.
+* Instead the standard code uses RS_TREE_OBJECT_PLACEMENT to delete
+* the TADIR entry
+ lv_objkey = is_item-obj_name.
+ CONCATENATE 'O' swbm_c_type_wdy_application INTO lv_type.
+ CALL FUNCTION 'RS_TREE_OBJECT_PLACEMENT'
+ EXPORTING
+ object = lv_objkey
+ type = lv_type
+ operation = 'DELETE'.
+
CATCH cx_wdy_md_not_existing.
RETURN.
CATCH cx_wdy_md_exception.
@@ -7208,7 +7223,6 @@
IMPORTING
es_objh = ls_objh
es_objt = ls_objt
-* EV_OBJT_DOESNT_EXIST =
TABLES
tt_objs = lt_objs
tt_objsl = lt_objsl
@@ -7555,7 +7569,7 @@
iv_package TYPE devclass
RAISING lcx_exception.
-ENDCLASS. "lcl_object_dtel DEFINITION
+ENDCLASS. "lcl_object_fugr DEFINITION
*----------------------------------------------------------------------*
* CLASS lcl_object_dtel IMPLEMENTATION
@@ -7640,10 +7654,7 @@
CALL FUNCTION 'FUNCTION_DELETE'
EXPORTING
funcname = <ls_functab>-funcname
-* SUPPRESS_DELETE_LONGTEXT = ' '
suppress_success_message = abap_true
-* SUPPRESS_DELE_ENHA = ' '
-* SUPPRESS_LOCK = ' '
EXCEPTIONS
error_message = 1
OTHERS = 2.
|
|
690527a771142a3a64d5a88e4036ece6f92b9c96 | Add you might switch to FULL folder logic to error message | Add you might switch to FULL folder logic to error message
| larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/zcl_abapgit_folder_logic.clas.abap
+++ src/zcl_abapgit_folder_logic.clas.abap
@@ -58,7 +58,7 @@
* if abapGit project is installed in package ZZZ, all subpackages should be named
* ZZZ_something. This will define the folder name in the zip file to be "something",
* similarily with online projects. Alternatively change to FULL folder logic
- lv_message = 'PREFIX: Unexpected package naming(' && iv_package && ')' ##no_text.
+ lv_message = 'PREFIX: Unexpected package naming (' && iv_package && ') you might switch to FULL folder logic' ##no_text.
zcx_abapgit_exception=>raise( lv_message ).
ENDIF.
WHEN OTHERS.
|
|
0728e9d915ce17e229afe75001fd97264be6337e | Bugfix access deleted branch in news page | Bugfix access deleted branch in news page
#834
Bugfix access deleted branch in news abapgit page. When the news page try to access a branch that doesn't exist anymore in the remote we catch the belonging exception and return. | larshp/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,apex8/abapGit,apex8/abapGit,larshp/abapGit,sbcgua/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/zabapgit_news.prog.abap
+++ src/zabapgit_news.prog.abap
@@ -112,8 +112,13 @@
lv_last_seen = lcl_app=>user( )->get_repo_last_change_seen( lv_url ).
- " Find changelog
- lt_remote = io_repo->get_files_remote( ).
+ TRY.
+ " Find changelog
+ lt_remote = io_repo->get_files_remote( ).
+ CATCH lcx_exception.
+ RETURN.
+ ENDTRY.
+
READ TABLE lt_remote ASSIGNING <file>
WITH KEY path = lc_log_path filename = lc_log_filename.
|
|
f2a801ad1a5676b442e6b49fa3af2de030d56d9c | Dialogs: Add comment to password popup (#4910) | Dialogs: Add comment to password popup (#4910)
Temporarily, adding a comment to the password popup regarding Github login.
To be removed end of 2021
https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/
Closes #4909 | sbcgua/abapGit,sbcgua/abapGit,larshp/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/zabapgit_password_dialog.prog.abap
+++ src/zabapgit_password_dialog.prog.abap
@@ -1,6 +1,8 @@
*&---------------------------------------------------------------------*
*& Include ZABAPGIT_PASSWORD_DIALOG
*&---------------------------------------------------------------------*
+
+* Todo, remove comment about Github token usage by 2021-12-31
SELECTION-SCREEN BEGIN OF SCREEN 1002 TITLE s_title.
SELECTION-SCREEN BEGIN OF LINE.
@@ -14,6 +16,11 @@
SELECTION-SCREEN BEGIN OF LINE.
SELECTION-SCREEN COMMENT 1(18) s_pass FOR FIELD p_pass.
PARAMETERS: p_pass TYPE c LENGTH 255 LOWER CASE VISIBLE LENGTH 60 ##SEL_WRONG.
+SELECTION-SCREEN END OF LINE.
+SELECTION-SCREEN SKIP.
+SELECTION-SCREEN BEGIN OF LINE.
+SELECTION-SCREEN COMMENT 1(18) s_cmnt FOR FIELD p_cmnt.
+PARAMETERS: p_cmnt TYPE c LENGTH 255 LOWER CASE VISIBLE LENGTH 60 ##SEL_WRONG.
SELECTION-SCREEN END OF LINE.
SELECTION-SCREEN END OF SCREEN 1002.
@@ -57,6 +64,7 @@
CLEAR p_pass.
p_url = iv_repo_url.
p_user = cv_user.
+ p_cmnt = 'GitHub requires using tokens (since August 2021)'.
gv_confirm = abap_false.
@@ -80,6 +88,7 @@
s_url = 'Repo URL'.
s_user = 'User'.
s_pass = 'Password or Token'.
+ s_cmnt = 'Note'.
ENDMETHOD.
METHOD on_screen_output.
@@ -88,7 +97,7 @@
ASSERT sy-dynnr = c_dynnr.
LOOP AT SCREEN.
- IF screen-name = 'P_URL'.
+ IF screen-name = 'P_URL' OR screen-name = 'P_CMNT'.
screen-input = '0'.
screen-intensified = '1'.
screen-display_3d = '0'.
|
|
74181160efb51f66b65a9384fccced1b3476941b | minor changes | minor changes | larshp/abapGit,EduardoCopat/abapGit,apex8/abapGit,larshp/abapGit,nununo/abapGit,apex8/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,nununo/abapGit | 0 | mit | ABAP | --- zabapgit.abap
+++ zabapgit.abap
@@ -1,9 +1,9 @@
REPORT zabapgit.
-* See https://github.com/larshp/abapGit/
+* See http://www.abapgit.org
CONSTANTS: gc_xml_version TYPE string VALUE 'v0.2-alpha', "#EC NOTEXT
- gc_abap_version TYPE string VALUE 'v0.105'. "#EC NOTEXT
+ gc_abap_version TYPE string VALUE 'v0.106'. "#EC NOTEXT
********************************************************************************
* The MIT License (MIT)
@@ -99,8 +99,8 @@
DATA mv_text TYPE string.
METHODS constructor
- IMPORTING iv_text TYPE string
- previous TYPE REF TO cx_root OPTIONAL.
+ IMPORTING iv_text TYPE string
+ ix_previous TYPE REF TO cx_root OPTIONAL.
PRIVATE SECTION.
DATA mx_previous TYPE REF TO cx_root.
@@ -2313,7 +2313,8 @@
io_xml TYPE REF TO lcl_xml
iv_normalize TYPE sap_bool DEFAULT abap_true
RAISING lcx_exception,
- add_xml_from_plugin "needed since type-check during dynamic call fails even if the object is compatible
+* needed since type-check during dynamic call fails even if the object is compatible
+ add_xml_from_plugin
IMPORTING iv_extra TYPE clike OPTIONAL
io_xml TYPE REF TO object
iv_normalize TYPE sap_bool DEFAULT abap_true
@@ -2519,13 +2520,14 @@
* ABAP does not perform implicit type casts (also if compatible) in signatures,
* therefore this method's signature is typed ref to object
DATA lo_xml TYPE REF TO lcl_xml.
+
lo_xml ?= io_xml.
+
me->add_xml(
- EXPORTING
- iv_extra = iv_extra
- io_xml = lo_xml
- iv_normalize = iv_normalize
- ).
+ iv_extra = iv_extra
+ io_xml = lo_xml
+ iv_normalize = iv_normalize ).
+
ENDMETHOD.
ENDCLASS.
@@ -2605,9 +2607,10 @@
METHOD lif_object~serialize.
- DATA: lv_count TYPE i,
- ls_file TYPE ty_file,
- lo_files TYPE REF TO object.
+ DATA: lv_count TYPE i,
+ ls_file TYPE ty_file,
+ lo_files TYPE REF TO object,
+ lo_wrapped_files TYPE REF TO object.
CALL METHOD mo_plugin->('ZIF_ABAPGIT_PLUGIN~SERIALIZE').
@@ -2615,7 +2618,6 @@
RECEIVING
ro_files_proxy = lo_files. "Returns a proxy wrapping a files-object
- DATA lo_wrapped_files TYPE REF TO object.
CALL METHOD lo_files->('GET_WRAPPED_OBJECT')
RECEIVING
ro_objects_files = lo_wrapped_files.
@@ -2650,8 +2652,11 @@
TRY.
CALL METHOD mo_plugin->('ZIF_ABAPGIT_PLUGIN~DESERIALIZE').
- CATCH zcx_abapgit_object INTO lx_plugin.
- RAISE EXCEPTION TYPE lcx_exception EXPORTING previous = lx_plugin iv_text = lx_plugin->get_text( ).
+ CATCH cx_static_check INTO lx_plugin.
+ RAISE EXCEPTION TYPE lcx_exception
+ EXPORTING
+ ix_previous = lx_plugin
+ iv_text = lx_plugin->get_text( ).
ENDTRY.
ENDMETHOD.
@@ -2660,8 +2665,11 @@
TRY.
CALL METHOD mo_plugin->('ZIF_ABAPGIT_PLUGIN~DELETE').
- CATCH zcx_abapgit_object INTO lx_plugin.
- RAISE EXCEPTION TYPE lcx_exception EXPORTING previous = lx_plugin iv_text = lx_plugin->get_text( ).
+ CATCH cx_static_check INTO lx_plugin.
+ RAISE EXCEPTION TYPE lcx_exception
+ EXPORTING
+ ix_previous = lx_plugin
+ iv_text = lx_plugin->get_text( ).
ENDTRY.
ENDMETHOD.
@@ -4470,12 +4478,15 @@
mv_skip_testclass = abap_false.
IF lines( rt_source ) = 2.
READ TABLE rt_source INDEX 1 INTO lv_line1.
+ ASSERT sy-subrc = 0.
READ TABLE rt_source INDEX 2 INTO lv_line2.
+ ASSERT sy-subrc = 0.
IF lv_line1(3) = '*"*' AND lv_line2 IS INITIAL.
mv_skip_testclass = abap_true.
ENDIF.
ELSEIF lines( rt_source ) = 1.
READ TABLE rt_source INDEX 1 INTO lv_line1.
+ ASSERT sy-subrc = 0.
IF lv_line1(3) = '*"*' OR lv_line1 IS INITIAL.
mv_skip_testclass = abap_true.
ENDIF.
@@ -11082,8 +11093,7 @@
TRY.
CREATE OBJECT ri_obj TYPE (lv_class_name)
EXPORTING
- is_item = is_item
- .
+ is_item = is_item.
CATCH cx_sy_create_object_error.
TRY.
* 2nd step, try looking for plugins
|
|
b1cc6a2912a5ef38d77517c8e362bb37c9b488fb | Refactor method in FM call for 702 (#4848) | Refactor method in FM call for 702 (#4848)
| larshp/abapGit,sbcgua/abapGit,larshp/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/ui/zcl_abapgit_gui_router.clas.abap
+++ src/ui/zcl_abapgit_gui_router.clas.abap
@@ -695,12 +695,15 @@
METHOD zip_services.
- DATA: lv_key TYPE zif_abapgit_persistence=>ty_repo-key,
- lo_repo TYPE REF TO zcl_abapgit_repo,
- lv_path TYPE string,
- lv_dest TYPE rfcdest,
- lv_msg TYPE c LENGTH 200,
- lv_xstr TYPE xstring.
+ DATA: lv_key TYPE zif_abapgit_persistence=>ty_repo-key,
+ lo_repo TYPE REF TO zcl_abapgit_repo,
+ lv_path TYPE string,
+ lv_dest TYPE rfcdest,
+ lv_msg TYPE c LENGTH 200,
+ lv_xstr TYPE xstring,
+ lv_package TYPE zif_abapgit_persistence=>ty_repo-package,
+ lv_folder_logic TYPE string,
+ lv_main_lang_only TYPE zif_abapgit_persistence=>ty_local_settings-main_language_only.
CONSTANTS:
BEGIN OF lc_page,
@@ -730,12 +733,16 @@
RETURN.
ENDIF.
+ lv_package = lo_repo->get_package( ).
+ lv_folder_logic = lo_repo->get_dot_abapgit( )->get_folder_logic( ).
+ lv_main_lang_only = lo_repo->get_local_settings( )-main_language_only.
+
CALL FUNCTION 'Z_ABAPGIT_SERIALIZE_PACKAGE'
DESTINATION lv_dest
EXPORTING
- iv_package = lo_repo->get_package( )
- iv_folder_logic = lo_repo->get_dot_abapgit( )->get_folder_logic( )
- iv_main_lang_only = lo_repo->get_local_settings( )-main_language_only
+ iv_package = lv_package
+ iv_folder_logic = lv_folder_logic
+ iv_main_lang_only = lv_main_lang_only
IMPORTING
ev_xstring = lv_xstr
EXCEPTIONS
|
|
fe1128b959896a968157ba510d0ff6185e8a5a2b | bugfix, do not show dirs as part of diff | bugfix, do not show dirs as part of diff | larshp/abapGitServer,larshp/abapGitServer | 0 | mit | ABAP | --- src/service/zcl_ags_service_rest.clas.abap
+++ src/service/zcl_ags_service_rest.clas.abap
@@ -201,6 +201,7 @@
ENDMETHOD.
+
METHOD list_changes.
* todo: file paths handled wrong and not returned
@@ -231,7 +232,7 @@
blob_sha1 ASCENDING.
ENDIF.
- LOOP AT lt_new INTO ls_new.
+ LOOP AT lt_new INTO ls_new WHERE chmod <> zcl_ags_obj_tree=>c_chmod-dir.
lv_index = sy-tabix.
* remove unchanged
READ TABLE lt_old TRANSPORTING NO FIELDS
@@ -265,13 +266,14 @@
ENDLOOP.
* find deleted
- LOOP AT lt_old INTO ls_old.
+ LOOP AT lt_old INTO ls_old WHERE chmod <> zcl_ags_obj_tree=>c_chmod-dir.
APPEND INITIAL LINE TO rt_files ASSIGNING <ls_file>.
<ls_file>-filename = ls_old-filename.
<ls_file>-old_blob = ls_old-blob_sha1.
ENDLOOP.
ENDMETHOD.
+
METHOD list_commits.
|
|
5af8cf8862fa35f668a5cd07f24f514b2b9c4ecf | AFF: Downport (#5679) | AFF: Downport (#5679)
* AFF: Downport
* fix lint | sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_intf.clas.locals_imp.abap
+++ src/objects/zcl_abapgit_object_intf.clas.locals_imp.abap
@@ -190,7 +190,10 @@
DATA:
lt_components TYPE STANDARD TABLE OF ty_helper_type,
lt_sub_components TYPE ty_sub_compontents,
- lt_components_exp TYPE ty_compontents.
+ lt_components_exp TYPE ty_compontents,
+ ls_component_exp LIKE LINE OF lt_components_exp.
+ FIELD-SYMBOLS:
+ <ls_component> LIKE LINE OF lt_components.
SELECT component~cmpname component_text~descript component~cmptype
@@ -211,7 +214,11 @@
AND sub_component_text~langu = iv_language
AND sub_component_text~descript <> space. "#EC CI_BUFFJOIN
- MOVE-CORRESPONDING lt_components TO lt_components_exp.
+ LOOP AT lt_components ASSIGNING <ls_component>.
+ CLEAR ls_component_exp.
+ MOVE-CORRESPONDING <ls_component> TO ls_component_exp.
+ INSERT ls_component_exp INTO TABLE lt_components_exp.
+ ENDLOOP.
rs_properties-attributes = get_attributes( lt_components_exp ).
rs_properties-methods = get_methods( is_components = lt_components_exp
|
|
38353bfac6437509951e25cfcf1b66086cd1c374 | fix for SSO | fix for SSO | larshp/abapGitServer,larshp/abapGitServer | 0 | mit | ABAP | --- src/frontend/zags_start.prog.abap
+++ src/frontend/zags_start.prog.abap
@@ -5,7 +5,11 @@
FORM run.
- DATA: lv_url TYPE string.
+ DATA: lv_url TYPE string,
+ lv_urlc TYPE c LENGTH 2048,
+ lo_viewer TYPE REF TO cl_gui_html_viewer,
+ lo_empty TYPE REF TO cl_gui_container.
+
* misuse the BSP runtime to construct SICF url
cl_bsp_runtime=>construct_bsp_url(
@@ -18,22 +22,12 @@
IN lv_url
WITH 'sap/zabapgitserver'.
- cl_gui_frontend_services=>execute(
+ CREATE OBJECT lo_viewer
EXPORTING
- document = lv_url
- EXCEPTIONS
- cntl_error = 1
- error_no_gui = 2
- bad_parameter = 3
- file_not_found = 4
- path_not_found = 5
- file_extension_unknown = 6
- error_execute_failed = 7
- synchronous_failed = 8
- not_supported_by_gui = 9
- OTHERS = 10 ).
- IF sy-subrc <> 0.
- WRITE: / 'Error when calling frontend services:', sy-subrc.
- ENDIF.
+ parent = lo_empty.
+
+ lv_urlc = lv_url.
+ lo_viewer->detach_url_in_browser( lv_urlc ).
+ cl_gui_cfw=>flush( ).
ENDFORM.
|
|
e4bfe673cfee9c62867f31d91c9524f64deab46b | diff - add progress indicator rendering a large diff takes some time, added progress indicator | diff - add progress indicator
rendering a large diff takes some time, added progress indicator | EduardoCopat/abapGit,sbcgua/abapGit,larshp/abapGit,nununo/abapGit,EduardoCopat/abapGit,apex8/abapGit,apex8/abapGit,sbcgua/abapGit,nununo/abapGit,larshp/abapGit | 0 | mit | ABAP | --- src/zabapgit_page_diff.prog.abap
+++ src/zabapgit_page_diff.prog.abap
@@ -356,6 +356,12 @@
ro_html->add( title( 'DIFF' ) ).
LOOP AT mt_diff_files INTO ls_diff_file.
+ cl_progress_indicator=>progress_indicate(
+ i_text = |Render Diff - { ls_diff_file-filename }|
+ i_processed = sy-tabix
+ i_total = lines( mt_diff_files )
+ i_output_immediately = abap_true ).
+
ro_html->add( render_diff( ls_diff_file ) ).
ENDLOOP.
|
|
fd7d4771d86cbca5eb0c4bb6be284f7095247a41 | started unit tests for intf deserialize (#5697) | started unit tests for intf deserialize (#5697)
| sbcgua/abapGit,sbcgua/abapGit | 0 | mit | ABAP | --- src/objects/zcl_abapgit_object_intf.clas.testclasses.abap
+++ src/objects/zcl_abapgit_object_intf.clas.testclasses.abap
@@ -1,4 +1,270 @@
-*"* use this source file for your ABAP unit test classes
+CLASS ltcl_unit_test DEFINITION DEFERRED.
+CLASS zcl_abapgit_object_intf DEFINITION LOCAL FRIENDS ltcl_unit_test.
+
+CLASS lth_oo_object_fnc DEFINITION FINAL FOR TESTING.
+
+ PUBLIC SECTION.
+ INTERFACES zif_abapgit_oo_object_fnc.
+
+ DATA:
+ mv_create_package TYPE devclass,
+ ms_create_vseointerf TYPE vseointerf,
+ ms_deserialize_key TYPE seoclskey,
+ mt_deserialize_source TYPE zif_abapgit_definitions=>ty_string_tt,
+ ms_descriptions_key TYPE seoclskey,
+ mt_descriptions TYPE zif_abapgit_oo_object_fnc=>ty_seocompotx_tt,
+ ms_activation_item TYPE zif_abapgit_definitions=>ty_item,
+ mt_docu_lines TYPE tlinetab,
+ mv_docu_id TYPE dokhl-id,
+ mv_docu_object_name TYPE dokhl-object,
+ mv_docu_langu TYPE spras.
+ENDCLASS.
+
+CLASS lth_oo_object_fnc IMPLEMENTATION.
+
+ METHOD zif_abapgit_oo_object_fnc~add_to_activation_list.
+ ms_activation_item = is_item.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~create.
+ mv_create_package = iv_package.
+ ms_create_vseointerf = cg_properties.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~create_documentation.
+ mt_docu_lines = it_lines.
+ mv_docu_id = iv_id.
+ mv_docu_object_name = iv_object_name.
+ mv_docu_langu = iv_language.
+
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~create_sotr.
+ ENDMETHOD.
+ METHOD zif_abapgit_oo_object_fnc~delete.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~delete_documentation.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~deserialize_source.
+ ms_deserialize_key = is_key.
+ mt_deserialize_source = it_source.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~exists.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~generate_locals.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~get_class_properties.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~get_includes.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~get_interface_properties.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~get_skip_test_classes.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~insert_text_pool.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_attributes.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_descriptions.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_documentation.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_sotr.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_superclass.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~read_text_pool.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~serialize_abap.
+ ENDMETHOD.
+
+ METHOD zif_abapgit_oo_object_fnc~update_descriptions.
+ ms_descriptions_key = is_key.
+ mt_descriptions = it_descriptions.
+ ENDMETHOD.
+
+ENDCLASS.
+
+
+CLASS ltcl_unit_test DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
+
+ PRIVATE SECTION.
+ DATA:
+ mo_cut TYPE REF TO zif_abapgit_object,
+ mo_log TYPE REF TO zcl_abapgit_log,
+ mo_object_fnc TYPE REF TO lth_oo_object_fnc,
+ ms_item TYPE zif_abapgit_definitions=>ty_item.
+
+ METHODS:
+ setup,
+
+ get_xml
+ RETURNING VALUE(rv_xml) TYPE string,
+ get_source
+ RETURNING VALUE(rt_source) TYPE rswsourcet,
+
+ deserializes FOR TESTING RAISING cx_static_check.
+ENDCLASS.
+
+CLASS ltcl_unit_test IMPLEMENTATION.
+
+ METHOD setup.
+ DATA lo_cut TYPE REF TO zcl_abapgit_object_intf.
+
+ ms_item-obj_name = 'ZIF_ABAPGIT_TEST_INTF'.
+ ms_item-obj_type = 'INTF'.
+
+ CREATE OBJECT lo_cut
+ EXPORTING
+ is_item = ms_item
+ iv_language = 'E'.
+
+ CREATE OBJECT lo_cut->zif_abapgit_object~mo_files
+ EXPORTING
+ is_item = ms_item.
+
+ CREATE OBJECT mo_log.
+
+ CREATE OBJECT mo_object_fnc.
+ lo_cut->mi_object_oriented_object_fct = mo_object_fnc.
+
+ mo_cut = lo_cut.
+
+ ENDMETHOD.
+
+ METHOD deserializes.
+ DATA lo_xmlin TYPE REF TO zcl_abapgit_xml_input.
+ DATA ls_expected_vseointerf TYPE vseointerf.
+ DATA ls_expected_clskey TYPE seoclskey.
+ DATA ls_expected_description TYPE seocompotx.
+ DATA lt_expected_descriptions TYPE zif_abapgit_oo_object_fnc=>ty_seocompotx_tt.
+ DATA ls_expected_docu_line TYPE tline.
+ DATA lt_expected_docu_lines TYPE tlinetab.
+
+ CREATE OBJECT lo_xmlin TYPE zcl_abapgit_xml_input
+ EXPORTING
+ iv_xml = get_xml( ).
+
+ mo_cut->mo_files->add_abap( get_source( ) ).
+
+ mo_cut->deserialize(
+ iv_package = 'MY_PACKAGE'
+ io_xml = lo_xmlin
+ iv_step = zif_abapgit_object=>gc_step_id-abap
+ ii_log = mo_log
+ iv_transport = 'XXX12345678' ).
+
+
+ cl_abap_unit_assert=>assert_equals( exp = 'MY_PACKAGE'
+ act = mo_object_fnc->mv_create_package ).
+
+ ls_expected_vseointerf-clsname = 'ZIF_ABAPGIT_TEST_INTF'.
+ ls_expected_vseointerf-langu = 'E'.
+ ls_expected_vseointerf-descript = 'Test interface for abap git'.
+ ls_expected_vseointerf-exposure = '2'.
+ ls_expected_vseointerf-state = '1'.
+ ls_expected_vseointerf-unicode = 'X'.
+ cl_abap_unit_assert=>assert_equals( exp = ls_expected_vseointerf
+ act = mo_object_fnc->ms_create_vseointerf ).
+
+ ls_expected_clskey-clsname = 'ZIF_ABAPGIT_TEST_INTF'.
+ cl_abap_unit_assert=>assert_equals( exp = ls_expected_clskey
+ act = mo_object_fnc->ms_deserialize_key ).
+ cl_abap_unit_assert=>assert_equals( exp = ls_expected_clskey
+ act = mo_object_fnc->ms_deserialize_key ).
+
+ cl_abap_unit_assert=>assert_equals( exp = ls_expected_clskey
+ act = mo_object_fnc->ms_descriptions_key ).
+ ls_expected_description-clsname = 'ZIF_ABAPGIT_TEST_INTF'.
+ ls_expected_description-cmpname = 'ONE_METHOD'.
+ ls_expected_description-langu = 'E'.
+ ls_expected_description-descript = 'Method One, one, one, one, ...'.
+ APPEND ls_expected_description TO lt_expected_descriptions.
+ cl_abap_unit_assert=>assert_equals( exp = lt_expected_descriptions
+ act = mo_object_fnc->mt_descriptions ).
+ cl_abap_unit_assert=>assert_equals( exp = ms_item
+ act = mo_object_fnc->ms_activation_item ).
+
+ ls_expected_docu_line-tdformat = 'U1'.
+ ls_expected_docu_line-tdline = '&MEANING&'.
+ APPEND ls_expected_docu_line TO lt_expected_docu_lines.
+ ls_expected_docu_line-tdformat = 'AS'.
+ ls_expected_docu_line-tdline = 'Interface for abap git unit tests.'.
+ APPEND ls_expected_docu_line TO lt_expected_docu_lines.
+ cl_abap_unit_assert=>assert_equals( exp = lt_expected_docu_lines
+ act = mo_object_fnc->mt_docu_lines ).
+ cl_abap_unit_assert=>assert_equals( exp = 'IF'
+ act = mo_object_fnc->mv_docu_id ).
+ cl_abap_unit_assert=>assert_equals( exp = 'E'
+ act = mo_object_fnc->mv_docu_langu ).
+ cl_abap_unit_assert=>assert_equals( exp = 'ZIF_ABAPGIT_TEST_INTF'
+ act = mo_object_fnc->mv_docu_object_name ).
+ ENDMETHOD.
+
+ METHOD get_xml.
+ rv_xml =
+ '<?xml version="1.0" encoding="UTF-8"?><abapGit version="v1.0.0">' &&
+ ' <asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">' &&
+ ' <asx:values>' &&
+ ' <VSEOINTERF>' &&
+ ' <CLSNAME>ZIF_ABAPGIT_TEST_INTF</CLSNAME>' &&
+ ' <LANGU>E</LANGU>' &&
+ ' <DESCRIPT>Test interface for abap git</DESCRIPT>' &&
+ ' <EXPOSURE>2</EXPOSURE>' &&
+ ' <STATE>1</STATE>' &&
+ ' <UNICODE>X</UNICODE>' &&
+ ' </VSEOINTERF>' &&
+ ' <DESCRIPTIONS>' &&
+ ' <SEOCOMPOTX>' &&
+ ' <CLSNAME>ZIF_ABAPGIT_TEST_INTF</CLSNAME>' &&
+ ' <CMPNAME>ONE_METHOD</CMPNAME>' &&
+ ' <LANGU>E</LANGU>' &&
+ ' <DESCRIPT>Method One, one, one, one, ...</DESCRIPT>' &&
+ ' </SEOCOMPOTX>' &&
+ ' </DESCRIPTIONS>' &&
+ ' <LINES>' &&
+ ' <TLINE>' &&
+ ' <TDFORMAT>U1</TDFORMAT>' &&
+ ' <TDLINE>&MEANING&</TDLINE>' &&
+ ' </TLINE>' &&
+ ' <TLINE>' &&
+ ' <TDFORMAT>AS</TDFORMAT>' &&
+ ' <TDLINE>Interface for abap git unit tests.</TDLINE>' &&
+ ' </TLINE>' &&
+ ' </LINES>' &&
+ ' </asx:values>' &&
+ ' </asx:abap>' &&
+ '</abapGit>'.
+ ENDMETHOD.
+
+ METHOD get_source.
+ APPEND 'interface zif_abapgit_test_intf' TO rt_source.
+ APPEND ' public.' TO rt_source.
+ APPEND ' methods:' TO rt_source.
+ APPEND ' one_method' TO rt_source.
+ APPEND ' returning value(rv_value) type string.' TO rt_source.
+ APPEND '' TO rt_source.
+ APPEND 'endinterface.' TO rt_source.
+ ENDMETHOD.
+
+ENDCLASS.
+
CLASS ltcl_serialize DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
PRIVATE SECTION.
METHODS:
@@ -79,5 +345,4 @@
iv_json_b = lv_expected ).
cl_abap_unit_assert=>assert_true( lv_is_equal ).
ENDMETHOD.
-
-ENDCLASS.
+ENDCLASS.
|
|
7715bdc59df7b2fcea3abb32a620fa1df4270994 | Replace usages of cl_sxml* for compatibility cl_sxml_writer/reader do not support json on AS ABAP 7.02 | Replace usages of cl_sxml* for compatibility
cl_sxml_writer/reader do not support json on AS ABAP 7.02 | larshp/abapGit,larshp/abapGit,nununo/abapGit,apex8/abapGit,sbcgua/abapGit,nununo/abapGit,sbcgua/abapGit,EduardoCopat/abapGit,apex8/abapGit,EduardoCopat/abapGit | 0 | mit | ABAP | --- src/zabapgit_2fa.prog.abap
+++ src/zabapgit_2fa.prog.abap
@@ -436,80 +436,52 @@
rv_access_token = get_token_from_response( li_http_client->response ).
IF rv_access_token IS INITIAL.
- RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed.
+ RAISE EXCEPTION TYPE lcx_2fa_token_gen_failed
+ EXPORTING
+ iv_error_text = 'Token generation failed: parser error' ##NO_TEXT.
ENDIF.
ENDMETHOD.
METHOD set_access_token_request.
- CONSTANTS: BEGIN OF lc_create_access_token_request,
- scopes TYPE string VALUE 'repo',
- note TYPE string VALUE 'abapGit',
- END OF lc_create_access_token_request.
- DATA: lo_json_writer TYPE REF TO cl_sxml_string_writer,
- lt_scopes TYPE stringtab,
- lt_rest_parvalues TYPE abap_trans_srcbind_tab,
- ls_rest_line LIKE LINE OF lt_rest_parvalues,
- lt_result_parvalues TYPE abap_trans_resbind_tab,
- ls_result_line LIKE LINE OF lt_result_parvalues,
- lr_data_ref TYPE REF TO data,
- lv_note TYPE string,
- lv_fingerprint TYPE string.
-
- lo_json_writer = cl_sxml_string_writer=>create( type = if_sxml=>co_xt_json ).
- APPEND lc_create_access_token_request-scopes TO lt_scopes.
-
- GET REFERENCE OF lc_create_access_token_request-scopes INTO lr_data_ref.
- ls_rest_line-name = 'scopes'.
- ls_rest_line-value = lr_data_ref.
- APPEND ls_rest_line TO lt_rest_parvalues.
-
- GET REFERENCE OF lc_create_access_token_request-note INTO lr_data_ref.
- ls_rest_line-name = 'note'.
- ls_rest_line-value = lr_data_ref.
- APPEND ls_rest_line TO lt_rest_parvalues.
+ DATA: lv_fingerprint TYPE string,
+ lv_json_string TYPE string.
" The fingerprint must be unique, otherwise only one token can be generated, unless the user
" deletes it in GitHub's settings. This is problematic if he deletes it in abapGit but keeps it
" on GitHub.
lv_fingerprint = |abapGit-{ sy-sysid }-{ sy-uname }-{ sy-datum }-{ sy-uzeit }|.
- GET REFERENCE OF lv_fingerprint INTO lr_data_ref.
- ls_rest_line-name = 'fingerprint'.
- ls_rest_line-value = lr_data_ref.
- APPEND ls_rest_line TO lt_rest_parvalues.
-
- " Dynamic source table is used because otherwise identifiers will always be written in uppercase
- " which is not supported by GitHub's API.
- CALL TRANSFORMATION id SOURCE (lt_rest_parvalues)
- RESULT XML lo_json_writer.
-
- ii_request->set_data( lo_json_writer->get_output( ) ).
+
+ lv_json_string = |\{"scopes":["repo"],"note":"abapGit","fingerprint":"{ lv_fingerprint }"\}|.
+
+ ii_request->set_data( cl_abap_codepage=>convert_to( lv_json_string ) ).
ENDMETHOD.
METHOD get_token_from_response.
- CONSTANTS: lc_token_field_name TYPE string VALUE 'token'.
- DATA: lt_result_parvalues TYPE abap_trans_resbind_tab,
- ls_result_line LIKE LINE OF lt_result_parvalues,
- lr_data_ref TYPE REF TO data,
- lv_binary_response TYPE xstring.
-
- GET REFERENCE OF rv_token INTO lr_data_ref.
- ls_result_line-name = lc_token_field_name.
- ls_result_line-value = lr_data_ref.
- APPEND ls_result_line TO lt_result_parvalues.
-
- lv_binary_response = ii_response->get_data( ).
-
- CALL TRANSFORMATION id SOURCE XML lv_binary_response
- RESULT (lt_result_parvalues).
+ CONSTANTS: lc_search_regex TYPE string VALUE '.*"token":"([^"]*).*$'.
+ DATA: lv_response TYPE string,
+ lo_regex TYPE REF TO cl_abap_regex,
+ lo_matcher TYPE REF TO cl_abap_matcher.
+
+ lv_response = cl_abap_codepage=>convert_from( ii_response->get_data( ) ).
+
+ CREATE OBJECT lo_regex
+ EXPORTING
+ pattern = lc_search_regex.
+
+ lo_matcher = lo_regex->create_matcher( text = lv_response ).
+ IF lo_matcher->match( ) = abap_true.
+ rv_token = lo_matcher->get_submatch( 1 ).
+ ENDIF.
ENDMETHOD.
METHOD parse_repo_from_url.
+ CONSTANTS: lc_search_regex TYPE string VALUE 'https?:\/\/(www\.)?github.com\/(.*)$'.
DATA: lo_regex TYPE REF TO cl_abap_regex,
lo_matcher TYPE REF TO cl_abap_matcher.
CREATE OBJECT lo_regex
EXPORTING
- pattern = 'https?:\/\/(www\.)?github.com\/(.*)$'.
+ pattern = lc_search_regex.
lo_matcher = lo_regex->create_matcher( text = iv_url ).
IF lo_matcher->match( ) = abap_true.
|
|
47e9c9d091bef8a194b44c8e25302fd84ecc20c8 | receive pack fixed | receive pack fixed | nununo/abapGit,nununo/abapGit,apex8/abapGit,EduardoCopat/abapGit,EduardoCopat/abapGit,sbcgua/abapGit,sbcgua/abapGit,apex8/abapGit,larshp/abapGit,larshp/abapGit | 0 | mit | ABAP | --- zagit.abap
+++ zagit.abap
@@ -444,6 +444,7 @@
CLASS lcl_pack DEFINITION FINAL.
PUBLIC SECTION.
+
CLASS-METHODS decode IMPORTING iv_data TYPE xstring
RETURNING value(rt_objects) TYPE tt_objects
RAISING lcx_exception.
@@ -466,10 +467,6 @@
CLASS-METHODS sanity_checks IMPORTING it_objects TYPE tt_objects
RETURNING value(rt_latest) TYPE tt_latest
RAISING lcx_exception.
-
-* CLASS-METHODS latest_commit IMPORTING it_objects TYPE tt_objects
-* RETURNING value(rs_object) TYPE st_object
-* RAISING lcx_exception.
CLASS-METHODS latest_objects IMPORTING iv_branch TYPE t_sha1
it_objects TYPE tt_objects
@@ -485,8 +482,8 @@
PRIVATE SECTION.
- CONSTANTS: c_debug_pack TYPE abap_bool VALUE abap_false,
- c_pack_start TYPE x LENGTH 4 VALUE '5041434B', " PACK
+ CONSTANTS: c_pack_start TYPE x LENGTH 4 VALUE '5041434B', " PACK
+ c_debug_pack TYPE abap_bool VALUE abap_false,
c_zlib TYPE x LENGTH 2 VALUE '789C',
c_zlib_hmm TYPE x LENGTH 2 VALUE '7801',
c_version TYPE x LENGTH 4 VALUE '00000002'.
@@ -1331,18 +1328,13 @@
RAISING lcx_exception.
PRIVATE SECTION.
- CONSTANTS: c_debug_http TYPE abap_bool VALUE abap_true,
+ CONSTANTS: c_debug_http TYPE abap_bool VALUE abap_false,
c_cap_list TYPE string VALUE 'side-band-64k no-progress',
c_dot_git TYPE c LENGTH 4 VALUE '.git'.
CLASS-METHODS pkt_string
IMPORTING iv_string TYPE string
RETURNING value(rv_pkt) TYPE string
- RAISING lcx_exception.
-
- CLASS-METHODS pkt_xstring
- IMPORTING iv_xstring TYPE xstring
- RETURNING value(rv_pkt) TYPE xstring
RAISING lcx_exception.
CLASS-METHODS parse
@@ -1361,9 +1353,11 @@
RAISING lcx_exception.
CLASS-METHODS check_http_200
- IMPORTING if_client TYPE REF TO if_http_client
+ IMPORTING ii_client TYPE REF TO if_http_client
RAISING lcx_exception.
+ CLASS-METHODS get_null RETURNING value(rv_c) TYPE char1.
+
ENDCLASS. "lcl_transport DEFINITION
*----------------------------------------------------------------------*
@@ -1373,27 +1367,26 @@
*----------------------------------------------------------------------*
CLASS lcl_transport IMPLEMENTATION.
- METHOD pkt_xstring.
-
- DATA: lv_x2 TYPE x LENGTH 2,
- lv_xstring TYPE xstring,
- lv_string TYPE string.
-
-
- lv_x2 = xstrlen( iv_xstring ).
- lv_string = lv_x2.
- lv_xstring = lcl_convert=>string_to_xstring_utf8( lv_string ).
-
- CONCATENATE lv_xstring iv_xstring INTO rv_pkt IN BYTE MODE.
-
- ENDMETHOD. "pkt_xstring
+ METHOD get_null.
+
+ DATA lv_x(4) TYPE x VALUE '00000000'.
+ DATA lv_z(2) TYPE c.
+
+ FIELD-SYMBOLS <lv_y> TYPE c.
+
+
+ ASSIGN lv_x TO <lv_y> CASTING.
+ lv_z = <lv_y>.
+ rv_c = lv_z(1).
+
+ ENDMETHOD. "get_null
METHOD check_http_200.
DATA: lv_code TYPE i.
- if_client->response->get_status(
+ ii_client->response->get_status(
IMPORTING
code = lv_code ).
IF lv_code <> 200.
@@ -1434,7 +1427,11 @@
SPLIT lv_data AT cl_abap_char_utilities=>newline INTO TABLE lt_result.
LOOP AT lt_result INTO lv_data.
IF lv_data CP '*refs/heads/master*'.
- lv_hash = lv_data+4.
+ IF sy-tabix = 2.
+ lv_hash = lv_data+8.
+ ELSE.
+ lv_hash = lv_data+4.
+ ENDIF.
ENDIF.
ENDLOOP.
@@ -1454,11 +1451,9 @@
DATA: li_client TYPE REF TO if_http_client,
lv_cmd_pkt TYPE string,
lv_line TYPE string,
- lv_x TYPE x,
- lv_pack TYPE xstring,
lv_tmp TYPE xstring,
lv_xstring TYPE xstring,
- lv_code TYPE i,
+ lv_string TYPE string,
lv_buffer TYPE string,
lv_branch TYPE t_sha1,
lv_repo TYPE string.
@@ -1477,7 +1472,7 @@
iv_service = 'receive'
IMPORTING
ei_client = li_client
- ev_branch = lv_branch ).
+ ev_branch = lv_branch ).
****************************
@@ -1491,43 +1486,36 @@
name = 'Content-Type'
value = 'Content-Type: application/x-git-receive-pack-request' ). "#EC NOTEXT
-* todo, test report-status capability
-
lv_line = lv_branch &&
` ` &&
iv_commit &&
` ` &&
'refs/heads/master' &&
-* ` ` &&
-* c_cap_list &&
+ get_null( ) &&
+ ` ` &&
+ 'report-status' &&
cl_abap_char_utilities=>newline. "#EC NOTEXT
lv_cmd_pkt = pkt_string( lv_line ).
- lv_buffer = lv_cmd_pkt
- && '0000'
- && cl_abap_char_utilities=>newline.
+ lv_buffer = lv_cmd_pkt && '0000'.
lv_tmp = lcl_convert=>string_to_xstring_utf8( lv_buffer ).
-* lv_x = '01'.
-* CONCATENATE lv_x iv_pack INTO lv_pack IN BYTE MODE. " band
-* lv_xstring = pkt_xstring( lv_pack ).
-break-point.
CONCATENATE lv_tmp iv_pack INTO lv_xstring IN BYTE MODE.
li_client->request->set_data( lv_xstring ).
+
li_client->send( ).
li_client->receive( ).
- li_client->response->get_status(
- IMPORTING
- code = lv_code ).
+ check_http_200( li_client ).
lv_xstring = li_client->response->get_data( ).
li_client->close( ).
-* todo, try calling parse to check xstring
- BREAK-POINT.
-
-* expect "000Aunpack ok"
+ lv_string = lcl_convert=>xstring_to_string_utf8( lv_xstring ).
+ WRITE: / lv_string.
+ IF NOT lv_string CP '*unpack ok*'.
+ BREAK-POINT.
+ ENDIF.
ENDMETHOD. "receive_pack
@@ -1789,7 +1777,7 @@
lv_time = lcl_time=>get( ).
* blob
- lv_blob = lcl_convert=>string_to_xstring_utf8( 'this is the readme' ). "#EC NOTEXT
+ lv_blob = lcl_convert=>string_to_xstring_utf8( 'it works, yes new' ). "#EC NOTEXT
* tree
CLEAR ls_node.
|
End of preview.
DiffPack is the bigcode/commitpack dataset except diff'd between the old and new data.
- Downloads last month
- 12