Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "jerodsanto", "id": 8212, "node_id": "MDQ6VXNlcjgyMTI=", "avatar_url": "https://avatars.githubusercontent.com/u/8212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jerodsanto", "html_url": "https://github.com/jerodsanto", "followers_url": "https://api.github.com/users/jerodsanto/followers", "following_url": "https://api.github.com/users/jerodsanto/following{/other_user}", "gists_url": "https://api.github.com/users/jerodsanto/gists{/gist_id}", "starred_url": "https://api.github.com/users/jerodsanto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jerodsanto/subscriptions", "organizations_url": "https://api.github.com/users/jerodsanto/orgs", "repos_url": "https://api.github.com/users/jerodsanto/repos", "events_url": "https://api.github.com/users/jerodsanto/events{/privacy}", "received_events_url": "https://api.github.com/users/jerodsanto/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/14/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/13/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "madisvain", "id": 727994, "node_id": "MDQ6VXNlcjcyNzk5NA==", "avatar_url": "https://avatars.githubusercontent.com/u/727994?v=4", "gravatar_id": "", "url": "https://api.github.com/users/madisvain", "html_url": "https://github.com/madisvain", "followers_url": "https://api.github.com/users/madisvain/followers", "following_url": "https://api.github.com/users/madisvain/following{/other_user}", "gists_url": "https://api.github.com/users/madisvain/gists{/gist_id}", "starred_url": "https://api.github.com/users/madisvain/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/madisvain/subscriptions", "organizations_url": "https://api.github.com/users/madisvain/orgs", "repos_url": "https://api.github.com/users/madisvain/repos", "events_url": "https://api.github.com/users/madisvain/events{/privacy}", "received_events_url": "https://api.github.com/users/madisvain/received_events", "type": "User", "site_admin": false }

[]

[]

[ "As to the first one, I believe that is due to unpredictable ordering with dictionaries. Joins are stored using a dictionary, so whether it joins on Blog first or EntryTag first is up in the air -- this one is a bad test case.\n\nAs to the count failure -- that's pretty odd. Looks like you're ending up with 2 extra entries per blog -- canyou do any more digging?\n", "Well it's not that simple. I spent some time on this - this seems really weird. There are 10 entries for blog in the database if I check. But somehow it seems to return 12 yes. As I said really odd.\n\nI will look into this as soon as I get some time. I want to help make this project better.\nI think peewee rocks. It's simple, fast ... fantastic. Hope to use it in some of my future projects.\n", "While the one test failure is obnoxious (sql / dict ordering), I haven't been able to reproduce at all the other. Closing for now, but feel free to reopen if you come up w/any ideas.\n", "I'm encountering the same failure with `test_count`, with 200 entries expected but 240 found. But the problem isn't that there are two extra blog rows in the database. Rather there are only 10 blog rows, as expected, but the first two get iterated over twice (see the annotated test output at the end of this report).\n\nTo see what's happening, consider the test corresponding test code:\n\n``` python\n # original from tests.py, line ~606\n for blog in SelectQuery(Blog):\n for i in xrange(20):\n self.create_entry(title='entry%d' % i, blog=blog)\n```\n\nThere's an outer loop over the results of a select query and, within this loop, an inner loop that creates 20 Entry rows for the currently selected Blog row. The outer loop is lazy, however, which means the underlying SELECT statement is held open during the entire loop. This has an unfortunate interaction with the inner loop's autocommited INSERT. When `self.create_entry` finally winds its way down to a `peewee.Database.execute` call on the given INSERT statement, the latter method finishes the operation with a `commit` on the database connection. This is where things go wrong.\n\nThe problem is that when certain versions of pysqlite commit a connection, they also [reset all statements _and cursors_ open on that connection](http://article.gmane.org/gmane.comp.python.db.pysqlite.user/2217). That means the SELECT statement behind the outer loop gets reset and replays the first two rows. (Why not just the first row? Because pysqlite fetches one row ahead; by the time the first line of the inner loop executes, the second blog row has already been fetched and so it, too, will get replayed.)\n\nHere are two possible workarounds:\n\n``` python\n # fix 1: read blogs eagerly\n for blog in list(SelectQuery(Blog)):\n for i in xrange(20):\n self.create_entry(title='entry%d' % i, blog=blog)\n\n # fix 2: keep laziness but corral commit w/ explicit transaction\n def create_blog_entries():\n for blog in SelectQuery(Blog):\n for i in xrange(20):\n self.create_entry(title='entry%d' % i, blog=blog)\n test_db.commit_on_success(create_blog_entries)()\n```\n\nI hope that explanation makes sense.\n\nCheers,\nTom\n\nP.S. As promised, here's the debug log that shows what statements get executed when the problem occurs. I've added annotations to make it easier to correlate the statements with the original test code.\n\n```\n\n[thor@helium peewee (master)]$ nosetests -v tests:ModelTestCase\ntest_cloning (tests.ModelTestCase) ... ok\ntest_count (tests.ModelTestCase) ... FAIL\ntest_count_with_joins_issue27 (tests.ModelTestCase) ... ok\ntest_delete (tests.ModelTestCase) ... ok\ntest_inner_joins (tests.ModelTestCase) ... ok\ntest_insert (tests.ModelTestCase) ... ok\ntest_multi_joins (tests.ModelTestCase) ... ok\ntest_outer_joins (tests.ModelTestCase) ... ok\ntest_pagination (tests.ModelTestCase) ... ok\ntest_update (tests.ModelTestCase) ... ok\n\n======================================================================\nFAIL: test_count (tests.ModelTestCase)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n File \"/tmp/peewee/tests.py\", line 614, in test_count\n self.assertEqual(count, 200)\nAssertionError: 240 != 200\n-------------------- >> begin captured logging << --------------------\n\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"membership\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"member\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"team\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"relationship\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"users\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"entrytag\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"entry\";', None)\npeewee.logger: DEBUG: ('DROP TABLE IF EXISTS \"blog\";', None)\n\npeewee.logger: DEBUG: ('CREATE TABLE \"blog\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"title\" VARCHAR(255) NOT NULL);', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"entry\" (\"pk\" INTEGER NOT NULL PRIMARY KEY, \"title\" VARCHAR(50) NOT NULL, \"content\" TEXT NOT NULL, \"pub_date\" DATETIME, \"blog_id\" INTEGER NOT NULL REFERENCES blog (id) ON DELETE CASCADE);', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"entry_blog_id\" ON \"entry\"(\"blog_id\");', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"entrytag\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"tag\" VARCHAR(50) NOT NULL, \"entry_id\" INTEGER NOT NULL REFERENCES entry (pk));', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"entrytag_entry_id\" ON \"entrytag\"(\"entry_id\");', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"users\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"username\" VARCHAR(50) NOT NULL, \"blog_id\" INTEGER REFERENCES blog (id), \"active\" SMALLINT NOT NULL);', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"users_blog_id\" ON \"users\"(\"blog_id\");', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"users_active\" ON \"users\"(\"active\");', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"relationship\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"from_user_id\" INTEGER NOT NULL REFERENCES users (id), \"to_user_id\" INTEGER NOT NULL REFERENCES users (id));', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"relationship_to_user_id\" ON \"relationship\"(\"to_user_id\");', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"relationship_from_user_id\" ON \"relationship\"(\"from_user_id\");', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"team\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"name\" VARCHAR(255) NOT NULL);', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"member\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"username\" VARCHAR(255) NOT NULL);', None)\npeewee.logger: DEBUG: ('CREATE TABLE \"membership\" (\"id\" INTEGER NOT NULL PRIMARY KEY, \"team_id\" INTEGER NOT NULL REFERENCES team (id), \"member_id\" INTEGER NOT NULL REFERENCES member (id));', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"membership_member_id\" ON \"membership\"(\"member_id\");', None)\npeewee.logger: DEBUG: ('CREATE INDEX \"membership_team_id\" ON \"membership\"(\"team_id\");', None)\n\n\n\n# From tests.py:\n# for i in xrange(10):\n# self.create_blog(title='a%d' % i)\n\npeewee.logger: DEBUG: ('INSERT INTO \"blog\" (\"title\") VALUES (?)', [u'a0'])\n... 8 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"blog\" (\"title\") VALUES (?)', [u'a9'])\n\n\n# From tests.py:\n# count = SelectQuery(Blog).count()\n# self.assertEqual(count, 10)\n# \n# count = Blog.select().count()\n# self.assertEqual(count, 10)\n\npeewee.logger: DEBUG: ('SELECT COUNT(id) FROM \"blog\"', [])\npeewee.logger: DEBUG: ('SELECT COUNT(id) FROM \"blog\"', [])\n\n\n\n# From tests.py:\n# for blog in SelectQuery(Blog):\n# for i in xrange(20):\n# self.create_entry(title='entry%d' % i, blog=blog)\n\npeewee.logger: DEBUG: ('SELECT \"id\", \"title\" FROM \"blog\"', [])\n\n# NOTE that the first two rows get replayed\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [1, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [2, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [1, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [2, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [3, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [4, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [5, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [6, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [7, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [8, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [9, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('INSERT INTO \"entry\" (\"blog_id\",\"content\",\"pub_date\",\"title\") VALUES (?,?,?,?)', [10, '', None, u'entry0'])\n... 19 lines omitted ...\npeewee.logger: DEBUG: ('SELECT COUNT(pk) FROM \"entry\"', [])\n--------------------- >> end captured logging << ---------------------\n\n----------------------------------------------------------------------\nRan 10 tests in 56.481s\n\nFAILED (failures=1)\n```\n", "Brilliant! I figured it went somewhere along those lines but could not figure out why just blog 0 & 1 were duplicated -- thank you for the report, it was educational!\n", "per your suggestion, eb9183529eb7b88e189ebe3447a5299ae2b950a2\n", "I thought it was something special to do with sqlite but could never figure this out. Thank you very much for explaining this.\n", "@tmoertel's comment did the trick for me. Thank you.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/12/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jerodsanto", "id": 8212, "node_id": "MDQ6VXNlcjgyMTI=", "avatar_url": "https://avatars.githubusercontent.com/u/8212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jerodsanto", "html_url": "https://github.com/jerodsanto", "followers_url": "https://api.github.com/users/jerodsanto/followers", "following_url": "https://api.github.com/users/jerodsanto/following{/other_user}", "gists_url": "https://api.github.com/users/jerodsanto/gists{/gist_id}", "starred_url": "https://api.github.com/users/jerodsanto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jerodsanto/subscriptions", "organizations_url": "https://api.github.com/users/jerodsanto/orgs", "repos_url": "https://api.github.com/users/jerodsanto/repos", "events_url": "https://api.github.com/users/jerodsanto/events{/privacy}", "received_events_url": "https://api.github.com/users/jerodsanto/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not going to merge this since you can accomplish the same using `Q` objects:\n\n```\nNullModel.select().where(~Q(char_field__is=None))\n```\n\nI added this to the testcase to show how it is possible:\nhttps://github.com/coleifer/peewee/commit/08dabe0d6b82701c48022e5d7a758d29bfaea154\n", "Fair enough, though you could make the same case for the `ne` operator.\n", "Q objects don't appear to exist in my version of Peewee. How can I accomplish the same behavior without them? I have models like:\n\nclass Owner(Model):\n ...\nclass Ownable(Model):\n owner = ForeignKeyField(Owner, null=True, default=None)\n\nAnd I wish to obtain a list of all Ownables which do not have an owner.\n", "You would do `Ownable.select().where(Ownable.owner >> None)` -- if you want not null: `~(Ownable.owner >> None)`\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/11/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/11", "html_url": "https://github.com/coleifer/peewee/pull/11", "diff_url": "https://github.com/coleifer/peewee/pull/11.diff", "patch_url": "https://github.com/coleifer/peewee/pull/11.patch", "merged_at": null }

{ "login": "coleifer", "id": 119974, "node_id": "MDQ6VXNlcjExOTk3NA==", "avatar_url": "https://avatars.githubusercontent.com/u/119974?v=4", "gravatar_id": "", "url": "https://api.github.com/users/coleifer", "html_url": "https://github.com/coleifer", "followers_url": "https://api.github.com/users/coleifer/followers", "following_url": "https://api.github.com/users/coleifer/following{/other_user}", "gists_url": "https://api.github.com/users/coleifer/gists{/gist_id}", "starred_url": "https://api.github.com/users/coleifer/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/coleifer/subscriptions", "organizations_url": "https://api.github.com/users/coleifer/orgs", "repos_url": "https://api.github.com/users/coleifer/repos", "events_url": "https://api.github.com/users/coleifer/events{/privacy}", "received_events_url": "https://api.github.com/users/coleifer/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This has been fixed in 3f6336bba6d3a0bda691fe3e333767008c2308bb\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/10/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "matthewturk", "id": 89019, "node_id": "MDQ6VXNlcjg5MDE5", "avatar_url": "https://avatars.githubusercontent.com/u/89019?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matthewturk", "html_url": "https://github.com/matthewturk", "followers_url": "https://api.github.com/users/matthewturk/followers", "following_url": "https://api.github.com/users/matthewturk/following{/other_user}", "gists_url": "https://api.github.com/users/matthewturk/gists{/gist_id}", "starred_url": "https://api.github.com/users/matthewturk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matthewturk/subscriptions", "organizations_url": "https://api.github.com/users/matthewturk/orgs", "repos_url": "https://api.github.com/users/matthewturk/repos", "events_url": "https://api.github.com/users/matthewturk/events{/privacy}", "received_events_url": "https://api.github.com/users/matthewturk/received_events", "type": "User", "site_admin": false }

[ { "id": 191752, "node_id": "MDU6TGFiZWwxOTE3NTI=", "url": "https://api.github.com/repos/coleifer/peewee/labels/Design%20decision", "name": "Design decision", "color": "02d7e1", "default": false, "description": null } ]

[]

[ "Well, it really just looks like it's searching for a pk that evaluates to a nonzero...it will be tricky since the postgresql adapter checks the value of a sequence for the last insert id. Otherwise its just that bit in the BaseModel that checks for a PrimaryKeyField.\n\nOn the other hand, a non-integer primary key can be more expensive to query on and join on... might be worthwhile to implement instead the ability to add unique indexes and have something along the lines of the workaround suggested here:\nhttp://stackoverflow.com/questions/3936182/using-a-uuid-as-a-primary-key-in-django-models-generic-relations-impact/3944247#3944247\n", "Interesting point, and one I didn't know about. I'll take a look into it -- thank you!\n", "I've added ability to specify a unique keyword arg when creating fields:\nhttps://github.com/coleifer/peewee/commit/c3460e32ae375984c97f28c6ec8f7b65a8ead8cf\n", "This is awesome -- thank you very much!\n", "Glad that commit helps -- I'm actually gonna leave this one open for now as I agree it _should_ be possible to use a TextField or something else for a primary key.\n", "+1 , in some case it would be important, agree it should be possible to use a CharField\n", "+1 to a primarykey CharField\n", "Also relevant: biginteger fields\n", "Started working on this in a branch: feature/non-integer-pk -- there are some interesting ramifications:\n- primary keys may not be autoincrementing which affects default save() and create() behavior\n- primary keys won't necessarily have a sequence so postgresql will need to have different last_insert_id behavior if so\n- foreign keys need to match the column type of the primary key\n", "Alright! I think I have gotten this working. It can be seen in the field refactor branch:\n\nhttps://github.com/coleifer/peewee/tree/feature/field-refactor\n\nFor a diff:\n\nhttps://github.com/coleifer/peewee/compare/feature/field-refactor\n\nTests are passing in sqlite and postgresql. Saving models is a little bit different when using a non-integer autoincrement pk, basically you have to use the .create() or .save(force_insert=True) to save new instances otherwise the existance of a pk value will make the orm think you have saved it before and want to update it. That is the main gotcha.\n\nWould love to get some feedback before merging, however\n", "Merged, syntax is\n\n``` python\n\nclass NonIntPK(TestModel):\n id = PrimaryKeyField(column_class=VarCharColumn)\n name = CharField(max_length=10)\n```\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/9/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jerodsanto", "id": 8212, "node_id": "MDQ6VXNlcjgyMTI=", "avatar_url": "https://avatars.githubusercontent.com/u/8212?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jerodsanto", "html_url": "https://github.com/jerodsanto", "followers_url": "https://api.github.com/users/jerodsanto/followers", "following_url": "https://api.github.com/users/jerodsanto/following{/other_user}", "gists_url": "https://api.github.com/users/jerodsanto/gists{/gist_id}", "starred_url": "https://api.github.com/users/jerodsanto/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jerodsanto/subscriptions", "organizations_url": "https://api.github.com/users/jerodsanto/orgs", "repos_url": "https://api.github.com/users/jerodsanto/repos", "events_url": "https://api.github.com/users/jerodsanto/events{/privacy}", "received_events_url": "https://api.github.com/users/jerodsanto/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is now fixed -- https://github.com/coleifer/peewee/commit/2b10102d6e4d41b2d99e16be1d83fcd3983e55a0\n", "Awesome, thanks so much!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/8/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "peterbe", "id": 26739, "node_id": "MDQ6VXNlcjI2NzM5", "avatar_url": "https://avatars.githubusercontent.com/u/26739?v=4", "gravatar_id": "", "url": "https://api.github.com/users/peterbe", "html_url": "https://github.com/peterbe", "followers_url": "https://api.github.com/users/peterbe/followers", "following_url": "https://api.github.com/users/peterbe/following{/other_user}", "gists_url": "https://api.github.com/users/peterbe/gists{/gist_id}", "starred_url": "https://api.github.com/users/peterbe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/peterbe/subscriptions", "organizations_url": "https://api.github.com/users/peterbe/orgs", "repos_url": "https://api.github.com/users/peterbe/repos", "events_url": "https://api.github.com/users/peterbe/events{/privacy}", "received_events_url": "https://api.github.com/users/peterbe/received_events", "type": "User", "site_admin": true }

[]

[]

[ "cool, pushed a testcase indicating failure, working on fix\n", "Fix pushed in: https://github.com/coleifer/peewee/commit/981c291a83d6cb1494dfa43845db1fda56fe4028\n\nI'm looking at scrapping the whole Meta thing as a way of munging settings because the whole thing feels fragile and janky. May be an API update coming in the next couple days, but this should work for you.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/7/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "JshWright", "id": 69920, "node_id": "MDQ6VXNlcjY5OTIw", "avatar_url": "https://avatars.githubusercontent.com/u/69920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JshWright", "html_url": "https://github.com/JshWright", "followers_url": "https://api.github.com/users/JshWright/followers", "following_url": "https://api.github.com/users/JshWright/following{/other_user}", "gists_url": "https://api.github.com/users/JshWright/gists{/gist_id}", "starred_url": "https://api.github.com/users/JshWright/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JshWright/subscriptions", "organizations_url": "https://api.github.com/users/JshWright/orgs", "repos_url": "https://api.github.com/users/JshWright/repos", "events_url": "https://api.github.com/users/JshWright/events{/privacy}", "received_events_url": "https://api.github.com/users/JshWright/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This would be great. Ubuntu seemed to want Postgres installed in order to satisfy psycopg through pip. I'm currently just commenting out the import locally :(\n", "Issue fixed in https://github.com/coleifer/peewee/commit/5c5d6933e383748a99cdf5e092076a61884feebb\n\nThanks for reporting!!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/6/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/6", "html_url": "https://github.com/coleifer/peewee/pull/6", "diff_url": "https://github.com/coleifer/peewee/pull/6.diff", "patch_url": "https://github.com/coleifer/peewee/pull/6.patch", "merged_at": null }

{ "login": "JshWright", "id": 69920, "node_id": "MDQ6VXNlcjY5OTIw", "avatar_url": "https://avatars.githubusercontent.com/u/69920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JshWright", "html_url": "https://github.com/JshWright", "followers_url": "https://api.github.com/users/JshWright/followers", "following_url": "https://api.github.com/users/JshWright/following{/other_user}", "gists_url": "https://api.github.com/users/JshWright/gists{/gist_id}", "starred_url": "https://api.github.com/users/JshWright/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JshWright/subscriptions", "organizations_url": "https://api.github.com/users/JshWright/orgs", "repos_url": "https://api.github.com/users/JshWright/repos", "events_url": "https://api.github.com/users/JshWright/events{/privacy}", "received_events_url": "https://api.github.com/users/JshWright/received_events", "type": "User", "site_admin": false }

[]

[]

[ "https://github.com/coleifer/peewee/commit/5c5d6933e383748a99cdf5e092076a61884feebb\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/5/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pplante", "id": 58743, "node_id": "MDQ6VXNlcjU4NzQz", "avatar_url": "https://avatars.githubusercontent.com/u/58743?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pplante", "html_url": "https://github.com/pplante", "followers_url": "https://api.github.com/users/pplante/followers", "following_url": "https://api.github.com/users/pplante/following{/other_user}", "gists_url": "https://api.github.com/users/pplante/gists{/gist_id}", "starred_url": "https://api.github.com/users/pplante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pplante/subscriptions", "organizations_url": "https://api.github.com/users/pplante/orgs", "repos_url": "https://api.github.com/users/pplante/repos", "events_url": "https://api.github.com/users/pplante/events{/privacy}", "received_events_url": "https://api.github.com/users/pplante/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I noticed some debug statements were left in, got them out. Squashed a few bugs I also introduced.\n", "i'm having a hard time telling what's new because you changed all my 4-space indentation two 2-space, which effectively shows every line as different.\n\nif i can have the changes in the minimum of patches i'll gladly merge\n", "I closed this because some of my changes are incompatible right now. I will see if I can find a different way to do some of it.\n", "For what its worth, I've got MySQL (and postgresql) support in my repo!\n", "That's awesome to hear. Thanks!\nOn Jul 17, 2011 8:18 PM, \"coleifer\" <\[email protected]>\nwrote:\n\n> For what its worth, I've got MySQL (and postgresql) support in my repo!\n> \n> ## \n> \n> Reply to this email directly or view it on GitHub:\n> https://github.com/coleifer/peewee/pull/4#issuecomment-1592616\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/4/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/4", "html_url": "https://github.com/coleifer/peewee/pull/4", "diff_url": "https://github.com/coleifer/peewee/pull/4.diff", "patch_url": "https://github.com/coleifer/peewee/pull/4.patch", "merged_at": null }

{ "login": "JshWright", "id": 69920, "node_id": "MDQ6VXNlcjY5OTIw", "avatar_url": "https://avatars.githubusercontent.com/u/69920?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JshWright", "html_url": "https://github.com/JshWright", "followers_url": "https://api.github.com/users/JshWright/followers", "following_url": "https://api.github.com/users/JshWright/following{/other_user}", "gists_url": "https://api.github.com/users/JshWright/gists{/gist_id}", "starred_url": "https://api.github.com/users/JshWright/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JshWright/subscriptions", "organizations_url": "https://api.github.com/users/JshWright/orgs", "repos_url": "https://api.github.com/users/JshWright/repos", "events_url": "https://api.github.com/users/JshWright/events{/privacy}", "received_events_url": "https://api.github.com/users/JshWright/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I applied the keyword args change, thanks!\n", "The keyword args change uses the \"native\" ternary, so if your goal is to maintain Python 2.4 compatibility (which I assume is the reason for not pulling the other commit), you'll probably want to fix that.\n", "d'oh. you just couldn't use the old-fashioned one in your patch, could you?\n", "Or I could have just used the short-circuit like you did... Guess I have ternary on the brain from the previous commit.\n\nIn any case, this certainly meets my needs. Thanks for pulling it.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/3/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/3", "html_url": "https://github.com/coleifer/peewee/pull/3", "diff_url": "https://github.com/coleifer/peewee/pull/3.diff", "patch_url": "https://github.com/coleifer/peewee/pull/3.patch", "merged_at": null }

{ "login": "ghost", "id": 10137, "node_id": "MDQ6VXNlcjEwMTM3", "avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghost", "html_url": "https://github.com/ghost", "followers_url": "https://api.github.com/users/ghost/followers", "following_url": "https://api.github.com/users/ghost/following{/other_user}", "gists_url": "https://api.github.com/users/ghost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghost/subscriptions", "organizations_url": "https://api.github.com/users/ghost/orgs", "repos_url": "https://api.github.com/users/ghost/repos", "events_url": "https://api.github.com/users/ghost/events{/privacy}", "received_events_url": "https://api.github.com/users/ghost/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hmm...good question\n", "Added support for MySQL and have only one test failure which should be fixed soon.\n", "postgresql support added. all tests passing on sqlite, mysql and psql!\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wearpants", "id": 505344, "node_id": "MDQ6VXNlcjUwNTM0NA==", "avatar_url": "https://avatars.githubusercontent.com/u/505344?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wearpants", "html_url": "https://github.com/wearpants", "followers_url": "https://api.github.com/users/wearpants/followers", "following_url": "https://api.github.com/users/wearpants/following{/other_user}", "gists_url": "https://api.github.com/users/wearpants/gists{/gist_id}", "starred_url": "https://api.github.com/users/wearpants/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wearpants/subscriptions", "organizations_url": "https://api.github.com/users/wearpants/orgs", "repos_url": "https://api.github.com/users/wearpants/repos", "events_url": "https://api.github.com/users/wearpants/events{/privacy}", "received_events_url": "https://api.github.com/users/wearpants/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Good point, this definitely looks like something that'll need fixing. Let me look into it.\n", "Fixed in https://github.com/coleifer/peewee/commit/466d6d7c41d4f888d6c3db5e7de55785b2c41940\n\nCheck the test case for examples.\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/1/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }