Optimize Docker launcher's i18n setup, environment handling, and add automatic temp folder generation (#193)

* feat: Create TEMP_DIR if it doesn't exist

* chore: Update Docker Compose configuration and Dockerfile for MindSearch Docker launcher

* feat: Update Docker Compose configuration and Dockerfile modifying logic

* feat: Add new translations for current containers stop failure and container stopped and removed

* feat: Update Docker Compose configuration and Dockerfile for MindSearch Docker launcher

docker/msdl/__main__.py

@@ -162,6 +162,11 @@ def main():
     signal.signal(signal.SIGTERM, signal_handler)
 
     try:
+        # Check if TEMP_DIR exists, if not, create it
+        if not TEMP_DIR.exists():
+            TEMP_DIR.mkdir(parents=True, exist_ok=True)
+            print(t("TEMP_DIR_CREATED", dir=str(TEMP_DIR)))
+
         check_docker_install()
 
         # Get user choices

docker/msdl/docker_manager.py

@@ -48,39 +48,78 @@ def check_docker_install():
 
 def stop_and_remove_containers():
     docker_compose_cmd = get_docker_command()
+    compose_file = os.path.join(TEMP_DIR, "docker-compose.yaml")
+
+    # Read the docker-compose.yaml file
     try:
+        with open(compose_file, "r") as file:
+            compose_config = yaml.safe_load(file)
+    except Exception as e:
+        print(t("COMPOSE_FILE_READ_ERROR", error=str(e)))
+        return
+
+    # Get project name and service names
+    project_name = compose_config.get("name", "mindsearch")
+    service_names = list(compose_config.get("services", {}).keys())
+
+    # Use only the project name as the container prefix
+    container_prefix = f"{project_name}_"
+
+    try:
+        # 1. Try to stop containers using the current docker-compose.yaml
         subprocess.run(
-            docker_compose_cmd
-            + [
-                "-f",
-                os.path.join(TEMP_DIR, "docker-compose.yaml"),
-                "down",
-                "-v",
-            ],
+            docker_compose_cmd + ["-f", compose_file, "down", "-v", "--remove-orphans"],
+            check=True,
+        )
+    except subprocess.CalledProcessError:
+        print(t("CURRENT_COMPOSE_STOP_FAILED"))
+
+    # 2. Attempt to clean up potentially existing containers, regardless of the success of the previous step
+    try:
+        # List all containers (including stopped ones)
+        result = subprocess.run(
+            ["docker", "ps", "-a", "--format", "{{.Names}}"],
             check=True,
+            capture_output=True,
+            text=True,
         )
-        print(t("CONTAINERS_STOPPED"))
+        all_containers = result.stdout.splitlines()
+
+        # 3. Filter out containers belonging to our project
+        project_containers = [
+            c
+            for c in all_containers
+            if c.startswith(container_prefix)
+            or any(c == f"{project_name}-{service}" for service in service_names)
+        ]
+
+        if project_containers:
+            # 4. Force stop and remove these containers
+            for container in project_containers:
+                try:
+                    subprocess.run(["docker", "stop", container], check=True)
+                    subprocess.run(["docker", "rm", "-f", container], check=True)
+                    print(t("CONTAINER_STOPPED_AND_REMOVED", container=container))
+                except subprocess.CalledProcessError as e:
+                    print(t("CONTAINER_STOP_ERROR", container=container, error=str(e)))
+
+        # 5. Clean up potentially leftover networks
+        try:
+            subprocess.run(["docker", "network", "prune", "-f"], check=True)
+            print(t("NETWORKS_PRUNED"))
+        except subprocess.CalledProcessError as e:
+            print(t("NETWORK_PRUNE_ERROR", error=str(e)))
+
     except subprocess.CalledProcessError as e:
-        print(t("CONTAINER_STOP_ERROR", error=str(e)))
+        print(t("DOCKER_LIST_ERROR", error=str(e)))
+
+    print(t("CONTAINERS_STOPPED_AND_REMOVED"))
 
 
 def run_docker_compose():
     docker_compose_cmd = get_docker_command()
     try:
-        print(t("BUILDING_IMAGES"))
-        subprocess.run(
-            docker_compose_cmd
-            + [
-                "-f",
-                os.path.join(TEMP_DIR, "docker-compose.yaml"),
-                "--env-file",
-                os.path.join(TEMP_DIR, ".env"),
-                "build",
-            ],
-            check=True,
-        )
-        print(t("IMAGES_BUILT"))
-        print(t("STARTING_CONTAINERS"))
+        print(t("STARTING_CONTAINERS_WITH_BUILD"))
         subprocess.run(
             docker_compose_cmd
             + [
@@ -90,6 +129,7 @@ def run_docker_compose():
                 os.path.join(TEMP_DIR, ".env"),
                 "up",
                 "-d",
+                "--build",
             ],
             check=True,
         )

docker/msdl/i18n.py

@@ -3,18 +3,20 @@
 import os
 import i18n
 import locale
+from dotenv import load_dotenv, set_key, find_dotenv
 from msdl.config import TRANSLATIONS_DIR, ENV_FILE_PATH
 
 
 def get_env_variable(var_name, default=None):
-    if os.path.exists(ENV_FILE_PATH):
-        with open(ENV_FILE_PATH, "r") as env_file:
-            for line in env_file:
-                if line.startswith(f"{var_name}="):
-                    return line.strip().split("=", 1)[1]
+    load_dotenv(ENV_FILE_PATH)
     return os.getenv(var_name, default)
 
 
+def set_env_variable(var_name, value):
+    dotenv_file = find_dotenv(ENV_FILE_PATH)
+    set_key(dotenv_file, var_name, value)
+
+
 def get_system_language():
     try:
         return locale.getlocale()[0].split("_")[0]
@@ -28,10 +30,12 @@ def setup_i18n():
     i18n.set("file_format", "yaml")
 
     env_language = get_env_variable("LAUNCHER_INTERACTION_LANGUAGE")
-    if env_language:
-        i18n.set("locale", env_language)
-    else:
-        i18n.set("locale", get_system_language())
+    if not env_language:
+        system_language = get_system_language()
+        set_env_variable("LAUNCHER_INTERACTION_LANGUAGE", system_language)
+        env_language = system_language
+
+    i18n.set("locale", env_language)
 
 
 def t(key, **kwargs):

docker/msdl/translations/en.yaml

@@ -12,6 +12,7 @@ en:
   BUILDING_IMAGES: "Starting to build Docker images..."
   IMAGES_BUILT: "Docker images built successfully"
   STARTING_CONTAINERS: "Starting Docker containers..."
+  STARTING_CONTAINERS_WITH_BUILD: "Starting to build and start Docker containers..."
   CONTAINERS_STARTED: "Docker containers started successfully"
   DOCKER_ERROR: "Error while building or starting Docker containers: %{error}"
   DOCKER_OUTPUT: "Docker command output:"
@@ -48,3 +49,10 @@ en:
   UNKNOWN_MODEL_TYPE: "Unknown model type: %{model_type}"
   BACKEND_DOCKERFILE_COPIED: "Backend Dockerfile copied from %{source_path} to %{dest_path}"
   FRONTEND_DOCKERFILE_COPIED: "Frontend Dockerfile copied from %{source_path} to %{dest_path}"
+  TEMP_DIR_CREATED: "Temporary directory created at %{dir}"
+  CURRENT_COMPOSE_STOP_FAILED: "Current containers stop failed"
+  CONTAINER_STOPPED_AND_REMOVED: "Container stopped and removed"
+  NETWORKS_PRUNED: "Corresponding Docker networks pruned"
+  NETWORK_PRUNE_ERROR: "Error pruning corresponding Docker networks: %{error}"
+  DOCKER_LIST_ERROR: "Error listing Docker containers: %{error}"
+  CONTAINERS_STOPPED_AND_REMOVED: "Docker containers stopped and removed"

docker/msdl/translations/zh_CN.yaml

@@ -12,6 +12,7 @@ zh_CN:
   BUILDING_IMAGES: "开始构建Docker镜像..."
   IMAGES_BUILT: "Docker镜像构建成功"
   STARTING_CONTAINERS: "开始启动Docker容器..."
+  STARTING_CONTAINERS_WITH_BUILD: "开始构建并启动Docker容器..."
   CONTAINERS_STARTED: "Docker 容器已成功启动"
   DOCKER_ERROR: "构建或启动 Docker 容器时出错：%{error}"
   DOCKER_OUTPUT: "Docker 命令输出："
@@ -48,3 +49,10 @@ zh_CN:
   UNKNOWN_MODEL_TYPE: "未知的模型类型：%{model_type}"
   BACKEND_DOCKERFILE_COPIED: "后端 Dockerfile 已经从 %{source_path} 复制为 %{dest_path}"
   FRONTEND_DOCKERFILE_COPIED: "前端 Dockerfile 已经从 %{source_path} 复制为 %{dest_path}"
+  TEMP_DIR_CREATED: "已在 %{dir} 创建临时目录"
+  CURRENT_COMPOSE_STOP_FAILED: "当前的容器停止失败"
+  CONTAINER_STOPPED_AND_REMOVED: "容器已停止并删除"
+  NETWORKS_PRUNED: "已清理对应的Docker网络"
+  NETWORK_PRUNE_ERROR: "清理对应的Docker网络时出错：%{error}"
+  DOCKER_LIST_ERROR: "列出 Docker 容器时出错：%{error}"
+  CONTAINERS_STOPPED_AND_REMOVED: "已停止并删除 Docker 容器"

docker/msdl/utils.py

@@ -120,6 +120,9 @@ def modify_docker_compose(selected_dockerfile, backend_language, model_format):
     with docker_compose_path.open("r") as file:
         compose_data = yaml.safe_load(file)
 
+    # Set the name of the project (Docker Compose will convert it to lowercase)
+    compose_data["name"] = "mindsearch"
+
     backend_service = compose_data["services"]["backend"]
 
     if "env_file" not in backend_service:
@@ -128,10 +131,14 @@ def modify_docker_compose(selected_dockerfile, backend_language, model_format):
         backend_service["env_file"].append(".env")
 
     command = f"python -m mindsearch.app --lang {backend_language} --model_format {model_format}"
+
     if selected_dockerfile == CLOUD_LLM_DOCKERFILE:
         if "deploy" in backend_service:
             del backend_service["deploy"]
         backend_service["command"] = command
+        # Use Cloud LLM Dockerfile: Remove volumes
+        if "volumes" in backend_service:
+            del backend_service["volumes"]
     elif selected_dockerfile == LOCAL_LLM_DOCKERFILE:
         if "deploy" not in backend_service:
             backend_service["deploy"] = {
@@ -144,6 +151,8 @@ def modify_docker_compose(selected_dockerfile, backend_language, model_format):
                 }
             }
         backend_service["command"] = command
+        # Use Local LLM Dockerfile: Add volume for cache
+        backend_service["volumes"] = ["/root/.cache:/root/.cache"]
     else:
         raise ValueError(t("UNKNOWN_DOCKERFILE", dockerfile=selected_dockerfile))
 

docker/setup.py

@@ -10,6 +10,7 @@ setup(
         "pyyaml>=6.0",
         "python-i18n>=0.3.9",
         "inquirerpy>=0.3.4",
+        "python-dotenv>=0.19.1",
     ],
     entry_points={
         "console_scripts": [