Fix logging clear behavior

chat_interface_preference.py

@@ -40,6 +40,7 @@ from huggingface_hub import CommitScheduler
 pattern = re.compile(r'<div class="message-identifier">(.*?)</div>', re.DOTALL)
 
 PREFERENCE_TECHNIQUE_MAPPING = {"sft": "prompt", "dpo": "preference", "kto": "vibes"}
+_LOG_REQUIRED_MESSAGE = "First, provide preference, undo or clear to continue conversation."
 
 
 @document()
@@ -685,7 +686,7 @@ class ChatInterface(Blocks):
         else:
             response = None
         if self._check_if_two_responses(response):
-            Info("Two options detected: provide preference, undo or clear to continue conversation.")
+            Info(_LOG_REQUIRED_MESSAGE)
             return history, history
         else:
             inputs, _, _ = special_args(self.fn, inputs=[message, history, *args], request=request)
@@ -730,7 +731,7 @@ class ChatInterface(Blocks):
         else:
             response = None
         if self._check_if_two_responses(response):
-            Info("Two options detected: provide preference, undo or clear to continue conversation.")
+            Info(_LOG_REQUIRED_MESSAGE)
             yield history, history
         else:
             inputs, _, _ = special_args(self.fn, inputs=[message, history, *args], request=request)
@@ -815,19 +816,18 @@ class ChatInterface(Blocks):
         list[list[str | tuple | None]],
     ]:
         self._check_num_turns(history, generate=False)
+        prompt, response = history[-1]
         history_as_openai_format = self._get_conversation_in_openai_format(history)
         feedback = {"prompt": history_as_openai_format}
-
-        prompt, response = history[-1]
+        feedback.update({"response": [{"content": response, "role": "assistant"}]})
         matches = self._check_if_two_responses(response)
+
         if matches and log != "prompt":
             option_a, option_b = matches[0], matches[1]
             if log == "a":
                 chosen, rejected = option_a, option_b
-                Info("Logged preference: a")
             elif log == "b":
                 chosen, rejected = option_b, option_a
-                Info("Logged preference: b")
             elif log == "ab":
                 options = [option_a, option_b]
                 chosen, rejected = random.choice([options])
@@ -839,23 +839,26 @@ class ChatInterface(Blocks):
                         "rejected": [{"content": rejected, "role": "assistant"}],
                     }
                 )
+                feedback["response"] = [{"content": chosen, "role": "assistant"}]
                 self._save_feedback(feedback)
+                Info("Logged succesfully")
             elif log == "ab":
                 self._save_feedback(feedback)
             history[-1] = [prompt, chosen]
             return history, message or "", history
         elif log in ["conversation", "good", "bad"]:
-            feedback.update({"response": response})
             if log == "good":
                 feedback.update({"label": True})
             elif log == "bad":
                 feedback.update({"label": False})
-            Info("Logged conversation")
-            self._save_feedback(feedback)
 
+            self._save_feedback(feedback)
+            Info("Logged succesfully")
             return history, "", history
         else:
-            raise Error("Error in code w.r.t logging.")
+            self._save_feedback(feedback)
+            Info("Logged succesfully")
+            return history, "", history
 
     async def _examples_fn(self, message: str, *args) -> list[list[str | None]]:
         inputs, _, _ = special_args(self.fn, inputs=[message, [], *args], request=None)
@@ -907,7 +910,8 @@ class ChatInterface(Blocks):
         if history:
             _, response = history[-1]
             if self._check_if_two_responses(response):
-                raise Error("First log preference or continue random.")
+                Info(_LOG_REQUIRED_MESSAGE)
+                return history, message or "", history
             else:
                 await self._log_fn(message=message, history=history, log="prompt")
                 self._set_conversation_id()