fix subsets in `_split_generators`

open_access.py

@@ -104,6 +104,14 @@ class OpenAccess(datasets.GeneratorBasedBuilder):
         )
 
     def _split_generators(self, dl_manager):
+
+        incremental_paths = {
+            "incremental_file_lists": [],
+            "incremental_archives": []
+            }
+        baseline_file_lists = []
+        baseline_archives = []
+
         for subset in self.config.subsets:
             url = _URL.format(subset=_SUBSETS[subset])
             basename = f"{_SUBSETS[subset]}_txt."
@@ -114,8 +122,6 @@ class OpenAccess(datasets.GeneratorBasedBuilder):
             #     "baseline_archives": [f"{url}{basename}{baseline}.tar.gz" for baseline in baselines],
             # }
             # baseline_paths = dl_manager.download(baseline_urls)
-            baseline_file_lists = []
-            baseline_archives = []
             for baseline in baselines:
                 baseline_file_list_url = f"{url}{basename}{baseline}.filelist.csv"
                 try:
@@ -142,20 +148,23 @@ class OpenAccess(datasets.GeneratorBasedBuilder):
                 ],
                 "incremental_archives": [f"{url}{basename}{incremental}.tar.gz" for incremental in incrementals],
             }
-            incremental_paths = dl_manager.download(incremental_urls)
-            return [
-                datasets.SplitGenerator(
-                    name=datasets.Split.TRAIN,
-                    gen_kwargs={
-                        "baseline_file_lists": baseline_file_lists,
-                        "baseline_archives": [dl_manager.iter_archive(archive) for archive in baseline_archives],
-                        "incremental_file_lists": incremental_paths["incremental_file_lists"],
-                        "incremental_archives": [
-                            dl_manager.iter_archive(archive) for archive in incremental_paths["incremental_archives"]
-                        ],
-                    },
-                ),
-            ]
+            paths = dl_manager.download(incremental_urls)
+            incremental_paths["incremental_file_lists"].extend(paths["incremental_file_lists"])
+            incremental_paths["incremental_archives"].extend(paths["incremental_archives"])
+
+        return [
+            datasets.SplitGenerator(
+                name=datasets.Split.TRAIN,
+                gen_kwargs={
+                    "baseline_file_lists": baseline_file_lists,
+                    "baseline_archives": [dl_manager.iter_archive(archive) for archive in baseline_archives],
+                    "incremental_file_lists": incremental_paths["incremental_file_lists"],
+                    "incremental_archives": [
+                        dl_manager.iter_archive(archive) for archive in incremental_paths["incremental_archives"]
+                    ],
+                },
+            ),
+        ]
 
     def _generate_examples(self, baseline_file_lists, baseline_archives, incremental_file_lists, incremental_archives):
         key = 0